Re: [PATCH] contrib/plugins: ensure build does not pick up a system copy of plugin header

2024-09-21 Thread Alex Bennée
Brad Smith writes: > On 2024-09-21 8:55 a.m., Alex Bennée wrote: >> Brad Smith writes: >> >>> contrib/plugins: ensure build does not pick up a system copy of plugin >>> header >> I'm confused because this changes the ordering of the GLIB inclusion. We >> shouldn't be including the whole QEMU inc

Re: [PATCH] contrib/plugins: ensure build does not pick up a system copy of plugin header

2024-09-21 Thread Brad Smith
On 2024-09-21 8:55 a.m., Alex Bennée wrote: Brad Smith writes: contrib/plugins: ensure build does not pick up a system copy of plugin header I'm confused because this changes the ordering of the GLIB inclusion. We shouldn't be including the whole QEMU include path. That's intentional. The G

Re: [PATCH] contrib/plugins: ensure build does not pick up a system copy of plugin header

2024-09-21 Thread Alex Bennée
Brad Smith writes: > contrib/plugins: ensure build does not pick up a system copy of plugin > header I'm confused because this changes the ordering of the GLIB inclusion. We shouldn't be including the whole QEMU include path. How does this fail? > With the ordering of the header path if a copy

[PATCH] contrib/plugins: ensure build does not pick up a system copy of plugin header

2024-09-20 Thread Brad Smith
contrib/plugins: ensure build does not pick up a system copy of plugin header With the ordering of the header path if a copy of QEMU is installed it will pickup the system copy of the header before the build paths copy and the build will fail. Signed-off-by: Brad Smith --- contrib/plugins/Makef