Re: [PATCH] configure: ignore --make

2022-06-08 Thread Matheus Kowalczuk Ferst
On 08/06/2022 12:54, Paolo Bonzini wrote: > On 6/8/22 16:21, Matheus Kowalczuk Ferst wrote: >> Also, we will not have this error at configure-time anymore, but I >> suppose that *BSD users will identify the problem if they try to build >> with non-gnu make. > > Yeah, my guess was that "try ./confi

Re: [PATCH] configure: ignore --make

2022-06-08 Thread Paolo Bonzini
On 6/8/22 16:21, Matheus Kowalczuk Ferst wrote: On a clean build on FreeBSD with this patch, I got: ../meson.build:3641:0: ERROR: Key MAKE is not in dict So it seems that we need to remove the use of MAKE in meson.build too. Oops, yes. That's the typical "forget git commit --amend before sen

Re: [PATCH] configure: ignore --make

2022-06-08 Thread Matheus Kowalczuk Ferst
On 07/06/2022 07:49, Paolo Bonzini wrote: > Setting the MAKE variable to a GNU Make executable does not really have > any effect: if a non-GNU Make is used, the QEMU Makefile will fail to > parse. Just remove everything related to --make and $make as dead code. > > Signed-off-by: Paolo Bonzini >

[PATCH] configure: ignore --make

2022-06-07 Thread Paolo Bonzini
Setting the MAKE variable to a GNU Make executable does not really have any effect: if a non-GNU Make is used, the QEMU Makefile will fail to parse. Just remove everything related to --make and $make as dead code. Signed-off-by: Paolo Bonzini --- configure | 16 +--- 1 file changed,