Re: [PATCH] configure: Support modules for Windows

2021-11-05 Thread LIU Zhiwei
On 2021/11/5 下午8:22, Daniel P. Berrangé wrote: On Fri, Nov 05, 2021 at 08:14:29PM +0800, LIU Zhiwei wrote: On 2021/11/5 下午5:30, Daniel P. Berrangé wrote: On Fri, Nov 05, 2021 at 11:20:02AM +0800, LIU Zhiwei wrote: Generally we expect a commit message describing what is being solved and any r

Re: [PATCH] configure: Support modules for Windows

2021-11-05 Thread Daniel P . Berrangé
On Fri, Nov 05, 2021 at 08:14:29PM +0800, LIU Zhiwei wrote: > > On 2021/11/5 下午5:30, Daniel P. Berrangé wrote: > > On Fri, Nov 05, 2021 at 11:20:02AM +0800, LIU Zhiwei wrote: > > > > Generally we expect a commit message describing what is being solved > > and any reasons for the approach taken. >

Re: [PATCH] configure: Support modules for Windows

2021-11-05 Thread LIU Zhiwei
On 2021/11/5 下午6:36, Michael Tokarev wrote: 05.11.2021 06:20, LIU Zhiwei wrote: ... diff --git a/meson.build b/meson.build index 47df10afc2..26195cb24f 100644 ... @@ -2800,14 +2800,15 @@ common_ss.add(hwcore)   ###   # Targets #   ### - -foreach m : block_mods + softmmu_mods

Re: [PATCH] configure: Support modules for Windows

2021-11-05 Thread LIU Zhiwei
On 2021/11/5 下午5:30, Daniel P. Berrangé wrote: On Fri, Nov 05, 2021 at 11:20:02AM +0800, LIU Zhiwei wrote: Generally we expect a commit message describing what is being solved and any reasons for the approach taken. This patch relaxes all constraints on modules for Windows.  It firstly expo

Re: [PATCH] configure: Support modules for Windows

2021-11-05 Thread Michael Tokarev
05.11.2021 06:20, LIU Zhiwei wrote: ... diff --git a/meson.build b/meson.build index 47df10afc2..26195cb24f 100644 ... @@ -2800,14 +2800,15 @@ common_ss.add(hwcore) ### # Targets # ### - -foreach m : block_mods + softmmu_mods - shared_module(m.name(), -nam

Re: [PATCH] configure: Support modules for Windows

2021-11-05 Thread Daniel P . Berrangé
On Fri, Nov 05, 2021 at 11:20:02AM +0800, LIU Zhiwei wrote: Generally we expect a commit message describing what is being solved and any reasons for the approach taken. > Signed-off-by: LIU Zhiwei > --- > configure | 7 +-- > meson.build | 34 -- > 2 files

[PATCH] configure: Support modules for Windows

2021-11-04 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- configure | 7 +-- meson.build | 34 -- 2 files changed, 25 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 33682cb971..6280e412a9 100755 --- a/configure +++ b/configure @@ -1422,7 +1422,7 @@ cat << EOF

[PATCH] configure: Support modules for Windows

2021-11-04 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- configure | 7 +-- meson.build | 34 -- 2 files changed, 25 insertions(+), 16 deletions(-) diff --git a/configure b/configure index 33682cb971..6280e412a9 100755 --- a/configure +++ b/configure @@ -1422,7 +1422,7 @@ cat << EOF