Re: [PATCH] configure: Fixes ncursesw detection under msys2/mingw and enable curses

2020-09-06 Thread Yonggang Luo
On Sun, Sep 6, 2020 at 11:28 AM Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/5/20 1:42 PM, Yonggang Luo wrote: > > +nativecharset_to_ucs2 = iconv_open("UCS-2", g_get_codeset()); > > g_get_codeset(): > "a newly allocated string containing the name of the character set. This >

Re: [PATCH] configure: Fixes ncursesw detection under msys2/mingw and enable curses

2020-09-05 Thread Richard Henderson
On 9/5/20 1:42 PM, Yonggang Luo wrote: > +nativecharset_to_ucs2 = iconv_open("UCS-2", g_get_codeset()); g_get_codeset(): "a newly allocated string containing the name of the character set. This string must be freed with g_free()." You need to plug the memory leak. It's probably worth fixing

[PATCH] configure: Fixes ncursesw detection under msys2/mingw and enable curses

2020-09-05 Thread Yonggang Luo
The mingw pkg-config are showing following absolute path and contains : as the separator, so we must handling : properly. -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L -IC:/CI-Tools/msys64/mingw64/include/ncursesw:-I/usr/include/ncursesw: -DNCURSES_WIDECHAR -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=