Re: [PATCH] configure: Check bzip2 is available

2019-11-11 Thread Aleksandar Markovic
On Monday, November 11, 2019, Thomas Huth wrote: > On 08/11/2019 18.10, Peter Maydell wrote: > > On Fri, 8 Nov 2019 at 17:07, Philippe Mathieu-Daudé > wrote: > >> On 11/8/19 4:43 PM, Eric Blake wrote: > >>> bzip2 is no longer a favored compression. If we are trying to pick a > >>> compression t

Re: [PATCH] configure: Check bzip2 is available

2019-11-11 Thread Thomas Huth
On 08/11/2019 18.10, Peter Maydell wrote: > On Fri, 8 Nov 2019 at 17:07, Philippe Mathieu-Daudé wrote: >> On 11/8/19 4:43 PM, Eric Blake wrote: >>> bzip2 is no longer a favored compression. If we are trying to pick a >>> compression that is most likely to be present on any system, go with >>> gzi

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Peter Maydell
On Fri, 8 Nov 2019 at 17:07, Philippe Mathieu-Daudé wrote: > On 11/8/19 4:43 PM, Eric Blake wrote: > > bzip2 is no longer a favored compression. If we are trying to pick a > > compression that is most likely to be present on any system, go with > > gzip. If we are trying to pick a compression th

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 4:43 PM, Eric Blake wrote: On 11/8/19 5:01 AM, Laszlo Ersek wrote: Add a check in ./configure to warn the user if bzip2 is missing. We've come full circle. Let me explain: Fixes: 536d2173b2b So this makes me kinda grumpy. If you look at the v3 posting of the patch that would

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Eric Blake
On 11/8/19 5:01 AM, Laszlo Ersek wrote: Add a check in ./configure to warn the user if bzip2 is missing. We've come full circle. Let me explain: Fixes: 536d2173b2b So this makes me kinda grumpy. If you look at the v3 posting of the patch that would later become commit 536d2173b2b: h

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Thomas Huth
On 08/11/2019 12.39, Laszlo Ersek wrote: On 11/08/19 11:42, Philippe Mathieu-Daudé wrote: On 11/8/19 11:34 AM, Thomas Huth wrote: On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but '

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 12:39 PM, Laszlo Ersek wrote: On 11/08/19 11:42, Philippe Mathieu-Daudé wrote: On 11/8/19 11:34 AM, Thomas Huth wrote: On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but '

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Thomas Huth
On 08/11/2019 12.54, Philippe Mathieu-Daudé wrote: On 11/8/19 12:01 PM, Laszlo Ersek wrote: On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 12:01 PM, Laszlo Ersek wrote: On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2:

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Laszlo Ersek
On 11/08/19 11:42, Philippe Mathieu-Daudé wrote: > On 11/8/19 11:34 AM, Thomas Huth wrote: >> On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: >>> The bzip2 tool is not included in default installations. >>> On freshly installed systems, ./configure succeeds but 'make' >>> might fail later: >>> >

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 12:01:16PM +0100, Laszlo Ersek wrote: > On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: > > The bzip2 tool is not included in default installations. > > On freshly installed systems, ./configure succeeds but 'make' > > might fail later: > > > > BUNZIP2 pc-bios/edk2-i38

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Laszlo Ersek
On 11/08/19 11:28, Philippe Mathieu-Daudé wrote: > The bzip2 tool is not included in default installations. > On freshly installed systems, ./configure succeeds but 'make' > might fail later: > > BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 > /bin/sh: bzip2: command not found > make: *** [

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
On 11/8/19 11:34 AM, Thomas Huth wrote: On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2    /bin/sh: bzip2

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Thomas Huth
On 08/11/2019 11.28, Philippe Mathieu-Daudé wrote: The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefil

Re: [PATCH] configure: Check bzip2 is available

2019-11-08 Thread Daniel P . Berrangé
On Fri, Nov 08, 2019 at 11:28:05AM +0100, Philippe Mathieu-Daudé wrote: > The bzip2 tool is not included in default installations. > On freshly installed systems, ./configure succeeds but 'make' > might fail later: > > BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 > /bin/sh: bzip2: command no

[PATCH] configure: Check bzip2 is available

2019-11-08 Thread Philippe Mathieu-Daudé
The bzip2 tool is not included in default installations. On freshly installed systems, ./configure succeeds but 'make' might fail later: BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 /bin/sh: bzip2: command not found make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127 mak