Re: [PATCH] checkpatch: reversed logic with acpi test checks

2020-06-04 Thread Peter Maydell
On Thu, 4 Jun 2020 at 20:09, Michael S. Tsirkin wrote: > On Thu, Jun 04, 2020 at 08:45:15PM +0200, Paolo Bonzini wrote: > > On 02/06/20 07:36, Michael S. Tsirkin wrote: > > > + } elsif (not $name =~ > > > m#^tests/qtest/bios-tables-test-allowed-diff.h$#) { > > > $$acpi_nontestexpec

Re: [PATCH] checkpatch: reversed logic with acpi test checks

2020-06-04 Thread Michael S. Tsirkin
On Thu, Jun 04, 2020 at 08:45:15PM +0200, Paolo Bonzini wrote: > On 02/06/20 07:36, Michael S. Tsirkin wrote: > > Logic reversed: allowed list should just be ignored. Instead we > > only take that into account :( > > > > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") > > Signed-off-b

Re: [PATCH] checkpatch: reversed logic with acpi test checks

2020-06-04 Thread Paolo Bonzini
On 02/06/20 07:36, Michael S. Tsirkin wrote: > Logic reversed: allowed list should just be ignored. Instead we > only take that into account :( > > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") > Signed-off-by: Michael S. Tsirkin > --- > scripts/checkpatch.pl | 2 +- > 1 file chan

Re: [PATCH] checkpatch: reversed logic with acpi test checks

2020-06-02 Thread Auger Eric
Hi, On 6/2/20 7:36 AM, Michael S. Tsirkin wrote: > Logic reversed: allowed list should just be ignored. Instead we > only take that into account :( > > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") > Signed-off-by: Michael S. Tsirkin Fixes issues reported in "[RFC 0/6] TPM-TIS bi

Re: [PATCH] checkpatch: reversed logic with acpi test checks

2020-06-02 Thread Philippe Mathieu-Daudé
On 6/2/20 7:36 AM, Michael S. Tsirkin wrote: > Logic reversed: allowed list should just be ignored. Instead we > only take that into account :( > > Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") > Signed-off-by: Michael S. Tsirkin > --- > scripts/checkpatch.pl | 2 +- > 1 file chan

[PATCH] checkpatch: reversed logic with acpi test checks

2020-06-01 Thread Michael S. Tsirkin
Logic reversed: allowed list should just be ignored. Instead we only take that into account :( Fixes: e11b06a880ca ("checkpatch: ignore allowed diff list") Signed-off-by: Michael S. Tsirkin --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/chec