Re: [PATCH] checkpatch: Fix use of uninitialized value

2021-04-09 Thread Isaku Yamahata
On Fri, Apr 09, 2021 at 07:40:11AM +0200, Greg Kurz wrote: > On Thu, 8 Apr 2021 10:49:13 -0700 > Isaku Yamahata wrote: > > > > > How about initializing them explicitly as follows? > > ($realfile ne '') prevents the case realfile eq '' && acpi_testexpted eq ''. > > Anyway your patch also should

Re: [PATCH] checkpatch: Fix use of uninitialized value

2021-04-09 Thread Alex Bennée
Greg Kurz writes: > checkfilename() doesn't always set $acpi_testexpected. Fix the following > warning: > > Use of uninitialized value $acpi_testexpected in string eq at > ./scripts/checkpatch.pl line 1529. > > Fixes: d2f1af0e4120 ("checkpatch: don't emit warning on newly created acpi > data

Re: [PATCH] checkpatch: Fix use of uninitialized value

2021-04-08 Thread Greg Kurz
On Thu, 8 Apr 2021 10:49:13 -0700 Isaku Yamahata wrote: > > How about initializing them explicitly as follows? > ($realfile ne '') prevents the case realfile eq '' && acpi_testexpted eq ''. > Anyway your patch also should fix it. So > Reviewed-by: Isaku Yamahata > > > diff --git a/scripts/che

Re: [PATCH] checkpatch: Fix use of uninitialized value

2021-04-08 Thread Isaku Yamahata
How about initializing them explicitly as follows? ($realfile ne '') prevents the case realfile eq '' && acpi_testexpted eq ''. Anyway your patch also should fix it. So Reviewed-by: Isaku Yamahata diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 8f7053ec9b..2eb894a628 100755 --

[PATCH] checkpatch: Fix use of uninitialized value

2021-04-07 Thread Greg Kurz
checkfilename() doesn't always set $acpi_testexpected. Fix the following warning: Use of uninitialized value $acpi_testexpected in string eq at ./scripts/checkpatch.pl line 1529. Fixes: d2f1af0e4120 ("checkpatch: don't emit warning on newly created acpi data files") Cc: isaku.yamah...@intel.com