Re: [PATCH] char: don't fail when client is not connected

2021-02-03 Thread Marc-André Lureau
Hi On Wed, Feb 3, 2021 at 12:22 PM Pavel Dovgalyuk wrote: > On 03.02.2021 11:13, Marc-André Lureau wrote: > > > Can you provide a reproducer? > > > That was a record/replay scenario. I've used Fedora cloudinit images, > that are used in acceptance tests: > > qemu-system-x86_64 \ > -display non

Re: [PATCH] char: don't fail when client is not connected

2021-02-03 Thread Pavel Dovgalyuk
On 03.02.2021 11:13, Marc-André Lureau wrote: Hi On Tue, Feb 2, 2021 at 11:33 AM Pavel Dovgalyuk mailto:pavel.dovgal...@ispras.ru>> wrote: On 02.02.2021 10:27, Marc-André Lureau wrote: > Hi > > On Tue, Feb 2, 2021 at 11:18 AM Pavel Dovgalyuk > mailto:pavel.dovgal...@is

Re: [PATCH] char: don't fail when client is not connected

2021-02-03 Thread Marc-André Lureau
Hi On Tue, Feb 2, 2021 at 11:33 AM Pavel Dovgalyuk wrote: > On 02.02.2021 10:27, Marc-André Lureau wrote: > > Hi > > > > On Tue, Feb 2, 2021 at 11:18 AM Pavel Dovgalyuk > > mailto:pavel.dovgal...@ispras.ru>> wrote: > > > > This patch checks that ioc is not null before > > using it in tcp

Re: [PATCH] char: don't fail when client is not connected

2021-02-01 Thread Pavel Dovgalyuk
On 02.02.2021 10:27, Marc-André Lureau wrote: Hi On Tue, Feb 2, 2021 at 11:18 AM Pavel Dovgalyuk mailto:pavel.dovgal...@ispras.ru>> wrote: This patch checks that ioc is not null before using it in tcp socket tcp_chr_add_watch function. Signed-off-by: Pavel Dovgalyuk mailto:pavel.

Re: [PATCH] char: don't fail when client is not connected

2021-02-01 Thread Marc-André Lureau
Hi On Tue, Feb 2, 2021 at 11:18 AM Pavel Dovgalyuk wrote: > This patch checks that ioc is not null before > using it in tcp socket tcp_chr_add_watch function. > > Signed-off-by: Pavel Dovgalyuk > Do you have a backtrace or a reproducer when this happens? thanks --- > chardev/char-socket.c |

[PATCH] char: don't fail when client is not connected

2021-02-01 Thread Pavel Dovgalyuk
This patch checks that ioc is not null before using it in tcp socket tcp_chr_add_watch function. Signed-off-by: Pavel Dovgalyuk --- chardev/char-socket.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index 213a4c8dd0..cef1d9438f 100644 --