Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-28 Thread Peter Maydell
On Tue, 28 Jul 2020 at 09:48, Thomas Huth wrote: > > On 27/07/2020 16.41, Peter Maydell wrote: > > On Mon, 27 Jul 2020 at 14:03, Keqian Zhu wrote: > >> > >> Avoid covering object refcount of qemu_irq, otherwise it may causes > >> memory leak. > >> > >> Signed-off-by: Keqian Zhu > >> --- > >> hw

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-28 Thread zhukeqian
Hi Thomas, On 2020/7/28 16:48, Thomas Huth wrote: > On 27/07/2020 16.41, Peter Maydell wrote: >> On Mon, 27 Jul 2020 at 14:03, Keqian Zhu wrote: >>> >>> Avoid covering object refcount of qemu_irq, otherwise it may causes >>> memory leak. >>> >>> Signed-off-by: Keqian Zhu >>> --- >>> hw/core/irq

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-28 Thread Thomas Huth
On 27/07/2020 16.41, Peter Maydell wrote: > On Mon, 27 Jul 2020 at 14:03, Keqian Zhu wrote: >> >> Avoid covering object refcount of qemu_irq, otherwise it may causes >> memory leak. >> >> Signed-off-by: Keqian Zhu >> --- >> hw/core/irq.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-27 Thread zhukeqian
Hi Peter, On 2020/7/27 22:41, Peter Maydell wrote: > On Mon, 27 Jul 2020 at 14:03, Keqian Zhu wrote: >> >> Avoid covering object refcount of qemu_irq, otherwise it may causes >> memory leak. >> >> Signed-off-by: Keqian Zhu >> --- >> hw/core/irq.c | 4 +++- >> 1 file changed, 3 insertions(+), 1

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-27 Thread zhukeqian
Hi Qiang, On 2020/7/27 22:37, Li Qiang wrote: > Keqian Zhu 于2020年7月27日周一 下午9:03写道： >> >> Avoid covering object refcount of qemu_irq, otherwise it may causes >> memory leak. > > Any reproducer? > In mainline Qemu. this function is only used in qtest. One of our internal self-developed module als

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-27 Thread Peter Maydell
On Mon, 27 Jul 2020 at 14:03, Keqian Zhu wrote: > > Avoid covering object refcount of qemu_irq, otherwise it may causes > memory leak. > > Signed-off-by: Keqian Zhu > --- > hw/core/irq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/core/irq.c b/hw/core/irq.c > i

Re: [PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-27 Thread Li Qiang
Keqian Zhu 于2020年7月27日周一 下午9:03写道： > > Avoid covering object refcount of qemu_irq, otherwise it may causes > memory leak. Any reproducer? Thanks, Li Qiang > > Signed-off-by: Keqian Zhu > --- > hw/core/irq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/core/ir

[PATCH] bugfix: irq: Avoid covering object refcount of qemu_irq

2020-07-27 Thread Keqian Zhu
Avoid covering object refcount of qemu_irq, otherwise it may causes memory leak. Signed-off-by: Keqian Zhu --- hw/core/irq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/core/irq.c b/hw/core/irq.c index fb3045b912..59af4dfc74 100644 --- a/hw/core/irq.c +++ b/hw/core/