Re: [PATCH] block: Return the real error code in bdrv_getlength

2020-11-05 Thread Eric Blake
On 11/4/20 9:10 PM, Tuguoyi wrote: > The return code from bdrv_nb_sectors() should be checked before doing > the following sanity check. > > Signed-off-by: Guoyi Tu It looks like you sent several variations on this patch. A meta-observation: your mailer is attributing the patch to the spelling

Re: [PATCH] block: Return the real error code in bdrv_getlength

2020-11-05 Thread Eric Blake
On 11/4/20 11:41 PM, Tuguoyi wrote: > Sorry, please ignore this patch, it's not a right fix What's not right about it? >> +++ b/block.c >> @@ -5082,6 +5082,10 @@ int64_t bdrv_getlength(BlockDriverState *bs) >> { >> int64_t ret = bdrv_nb_sectors(bs); >> >> +if (ret < 0) { >> +re

RE: [PATCH] block: Return the real error code in bdrv_getlength

2020-11-04 Thread Tuguoyi
Cc: 'qemu-devel@nongnu.org' > Subject: [PATCH] block: Return the real error code in bdrv_getlength > > The return code from bdrv_nb_sectors() should be checked before doing > the following sanity check. > > Signed-off-by: Guoyi Tu > --- > block.c | 4

[PATCH] block: Return the real error code in bdrv_getlength

2020-11-04 Thread Tuguoyi
The return code from bdrv_nb_sectors() should be checked before doing the following sanity check. Signed-off-by: Guoyi Tu --- block.c | 4 1 file changed, 4 insertions(+) diff --git a/block.c b/block.c index 430edf7..19ebbc0 100644 --- a/block.c +++ b/block.c @@ -5082,6 +5082,10 @@ int64_