Re: [PATCH] block/curl: rewrite http header parsing function

2024-07-18 Thread Kevin Wolf
Am 29.06.2024 um 16:25 hat Michael Tokarev geschrieben: > Existing code was long, unclear and twisty. > > Signed-off-by: Michael Tokarev > --- > block/curl.c | 44 ++-- > 1 file changed, 18 insertions(+), 26 deletions(-) > > diff --git a/block/curl.c b/bl

Re: [PATCH] block/curl: rewrite http header parsing function

2024-07-01 Thread Vladimir Sementsov-Ogievskiy
On 01.07.24 09:55, Michael Tokarev wrote: 01.07.2024 09:54, Vladimir Sementsov-Ogievskiy wrote: +    const char *t = "accept-ranges : bytes "; /* A lowercase template */ Note: you make parser less strict: you allow "bytes" to be uppercase (was allowed only for accept-ranges", and you allow w

Re: [PATCH] block/curl: rewrite http header parsing function

2024-06-30 Thread Michael Tokarev
01.07.2024 09:54, Vladimir Sementsov-Ogievskiy wrote: +    const char *t = "accept-ranges : bytes "; /* A lowercase template */ Note: you make parser less strict: you allow "bytes" to be uppercase (was allowed only for accept-ranges", and you allow whitespaces before colon. Yes, exactly. I

Re: [PATCH] block/curl: rewrite http header parsing function

2024-06-30 Thread Vladimir Sementsov-Ogievskiy
On 29.06.24 17:25, Michael Tokarev wrote: Existing code was long, unclear and twisty. Signed-off-by: Michael Tokarev Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/curl.c | 44 ++-- 1 file changed, 18 insertions(+), 26 deletions(-) diff --gi

[PATCH] block/curl: rewrite http header parsing function

2024-06-29 Thread Michael Tokarev
Existing code was long, unclear and twisty. Signed-off-by: Michael Tokarev --- block/curl.c | 44 ++-- 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/block/curl.c b/block/curl.c index 419f7c89ef..9802d0319d 100644 --- a/block/curl.c +++ b/