Re: [PATCH] backup-top: fix a memory leak in bdrv_backup_top_append()

2020-01-20 Thread Pan Nengyuan
On 1/20/2020 4:38 PM, Vladimir Sementsov-Ogievskiy wrote: > Hi Pan! > > Better is to drop extra allocation. Correct patch already posted here: > https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05067.html > Yes, it's better. Thanks. > 20.01.2020 10:47, pannengy...@huawei.com wrote:

Re: [PATCH] backup-top: fix a memory leak in bdrv_backup_top_append()

2020-01-20 Thread Vladimir Sementsov-Ogievskiy
Hi Pan! Better is to drop extra allocation. Correct patch already posted here: https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg05067.html 20.01.2020 10:47, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > top->opaque is aleardy malloced in bdrv_new_open_driver(), and then change

[PATCH] backup-top: fix a memory leak in bdrv_backup_top_append()

2020-01-19 Thread pannengyuan
From: Pan Nengyuan top->opaque is aleardy malloced in bdrv_new_open_driver(), and then change the pointer but without freeing it. It will cause a memory leak, the leak stack is as follow: Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0x7ff6f7be4970 (/lib64/libasan.so.5+0xef970)