Hi Brad,
I tested the sndio backend on my Linux system and I found a bug in the
sndio backend. The problem is that the function audio_run() can call the
function sndio_enable_out() to disable audio playback.
In the sndio_poll_event() function, audio_run() is called, which removes
the poll ha
Hi Brad,
just a few white space and coding style issues.
+/*
+ * stop polling descriptors
+ */
+static void sndio_poll_clear(SndioVoice *self)
+{
+struct pollfd *pfd;
+int i;
+
+for (i = 0; i < self->nfds; i++) {
+pfd = &self->pfds[i];
+qemu_set_fd_handler (pfd->fd,
On 11/14/2021 8:18 AM, Christian Schoenebeck wrote:
On Samstag, 13. November 2021 21:40:39 CET Brad Smith wrote:
On 11/8/2021 8:03 AM, Christian Schoenebeck wrote:
On Sonntag, 7. November 2021 06:19:26 CET Brad Smith wrote:
audio: Add sndio backend
Add a sndio backend.
Hi Brad!
sndio is t
On Samstag, 13. November 2021 21:40:39 CET Brad Smith wrote:
> On 11/8/2021 8:03 AM, Christian Schoenebeck wrote:
> > On Sonntag, 7. November 2021 06:19:26 CET Brad Smith wrote:
> >> audio: Add sndio backend
> >>
> >> Add a sndio backend.
> >
> > Hi Brad!
> >
> >> sndio is the native API used by
On 11/10/2021 1:22 AM, WANG Xuerui wrote:
On 2021/11/7 13:19, Brad Smith wrote:
audio: Add sndio backend
Add a sndio backend.
sndio is the native API used by OpenBSD, although it has been ported to
other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
The C code is from Ale
On 11/8/2021 9:58 AM, Paolo Bonzini wrote:
On 11/7/21 06:19, Brad Smith wrote:
if not get_option('spice_protocol').auto() or have_system
@@ -1301,6 +1306,7 @@ if have_system
'oss': oss.found(),
'pa': pulse.found(),
'sdl': sdl.found(),
+ 'sndio': sndio.found(),
}
f
On 11/8/2021 8:03 AM, Christian Schoenebeck wrote:
On Sonntag, 7. November 2021 06:19:26 CET Brad Smith wrote:
audio: Add sndio backend
Add a sndio backend.
Hi Brad!
sndio is the native API used by OpenBSD, although it has been ported to
other *BSD's and Linux (packages for Ubuntu, Debian,
Hi Brad,
audio: Add sndio backend
Add a sndio backend.
sndio is the native API used by OpenBSD, although it has been ported to
other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
The C code is from Alexandre Ratchov and the rest of
the bits are from me.
---
audio/audio.
El mar., 9 nov. 2021 22:53, Brad Smith escribió:
> On 11/8/2021 9:58 AM, Paolo Bonzini wrote:
>
> > Maybe you want to add sndio to the audio_drivers_priority array if
> > targetos == 'openbsd'?
>
> That part I was not 100% sure of.
>
> Am I to understand with the current Meson code it will try to
On 2021/11/7 13:19, Brad Smith wrote:
> audio: Add sndio backend
>
> Add a sndio backend.
>
> sndio is the native API used by OpenBSD, although it has been ported to
> other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
>
> The C code is from Alexandre Ratchov and the rest of
On 11/8/2021 9:58 AM, Paolo Bonzini wrote:
On 11/7/21 06:19, Brad Smith wrote:
if not get_option('spice_protocol').auto() or have_system
@@ -1301,6 +1306,7 @@ if have_system
'oss': oss.found(),
'pa': pulse.found(),
'sdl': sdl.found(),
+ 'sndio': sndio.found(),
}
f
On 11/7/21 06:19, Brad Smith wrote:
if not get_option('spice_protocol').auto() or have_system
@@ -1301,6 +1306,7 @@ if have_system
'oss': oss.found(),
'pa': pulse.found(),
'sdl': sdl.found(),
+'sndio': sndio.found(),
}
foreach k, v: audio_drivers_available
co
On Sonntag, 7. November 2021 06:19:26 CET Brad Smith wrote:
> audio: Add sndio backend
>
> Add a sndio backend.
Hi Brad!
> sndio is the native API used by OpenBSD, although it has been ported to
> other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
>
> The C code is from Ale
audio: Add sndio backend
Add a sndio backend.
sndio is the native API used by OpenBSD, although it has been ported to
other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
The C code is from Alexandre Ratchov and the rest of
the bits are from me.
---
audio/audio.c |
> > > ERROR: g_free(NULL) is safe this check is probably not required
> > > #381: FILE: audio/sndioaudio.c:318:
> > > +if (self->pfds) {
> > > +g_free(self->pfds);
> > Reasonable too.
>
> Not clear to me. Leave as is or needs a change?
Just use "g_free(self->pfds)".
cheers,
Gerd
On 3/4/20 8:50 AM, Brad Smith wrote:
Add a sndio backend.
sndio is the native API used by OpenBSD, although it has been ported to
other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
The C code is from Alexandre Ratchov and the rest of
the bits are from me.
Signed-off-by:
information:
Subject: [PATCH] audio: Add sndio backend
Message-id: 20200304145003.gb15...@humpty.home.comstyle.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --lo
ation:
>
> Subject: [PATCH] audio: Add sndio backend
> Message-id: 20200304145003.gb15...@humpty.home.comstyle.com
> Type: series
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
&g
Patchew URL:
https://patchew.org/QEMU/20200304145003.gb15...@humpty.home.comstyle.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] audio: Add sndio backend
Message-id: 20200304145003.gb15...@humpty.home.comstyle.com
Type
Add a sndio backend.
sndio is the native API used by OpenBSD, although it has been ported to
other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).
The C code is from Alexandre Ratchov and the rest of
the bits are from me.
Signed-off-by: Alexandre Ratchov
Signed-off-by: Brad
20 matches
Mail list logo
