Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Christian Schoenebeck
On Wednesday, February 15, 2023 4:59:47 PM CET Daniel P. Berrangé wrote: > On Wed, Feb 15, 2023 at 05:18:50PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Gerd Hoffmann
On Wed, Feb 15, 2023 at 04:09:59PM +0100, Dorinda Bassey wrote: > > > > My point is that pipewire has ALSA plugin (and also pulseaudio compat > > library etc). So why add another back in QEMU? > > > Good question. Well the pulseaudio compatibility layer adds to the runtime > overhead and dependency

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Daniel P . Berrangé
On Thu, Feb 16, 2023 at 01:33:47PM +0300, Michael Tokarev wrote: > 15.02.2023 14:26, Daniel P. Berrangé пишет: > .. > > > - choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack', > > > 'oss', 'pa', 'sdl', 'sndio'], > > > + choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack'

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-16 Thread Michael Tokarev
15.02.2023 14:26, Daniel P. Berrangé пишет: .. - choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack', 'oss', 'pa', 'sdl', 'sndio'], + choices: ['alsa', 'coreaudio', 'default', 'dsound', 'jack', 'oss', 'pa', 'pw', 'sdl', 'sndio'], I appreciate you probably just followed the

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Daniel P . Berrangé
On Wed, Feb 15, 2023 at 05:18:50PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as > > both an audio sink and source. This backend is available on most systems. > > >

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Dorinda Bassey
> > Are there any additional features available when using the pipewire > protocol instead of pulseaudio or jack? yes, Pipewire supports both use cases, It is more or less a hybrid between pulseaudio and jack. Pipewire uses a much more accurate timing model for timer based scheduling. Pipewire pr

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Gerd Hoffmann
> > What is the main advantage compared to using the ALSA backend? (I > > assume pipewire depends on ALSA anyway on Linux) > > I think it does make sense to add Pipewire. Apparently it gains popularity. > > The main advantage of Pipewire is its interoperability: It allows you to > connect apps w

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Dorinda Bassey
> > My point is that pipewire has ALSA plugin (and also pulseaudio compat > library etc). So why add another back in QEMU? > Good question. Well the pulseaudio compatibility layer adds to the runtime overhead and dependency, dropping the usage of pw-pulse daemon as a runtime dependency would reduce

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Daniel P . Berrangé
On Wed, Feb 15, 2023 at 06:11:12PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Feb 15, 2023 at 6:09 PM Christian Schoenebeck > wrote: > > > > On Wednesday, February 15, 2023 2:18:50 PM CET Marc-André Lureau wrote: > > > Hi > > > > > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey > > > w

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Marc-André Lureau
Hi On Wed, Feb 15, 2023 at 6:09 PM Christian Schoenebeck wrote: > > On Wednesday, February 15, 2023 2:18:50 PM CET Marc-André Lureau wrote: > > Hi > > > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as >

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Christian Schoenebeck
On Wednesday, February 15, 2023 2:18:50 PM CET Marc-André Lureau wrote: > Hi > > On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems. > > >

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Marc-André Lureau
Hi On Wed, Feb 15, 2023 at 12:51 PM Dorinda Bassey wrote: > > This commit adds a new audiodev backend to allow QEMU to use Pipewire as both > an audio sink and source. This backend is available on most systems. > Hmm, I would rather have less audio (and ui) backends in QEMU. (for audio, if I co

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Dorinda Bassey
> > Can you ensure the commit message text is line wrapped at approx > 72 characters. > Noted, Thanks. Just to confirm, you are claiming both copyright ownership for Red Hat > *and* personal copyright ownership ? > I just made some enquiry and given that this was developed inside of work context

Re: [PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Daniel P . Berrangé
On Wed, Feb 15, 2023 at 09:51:02AM +0100, Dorinda Bassey wrote: > This commit adds a new audiodev backend to allow QEMU to use Pipewire as both > an audio sink and source. This backend is available on most systems. > > Added Pipewire entry points for QEMU Pipewire audio backend > Added wrappers f

[PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-15 Thread Dorinda Bassey
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems. Added Pipewire entry points for QEMU Pipewire audio backend Added wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() qpw_write function returns

[PATCH] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-02-14 Thread Dorinda Bassey
This commit adds a new audiodev backend to allow QEMU to use Pipewire as both an audio sink and source. This backend is available on most systems. Added Pipewire entry points for QEMU Pipewire audio backend Added wrappers for QEMU Pipewire audio backend in qpw_pcm_ops() qpw_write function returns