Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-06 Thread Gerd Hoffmann
On Thu, Apr 06, 2023 at 01:46:48PM +0200, Igor Mammedov wrote: > On Tue, 4 Apr 2023 12:46:45 +0200 > Gerd Hoffmann wrote: > > > On Tue, Apr 04, 2023 at 10:30:55AM +0200, Igor Mammedov wrote: > > > On Tue, 4 Apr 2023 09:03:59 +0200 > > > Gerd Hoffmann wrote: > > > > > > > Hi, > > > > > >

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-06 Thread Igor Mammedov
On Tue, 4 Apr 2023 12:46:45 +0200 Gerd Hoffmann wrote: > On Tue, Apr 04, 2023 at 10:30:55AM +0200, Igor Mammedov wrote: > > On Tue, 4 Apr 2023 09:03:59 +0200 > > Gerd Hoffmann wrote: > > > > > Hi, > > > > > > > > Allowing pending delete expire brings ACPI PCI hotplug on par > > > > > wit

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-05 Thread Ani Sinha
> On 05-Apr-2023, at 5:57 PM, Michael S. Tsirkin wrote: > > On Wed, Apr 05, 2023 at 02:03:32PM +0200, Igor Mammedov wrote: >> On Wed, 5 Apr 2023 05:59:06 -0400 >> "Michael S. Tsirkin" wrote: >> >>> On Wed, Apr 05, 2023 at 11:24:16AM +0200, Igor Mammedov wrote: >> PS: >> See commit me

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-05 Thread Michael S. Tsirkin
On Wed, Apr 05, 2023 at 02:03:32PM +0200, Igor Mammedov wrote: > On Wed, 5 Apr 2023 05:59:06 -0400 > "Michael S. Tsirkin" wrote: > > > On Wed, Apr 05, 2023 at 11:24:16AM +0200, Igor Mammedov wrote: > > > > > PS: > > > > > See commit message, Windows is not affected as it doesn't > > > > > clear G

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-05 Thread Igor Mammedov
On Wed, 5 Apr 2023 05:59:06 -0400 "Michael S. Tsirkin" wrote: > On Wed, Apr 05, 2023 at 11:24:16AM +0200, Igor Mammedov wrote: > > > > PS: > > > > See commit message, Windows is not affected as it doesn't > > > > clear GPE status bits during ACPI initialization > > > > (at least the one version I

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-05 Thread Michael S. Tsirkin
On Wed, Apr 05, 2023 at 11:24:16AM +0200, Igor Mammedov wrote: > > > PS: > > > See commit message, Windows is not affected as it doesn't > > > clear GPE status bits during ACPI initialization > > > (at least the one version I've tested with, and I won't bet > > > on this with other versions or stay

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-05 Thread Igor Mammedov
On Wed, 5 Apr 2023 04:32:16 -0400 "Michael S. Tsirkin" wrote: > On Wed, Apr 05, 2023 at 09:30:20AM +0200, Igor Mammedov wrote: > > On Tue, 4 Apr 2023 10:42:04 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Apr 04, 2023 at 04:04:35PM +0200, Igor Mammedov wrote: > > > > On Tue, 4 Apr

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-05 Thread Michael S. Tsirkin
On Wed, Apr 05, 2023 at 09:30:20AM +0200, Igor Mammedov wrote: > On Tue, 4 Apr 2023 10:42:04 -0400 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 04, 2023 at 04:04:35PM +0200, Igor Mammedov wrote: > > > On Tue, 4 Apr 2023 08:46:15 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Tue,

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-05 Thread Igor Mammedov
On Tue, 4 Apr 2023 10:42:04 -0400 "Michael S. Tsirkin" wrote: > On Tue, Apr 04, 2023 at 04:04:35PM +0200, Igor Mammedov wrote: > > On Tue, 4 Apr 2023 08:46:15 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Apr 04, 2023 at 10:28:07AM +0200, Igor Mammedov wrote: > > > > On Mon, 3 Apr

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Michael S. Tsirkin
On Tue, Apr 04, 2023 at 04:04:35PM +0200, Igor Mammedov wrote: > On Tue, 4 Apr 2023 08:46:15 -0400 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 04, 2023 at 10:28:07AM +0200, Igor Mammedov wrote: > > > On Mon, 3 Apr 2023 13:23:45 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon,

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Michael S. Tsirkin
On Tue, Apr 04, 2023 at 07:40:40PM +0530, Ani Sinha wrote: > > > On Tue, Apr 4, 2023 at 7:34 PM Igor Mammedov wrote: > > On Tue, 4 Apr 2023 08:46:15 -0400 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 04, 2023 at 10:28:07AM +0200, Igor Mammedov wrote: > > > On Mon, 3 Apr 202

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Igor Mammedov
On Tue, 4 Apr 2023 08:40:45 -0400 "Michael S. Tsirkin" wrote: > On Tue, Apr 04, 2023 at 01:06:38PM +0530, Ani Sinha wrote: > > > > > > On Tue, 4 Apr 2023, Gerd Hoffmann wrote: > > > > > Hi, > > > > > > > > Allowing pending delete expire brings ACPI PCI hotplug on par > > > > > with nativ

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Ani Sinha
On Tue, Apr 4, 2023 at 7:34 PM Igor Mammedov wrote: > On Tue, 4 Apr 2023 08:46:15 -0400 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 04, 2023 at 10:28:07AM +0200, Igor Mammedov wrote: > > > On Mon, 3 Apr 2023 13:23:45 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon, Apr 03, 2023

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Ani Sinha
On Mon, Apr 3, 2023 at 9:46 PM Igor Mammedov wrote: > with Q35 using ACPI PCI hotplug by default, user's request to unplug > device is ignored when it's issued before guest OS has been booted. > And any additional attempt to request device hot-unplug afterwards > results in following error: > >

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Igor Mammedov
On Tue, 4 Apr 2023 08:46:15 -0400 "Michael S. Tsirkin" wrote: > On Tue, Apr 04, 2023 at 10:28:07AM +0200, Igor Mammedov wrote: > > On Mon, 3 Apr 2023 13:23:45 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Apr 03, 2023 at 06:16:18PM +0200, Igor Mammedov wrote: > > > > with Q35 usin

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Michael S. Tsirkin
On Tue, Apr 04, 2023 at 10:28:07AM +0200, Igor Mammedov wrote: > On Mon, 3 Apr 2023 13:23:45 -0400 > "Michael S. Tsirkin" wrote: > > > On Mon, Apr 03, 2023 at 06:16:18PM +0200, Igor Mammedov wrote: > > > with Q35 using ACPI PCI hotplug by default, user's request to unplug > > > device is ignored

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Michael S. Tsirkin
On Tue, Apr 04, 2023 at 01:06:38PM +0530, Ani Sinha wrote: > > > On Tue, 4 Apr 2023, Gerd Hoffmann wrote: > > > Hi, > > > > > > Allowing pending delete expire brings ACPI PCI hotplug on par > > > > with native PCIe unplug behavior [1] which in its turn refers > > > > back to ACPI PCI hotplug a

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Gerd Hoffmann
On Tue, Apr 04, 2023 at 10:30:55AM +0200, Igor Mammedov wrote: > On Tue, 4 Apr 2023 09:03:59 +0200 > Gerd Hoffmann wrote: > > > Hi, > > > > > > Allowing pending delete expire brings ACPI PCI hotplug on par > > > > with native PCIe unplug behavior [1] which in its turn refers > > > > back to AC

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Igor Mammedov
On Tue, 4 Apr 2023 09:03:59 +0200 Gerd Hoffmann wrote: > Hi, > > > > Allowing pending delete expire brings ACPI PCI hotplug on par > > > with native PCIe unplug behavior [1] which in its turn refers > > > back to ACPI PCI hotplug ability to repeat unplug requests. > > > A bit concerned abou

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Igor Mammedov
On Mon, 3 Apr 2023 13:23:45 -0400 "Michael S. Tsirkin" wrote: > On Mon, Apr 03, 2023 at 06:16:18PM +0200, Igor Mammedov wrote: > > with Q35 using ACPI PCI hotplug by default, user's request to unplug > > device is ignored when it's issued before guest OS has been booted. > > And any additional at

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Ani Sinha
On Tue, 4 Apr 2023, Gerd Hoffmann wrote: > Hi, > > > > Allowing pending delete expire brings ACPI PCI hotplug on par > > > with native PCIe unplug behavior [1] which in its turn refers > > > back to ACPI PCI hotplug ability to repeat unplug requests. > > > A bit concerned about how this inter

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-04 Thread Gerd Hoffmann
Hi, > > Allowing pending delete expire brings ACPI PCI hotplug on par > > with native PCIe unplug behavior [1] which in its turn refers > > back to ACPI PCI hotplug ability to repeat unplug requests. > A bit concerned about how this interacts with failover, > and 5sec is a lot of time that I ho

Re: [PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-03 Thread Michael S. Tsirkin
On Mon, Apr 03, 2023 at 06:16:18PM +0200, Igor Mammedov wrote: > with Q35 using ACPI PCI hotplug by default, user's request to unplug > device is ignored when it's issued before guest OS has been booted. > And any additional attempt to request device hot-unplug afterwards > results in following err

[PATCH] acpi: pcihp: make pending delete expire in 5sec

2023-04-03 Thread Igor Mammedov
with Q35 using ACPI PCI hotplug by default, user's request to unplug device is ignored when it's issued before guest OS has been booted. And any additional attempt to request device hot-unplug afterwards results in following error: "Device XYZ is already in the process of unplug" arguably it ca