Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Igor Mammedov
On Wed, 6 Apr 2022 18:36:41 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 6 Apr 2022 17:11:09 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > > On Wed, 6 Apr 2022 10:38:51 +0100 > > > >

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 6 Apr 2022 17:11:09 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Wed, 6 Apr 2022 10:38:51 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Igor Mammedov (imamm...@redhat.co

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Igor Mammedov
On Wed, 6 Apr 2022 17:11:09 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 6 Apr 2022 10:38:51 +0100 > > "Dr. David Alan Gilbert" wrote: > > > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > > On Wed, 6 Apr 2022 09:35:31 +0100 > > >

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 6 Apr 2022 10:38:51 +0100 > "Dr. David Alan Gilbert" wrote: > > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Wed, 6 Apr 2022 09:35:31 +0100 > > > "Dr. David Alan Gilbert (git)" wrote: > > > > > > > From: "Dr. David Alan Gilber

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Igor Mammedov
On Wed, 6 Apr 2022 10:38:51 +0100 "Dr. David Alan Gilbert" wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 6 Apr 2022 09:35:31 +0100 > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > The 'acpi_index' field is a statically confi

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Michael S. Tsirkin
On Wed, Apr 06, 2022 at 10:44:18AM +0100, Dr. David Alan Gilbert wrote: > * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > > * Igor Mammedov (imamm...@redhat.com) wrote: > > > On Wed, 6 Apr 2022 09:35:31 +0100 > > > "Dr. David Alan Gilbert (git)" wrote: > > > > > > > From: "Dr. David Alan

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Igor Mammedov (imamm...@redhat.com) wrote: > > On Wed, 6 Apr 2022 09:35:31 +0100 > > "Dr. David Alan Gilbert (git)" wrote: > > > > > From: "Dr. David Alan Gilbert" > > > > > > The 'acpi_index' field is a statically configured field, whi

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert
* Igor Mammedov (imamm...@redhat.com) wrote: > On Wed, 6 Apr 2022 09:35:31 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > The 'acpi_index' field is a statically configured field, which for > > some reason is migrated; this never makes much sense beca

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Igor Mammedov
On Wed, 6 Apr 2022 09:35:31 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The 'acpi_index' field is a statically configured field, which for > some reason is migrated; this never makes much sense because it's > command line static. that's true only for the f

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert
* Alex Williamson (alex.william...@redhat.com) wrote: > On Tue, 5 Apr 2022 20:06:58 +0100 > "Dr. David Alan Gilbert (git)" wrote: > > > From: "Dr. David Alan Gilbert" > > > > The 'acpi_index' field is a statically configured field, which for > > some reason is migrated; this never makes much s

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Apr 05, 2022 at 08:06:58PM +0100, Dr. David Alan Gilbert (git) wrote: > > The patch is fine but pls repost as text not as > application/octet-stream. I've just reposted it with a fudged header that should be fine. ( 20220406083531.10217-1-dg

[PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'acpi_index' field is a statically configured field, which for some reason is migrated; this never makes much sense because it's command line static. However, on piix4 it's conditional, and the condition/test function ends up having the wrong pointer passed to

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: Hmm no, still bad mimetype -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK

[PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert (git)
binS1iWwfufXq.bin Description: Binary data

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-06 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Tue, Apr 05, 2022 at 08:06:58PM +0100, Dr. David Alan Gilbert (git) wrote: > > The patch is fine but pls repost as text not as > application/octet-stream. Let me try and figure out how; this is the same git send-email I've used for years; it's ou

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-05 Thread Marc-André Lureau
Good work! :) Reviewed-by: Marc-André Lureau On Tue, Apr 5, 2022 at 11:07 PM Dr. David Alan Gilbert (git) < dgilb...@redhat.com> wrote: > -- Marc-André Lureau

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-05 Thread Fabian Ebner
Am 05.04.22 um 21:06 schrieb Dr. David Alan Gilbert (git): > From: "Dr. David Alan Gilbert" > > The 'acpi_index' field is a statically configured field, which for > some reason is migrated; this never makes much sense because it's > command line static. > > However, on piix4 it's conditional, an

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-05 Thread Michael S. Tsirkin
On Tue, Apr 05, 2022 at 08:06:58PM +0100, Dr. David Alan Gilbert (git) wrote: The patch is fine but pls repost as text not as application/octet-stream. Thanks! -- MST

Re: [PATCH] acpi: Bodge acpi_index migration

2022-04-05 Thread Alex Williamson
On Tue, 5 Apr 2022 20:06:58 +0100 "Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > The 'acpi_index' field is a statically configured field, which for > some reason is migrated; this never makes much sense because it's > command line static. > > However, on piix4 it's

[PATCH] acpi: Bodge acpi_index migration

2022-04-05 Thread Dr. David Alan Gilbert (git)
binkkNQxjetjk.bin Description: Binary data