Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-22 Thread Ani Sinha
> On 21-May-2023, at 8:21 PM, Ani Sinha wrote: > > > >> On 21-May-2023, at 2:24 PM, Michael S. Tsirkin wrote: >> >> On Wed, May 17, 2023 at 05:37:51PM +0530, Ani Sinha wrote: >>> Currently the meson based QEMU build process locates the iasl binary from >>> the >>> current PATH and other l

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-22 Thread Paolo Bonzini
Il sab 20 mag 2023, 17:13 Ani Sinha ha scritto: > > On 20-May-2023, at 3:06 PM, Paolo Bonzini wrote: > > > > > > > > Il sab 20 mag 2023, 09:25 Ani Sinha ha scritto: > > 40c909f534e3f3cd2 from what I can see. It requires a full QEMU build in > order to turn on CONFIG_IASL in bios-tables-test. At

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-21 Thread Ani Sinha
> On 21-May-2023, at 2:24 PM, Michael S. Tsirkin wrote: > > On Wed, May 17, 2023 at 05:37:51PM +0530, Ani Sinha wrote: >> Currently the meson based QEMU build process locates the iasl binary from the >> current PATH and other locations [1] and uses that to set CONFIG_IASL which >> is >> then

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-21 Thread Michael S. Tsirkin
On Wed, May 17, 2023 at 05:37:51PM +0530, Ani Sinha wrote: > Currently the meson based QEMU build process locates the iasl binary from the > current PATH and other locations [1] and uses that to set CONFIG_IASL which is > then used by the test. > > This has two disadvantages: > - If iasl was not

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-20 Thread Ani Sinha
> On 20-May-2023, at 3:06 PM, Paolo Bonzini wrote: > > > > Il sab 20 mag 2023, 09:25 Ani Sinha ha scritto: > 40c909f534e3f3cd2 from what I can see. It requires a full QEMU build in order > to turn on CONFIG_IASL in bios-tables-test. At some point in the past, we > could just install iasl

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-20 Thread Paolo Bonzini
Il sab 20 mag 2023, 09:25 Ani Sinha ha scritto: > 40c909f534e3f3cd2 from what I can see. It requires a full QEMU build in > order to turn on CONFIG_IASL in bios-tables-test. At some point in the > past, we could just install iasl and rerun the test and it would discover > iasl in the path if CONF

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-20 Thread Ani Sinha
> On 19-May-2023, at 10:43 PM, Paolo Bonzini wrote: > > On Thu, May 18, 2023 at 1:02 PM Ani Sinha wrote: >>> Can we split this variable out to config-test.h maybe? >>> Then you can reconfigure with a different iasl and QEMU >>> will not be rebuilt, just the tests. >> >> TBH, it looks more an

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-19 Thread Paolo Bonzini
On Thu, May 18, 2023 at 1:02 PM Ani Sinha wrote: > > Can we split this variable out to config-test.h maybe? > > Then you can reconfigure with a different iasl and QEMU > > will not be rebuilt, just the tests. > > TBH, it looks more and more like our previous approach was simple and > better before

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-18 Thread Ani Sinha
> On 18-May-2023, at 4:10 PM, Michael S. Tsirkin wrote: > > he annoying thing with both these approaches is they work > less well than current code since iasl won't be invoked > at all if you do not remember the magic variable to set > or flag to pass. ATM it is self-contained. We could addre

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-18 Thread Ani Sinha
On Thu, 18 May 2023, Michael S. Tsirkin wrote: > On Thu, May 18, 2023 at 11:31:47AM +0530, Ani Sinha wrote: > > > > > > > On 17-May-2023, at 9:50 PM, Alex Bennée wrote: > > > > > > ./tests/bios-tables-test --iasl-path ${CONFIG_IASL} > > > > > > and then you have the best of both worlds. You can

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-18 Thread Michael S. Tsirkin
On Thu, May 18, 2023 at 11:31:47AM +0530, Ani Sinha wrote: > > > > On 17-May-2023, at 9:50 PM, Alex Bennée wrote: > > > > ./tests/bios-tables-test --iasl-path ${CONFIG_IASL} > > > > and then you have the best of both worlds. You can run manually with a > > different path and you don't need to

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-18 Thread Michael S. Tsirkin
On Wed, May 17, 2023 at 04:43:53PM +, Bernhard Beschow wrote: > > > Am 17. Mai 2023 12:07:51 UTC schrieb Ani Sinha : > >Currently the meson based QEMU build process locates the iasl binary from the > >current PATH and other locations [1] and uses that to set CONFIG_IASL which > >is > >then u

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Ani Sinha
> On 17-May-2023, at 9:50 PM, Alex Bennée wrote: > > is there any easy way to add arguments to individual tests I looked at this before for bios bits work and seems it is not straightforward to add test specific command line options in our meson build system. It needs some work. I am also c

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Ani Sinha
> On 17-May-2023, at 9:50 PM, Alex Bennée wrote: > > ./tests/bios-tables-test --iasl-path ${CONFIG_IASL} > > and then you have the best of both worlds. You can run manually with a > different path and you don't need to pollute config-host.h It could also be an environment variable set by mes

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Ani Sinha
> On 17-May-2023, at 10:13 PM, Bernhard Beschow wrote: > > > > Am 17. Mai 2023 12:07:51 UTC schrieb Ani Sinha : >> Currently the meson based QEMU build process locates the iasl binary from the >> current PATH and other locations [1] and uses that to set CONFIG_IASL which >> is >> then used

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Bernhard Beschow
Am 17. Mai 2023 12:07:51 UTC schrieb Ani Sinha : >Currently the meson based QEMU build process locates the iasl binary from the >current PATH and other locations [1] and uses that to set CONFIG_IASL which is >then used by the test. > >This has two disadvantages: > - If iasl was not previously in

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Wed, May 17, 2023 at 04:58:06PM +0100, Alex Bennée wrote: >> >> "Michael S. Tsirkin" writes: >> >> > On Wed, May 17, 2023 at 04:16:47PM +0100, Alex Bennée wrote: >> >> >> >> Ani Sinha writes: >> >> >> >> >> On 17-May-2023, at 8:06 PM, Michael S. Tsirkin

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Alex Bennée
Ani Sinha writes: >> On 17-May-2023, at 8:46 PM, Alex Bennée wrote: >> >> >> Ani Sinha writes: >> On 17-May-2023, at 8:06 PM, Michael S. Tsirkin wrote: On Wed, May 17, 2023 at 07:57:53PM +0530, Ani Sinha wrote: > > >> On 17-May-2023, at 7:47 PM, Michael S. Ts

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Michael S. Tsirkin
On Wed, May 17, 2023 at 04:58:06PM +0100, Alex Bennée wrote: > > "Michael S. Tsirkin" writes: > > > On Wed, May 17, 2023 at 04:16:47PM +0100, Alex Bennée wrote: > >> > >> Ani Sinha writes: > >> > >> >> On 17-May-2023, at 8:06 PM, Michael S. Tsirkin wrote: > >> >> > >> >> On Wed, May 17, 202

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Alex Bennée
"Michael S. Tsirkin" writes: > On Wed, May 17, 2023 at 04:16:47PM +0100, Alex Bennée wrote: >> >> Ani Sinha writes: >> >> >> On 17-May-2023, at 8:06 PM, Michael S. Tsirkin wrote: >> >> >> >> On Wed, May 17, 2023 at 07:57:53PM +0530, Ani Sinha wrote: >> >>> >> >>> >> On 17-May-2023,

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Ani Sinha
> On 17-May-2023, at 8:46 PM, Alex Bennée wrote: > > > Ani Sinha writes: > >>> On 17-May-2023, at 8:06 PM, Michael S. Tsirkin wrote: >>> >>> On Wed, May 17, 2023 at 07:57:53PM +0530, Ani Sinha wrote: > On 17-May-2023, at 7:47 PM, Michael S. Tsirkin wrote: > > On

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Michael S. Tsirkin
On Wed, May 17, 2023 at 04:16:47PM +0100, Alex Bennée wrote: > > Ani Sinha writes: > > >> On 17-May-2023, at 8:06 PM, Michael S. Tsirkin wrote: > >> > >> On Wed, May 17, 2023 at 07:57:53PM +0530, Ani Sinha wrote: > >>> > >>> > On 17-May-2023, at 7:47 PM, Michael S. Tsirkin wrote: > >>>

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Alex Bennée
Ani Sinha writes: >> On 17-May-2023, at 8:06 PM, Michael S. Tsirkin wrote: >> >> On Wed, May 17, 2023 at 07:57:53PM +0530, Ani Sinha wrote: >>> >>> On 17-May-2023, at 7:47 PM, Michael S. Tsirkin wrote: On Wed, May 17, 2023 at 05:37:51PM +0530, Ani Sinha wrote: > Current

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Ani Sinha
> On 17-May-2023, at 8:06 PM, Michael S. Tsirkin wrote: > > On Wed, May 17, 2023 at 07:57:53PM +0530, Ani Sinha wrote: >> >> >>> On 17-May-2023, at 7:47 PM, Michael S. Tsirkin wrote: >>> >>> On Wed, May 17, 2023 at 05:37:51PM +0530, Ani Sinha wrote: Currently the meson based QEMU buil

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Michael S. Tsirkin
On Wed, May 17, 2023 at 07:57:53PM +0530, Ani Sinha wrote: > > > > On 17-May-2023, at 7:47 PM, Michael S. Tsirkin wrote: > > > > On Wed, May 17, 2023 at 05:37:51PM +0530, Ani Sinha wrote: > >> Currently the meson based QEMU build process locates the iasl binary from > >> the > >> current PATH

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Ani Sinha
> On 17-May-2023, at 7:47 PM, Michael S. Tsirkin wrote: > > On Wed, May 17, 2023 at 05:37:51PM +0530, Ani Sinha wrote: >> Currently the meson based QEMU build process locates the iasl binary from the >> current PATH and other locations [1] and uses that to set CONFIG_IASL which >> is >> then

Re: [PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Michael S. Tsirkin
On Wed, May 17, 2023 at 05:37:51PM +0530, Ani Sinha wrote: > Currently the meson based QEMU build process locates the iasl binary from the > current PATH and other locations [1] and uses that to set CONFIG_IASL which is > then used by the test. > > This has two disadvantages: > - If iasl was not

[PATCH] acpi/tests/bios-tables-test: add an environment variable for iasl location

2023-05-17 Thread Ani Sinha
Currently the meson based QEMU build process locates the iasl binary from the current PATH and other locations [1] and uses that to set CONFIG_IASL which is then used by the test. This has two disadvantages: - If iasl was not previously installed in the PATH, one has to install iasl and rebuil