Re: [PATCH] acpi/erst: fix fallthrough code upon validation failure

2022-06-10 Thread Michael S. Tsirkin
On Fri, Jun 10, 2022 at 01:48:57PM +0530, Ani Sinha wrote: > On Thu, May 19, 2022 at 6:35 PM Eric DeVolder > wrote: > > > > > > > > On 5/13/22 09:10, Ani Sinha wrote: > > > At any step when any validation fail in check_erst_backend_storage(), > > > there is > > > no need to continue further thro

Re: [PATCH] acpi/erst: fix fallthrough code upon validation failure

2022-06-10 Thread Ani Sinha
On Thu, May 19, 2022 at 6:35 PM Eric DeVolder wrote: > > > > On 5/13/22 09:10, Ani Sinha wrote: > > At any step when any validation fail in check_erst_backend_storage(), there > > is > > no need to continue further through other validation checks. Further, by > > continuing even when record_size

Re: [PATCH] acpi/erst: fix fallthrough code upon validation failure

2022-05-19 Thread Eric DeVolder
On 5/13/22 09:10, Ani Sinha wrote: At any step when any validation fail in check_erst_backend_storage(), there is no need to continue further through other validation checks. Further, by continuing even when record_size is 0, we run the risk of triggering a divide by zero error if we continued

Re: [PATCH] acpi/erst: fix fallthrough code upon validation failure

2022-05-19 Thread Igor Mammedov
On Fri, 13 May 2022 19:40:05 +0530 Ani Sinha wrote: > At any step when any validation fail in check_erst_backend_storage(), there is > no need to continue further through other validation checks. Further, by > continuing even when record_size is 0, we run the risk of triggering a divide > by zero

[PATCH] acpi/erst: fix fallthrough code upon validation failure

2022-05-13 Thread Ani Sinha
At any step when any validation fail in check_erst_backend_storage(), there is no need to continue further through other validation checks. Further, by continuing even when record_size is 0, we run the risk of triggering a divide by zero error if we continued with other validation checks. Hence, we