Re: [PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2024-01-17 Thread Philippe Mathieu-Daudé
On 29/11/23 21:50, Philippe Mathieu-Daudé wrote: 'can_do_io' is specific to TCG. Having it set in non-TCG code is confusing, so remove it from QTest / HVF / KVM. Signed-off-by: Philippe Mathieu-Daudé --- accel/dummy-cpus.c| 1 - accel/hvf/hvf-accel-ops.c | 1 - accel/kvm/kvm-accel-o

Re: [PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2024-01-16 Thread Philippe Mathieu-Daudé
On 30/11/23 14:51, Richard Henderson wrote: On 11/29/23 14:50, Philippe Mathieu-Daudé wrote: 'can_do_io' is specific to TCG. Having it set in non-TCG code is confusing, so remove it from QTest / HVF / KVM. Signed-off-by: Philippe Mathieu-Daudé ---   accel/dummy-cpus.c    | 1 -   accel/hvf/

Re: [PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2023-11-30 Thread Richard Henderson
On 11/29/23 14:50, Philippe Mathieu-Daudé wrote: 'can_do_io' is specific to TCG. Having it set in non-TCG code is confusing, so remove it from QTest / HVF / KVM. Signed-off-by: Philippe Mathieu-Daudé --- accel/dummy-cpus.c| 1 - accel/hvf/hvf-accel-ops.c | 1 - accel/kvm/kvm-accel-o

Re: [PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2023-11-30 Thread Claudio Fontana
On 11/30/23 14:31, Philippe Mathieu-Daudé wrote: > Hi Claudio, > > On 30/11/23 13:48, Claudio Fontana wrote: >> Hi Philippe, >> >> took a quick look with >> >> grep -R can_do_io >> >> and this seems to be in include/hw/core/cpu.h as well as cpu-common.c, >> >> maybe there is more meat to address t

Re: [PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2023-11-30 Thread Philippe Mathieu-Daudé
Hi Claudio, On 30/11/23 13:48, Claudio Fontana wrote: Hi Philippe, took a quick look with grep -R can_do_io and this seems to be in include/hw/core/cpu.h as well as cpu-common.c, maybe there is more meat to address to fully solve this? Before we had stuff for reset in cpu-common.c under a i

Re: [PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2023-11-30 Thread Claudio Fontana
Hi Philippe, took a quick look with grep -R can_do_io and this seems to be in include/hw/core/cpu.h as well as cpu-common.c, maybe there is more meat to address to fully solve this? Before we had stuff for reset in cpu-common.c under a if (tcg_enabled()) { } but now we have cpu_exec_reset_ho

[PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2023-11-29 Thread Philippe Mathieu-Daudé
'can_do_io' is specific to TCG. Having it set in non-TCG code is confusing, so remove it from QTest / HVF / KVM. Signed-off-by: Philippe Mathieu-Daudé --- accel/dummy-cpus.c| 1 - accel/hvf/hvf-accel-ops.c | 1 - accel/kvm/kvm-accel-ops.c | 1 - 3 files changed, 3 deletions(-) diff --gi