Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

Shivam Kumar writes: > On 9 Oct 2024, at 12:10 AM, Fabiano Rosas wrote: > > !---| > CAUTION: External Email > > |---! > > Peter Xu mailto:pet...@redhat.com>> writes: >

Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

On 9 Oct 2024, at 12:10 AM, Fabiano Rosas wrote: !---| CAUTION: External Email |---! Peter Xu mailto:pet...@redhat.com>> writes: On Tue, Oct 08, 2024 at 11:20:03AM

Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

Peter Xu writes: > On Tue, Oct 08, 2024 at 11:20:03AM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Mon, Oct 07, 2024 at 03:44:51PM +, Shivam Kumar wrote: >> >> If the client calls the QMP command to reset the migration >> >> capabilities after the migration status is set to fa

Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

On Tue, Oct 08, 2024 at 11:20:03AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Oct 07, 2024 at 03:44:51PM +, Shivam Kumar wrote: > >> If the client calls the QMP command to reset the migration > >> capabilities after the migration status is set to failed or cancelled > > > >

Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

Peter Xu writes: > On Mon, Oct 07, 2024 at 03:44:51PM +, Shivam Kumar wrote: >> If the client calls the QMP command to reset the migration >> capabilities after the migration status is set to failed or cancelled > > Is cancelled ok? > > Asked because I think migrate_fd_cleanup() should still

Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

On Tue, Oct 08, 2024 at 12:09:03PM +, Shivam Kumar wrote: > > > On 7 Oct 2024, at 9:56 PM, Peter Xu wrote: > > !---| > CAUTION: External Email > > |---! > > On

Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

On 7 Oct 2024, at 9:56 PM, Peter Xu wrote: !---| CAUTION: External Email |---! On Mon, Oct 07, 2024 at 03:44:51PM +, Shivam Kumar wrote: If the client calls the

Re: [PATCH] Use multifd state to determine if multifd cleanup is needed

On Mon, Oct 07, 2024 at 03:44:51PM +, Shivam Kumar wrote: > If the client calls the QMP command to reset the migration > capabilities after the migration status is set to failed or cancelled Is cancelled ok? Asked because I think migrate_fd_cleanup() should still be in CANCELLING stage there,

[PATCH] Use multifd state to determine if multifd cleanup is needed

If the client calls the QMP command to reset the migration capabilities after the migration status is set to failed or cancelled but before multifd cleanup starts, multifd cleanup can be skipped as it will falsely assume that multifd was not used for migration. This will eventually lead to source Q