Re: [PATCH] Revert "qapi: fix examples of blockdev-add with qcow2"

Am 30.09.2022 um 19:19 hat Markus Armbruster geschrieben: > This reverts commit b6522938327141235b97ab38e40c6c4512587373. > > Kevin Wolf NAKed this patch, because: > > 'file' is a required member (defined in BlockdevOptionsGenericFormat), > removing it makes the example invalid. 'data-fil

Re: [PATCH] Revert "qapi: fix examples of blockdev-add with qcow2"

Hi, On Tue, Oct 04, 2022 at 10:13:17AM +0200, Victor Toso wrote: > Hi, > > Sorry taking some time to reply. > > On Fri, Sep 30, 2022 at 07:19:08PM +0200, Markus Armbruster wrote: > > This reverts commit b6522938327141235b97ab38e40c6c4512587373. > > Which is: > ``` > qapi: fix examples of bloc

Re: [PATCH] Revert "qapi: fix examples of blockdev-add with qcow2"

Hi, Sorry taking some time to reply. On Fri, Sep 30, 2022 at 07:19:08PM +0200, Markus Armbruster wrote: > This reverts commit b6522938327141235b97ab38e40c6c4512587373. Which is: ``` qapi: fix examples of blockdev-add with qcow2 The examples use "qcow2" driver with the wrong member name for

[PATCH] Revert "qapi: fix examples of blockdev-add with qcow2"

This reverts commit b6522938327141235b97ab38e40c6c4512587373. Kevin Wolf NAKed this patch, because: 'file' is a required member (defined in BlockdevOptionsGenericFormat), removing it makes the example invalid. 'data-file' is only an additional optional member to be used for external d