Re: [PATCH] Memory: Only call ramblock_ptr when needed in qemu_ram_writeback

2020-02-25 Thread Paolo Bonzini
On 25/02/20 17:02, Anthony PERARD wrote: > On Thu, Dec 19, 2019 at 07:10:24PM +0100, Juan Quintela wrote: >> Anthony PERARD wrote: >>> It is possible that a ramblock doesn't have memory that QEMU can >>> access, this is the case with the Xen hypervisor. >>> >>> In order to avoid to trigger an asse

Re: [PATCH] Memory: Only call ramblock_ptr when needed in qemu_ram_writeback

2020-02-25 Thread Anthony PERARD
On Thu, Dec 19, 2019 at 07:10:24PM +0100, Juan Quintela wrote: > Anthony PERARD wrote: > > It is possible that a ramblock doesn't have memory that QEMU can > > access, this is the case with the Xen hypervisor. > > > > In order to avoid to trigger an assert, only call ramblock_ptr() when > > needed

Re: [PATCH] Memory: Only call ramblock_ptr when needed in qemu_ram_writeback

2019-12-19 Thread Juan Quintela
Anthony PERARD wrote: > It is possible that a ramblock doesn't have memory that QEMU can > access, this is the case with the Xen hypervisor. > > In order to avoid to trigger an assert, only call ramblock_ptr() when > needed in qemu_ram_writeback(). This should fix migration of Xen > guests that wa

Re: [PATCH] Memory: Only call ramblock_ptr when needed in qemu_ram_writeback

2019-12-19 Thread Beata Michalska
Hi Anthony, On Thu, 19 Dec 2019 at 15:43, Anthony PERARD wrote: > > It is possible that a ramblock doesn't have memory that QEMU can > access, this is the case with the Xen hypervisor. > > In order to avoid to trigger an assert, only call ramblock_ptr() when > needed in qemu_ram_writeback(). This

[PATCH] Memory: Only call ramblock_ptr when needed in qemu_ram_writeback

2019-12-19 Thread Anthony PERARD
It is possible that a ramblock doesn't have memory that QEMU can access, this is the case with the Xen hypervisor. In order to avoid to trigger an assert, only call ramblock_ptr() when needed in qemu_ram_writeback(). This should fix migration of Xen guests that was broken with bd108a44bc29 ("migra