Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-29 Thread Michael Tokarev
30.01.2024 04:35, Peter Xu: .. This seems like a stable material too, - please let me know if it is not. Yes it is. I used to be more careful on copying stable at least in the commit message when I post patches, but forgot to do so when start picking up.. Note that it's already merged in maste

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-29 Thread Peter Xu
On Mon, Jan 29, 2024 at 11:30:53PM +0300, Michael Tokarev wrote: > 23.01.2024 09:42, Het Gala: > > 'uri' argument should be optional, as 'uri' and 'channels' > > arguments are mutally exclusive in nature. > > > > Fixes: 074dbce5fcce (migration: New migrate and > > migrate-incoming argument 'channe

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-29 Thread Fabiano Rosas
Michael Tokarev writes: > 23.01.2024 09:42, Het Gala: >> 'uri' argument should be optional, as 'uri' and 'channels' >> arguments are mutally exclusive in nature. >> >> Fixes: 074dbce5fcce (migration: New migrate and >> migrate-incoming argument 'channels') >> Signed-off-by: Het Gala >> --- >>

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-29 Thread Michael Tokarev
23.01.2024 09:42, Het Gala: 'uri' argument should be optional, as 'uri' and 'channels' arguments are mutally exclusive in nature. Fixes: 074dbce5fcce (migration: New migrate and migrate-incoming argument 'channels') Signed-off-by: Het Gala --- qapi/migration.json | 2 +- 1 file changed, 1 in

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-26 Thread Daniel P . Berrangé
On Fri, Jan 26, 2024 at 07:40:12PM +0530, Het Gala wrote: > Hi everyone, I was trying to wrap around on how to write a migration test or > to mock migration. > I see there are a couple of migration tests already written, but most of them > focuses on just getting the uri and parsing uri to start

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-26 Thread Het Gala
On 24/01/24 10:03 am, Het Gala wrote: On 24/01/24 7:13 am, Peter Xu wrote: On Tue, Jan 23, 2024 at 08:21:55AM +, Daniel P. Berrangé wrote: On Tue, Jan 23, 2024 at 06:42:19AM +, Het Gala wrote: 'uri' argument should be optional, as 'uri' and 'channels' arguments are mutally exclusive

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-23 Thread Het Gala
On 24/01/24 7:13 am, Peter Xu wrote: On Tue, Jan 23, 2024 at 08:21:55AM +, Daniel P. Berrangé wrote: On Tue, Jan 23, 2024 at 06:42:19AM +, Het Gala wrote: 'uri' argument should be optional, as 'uri' and 'channels' arguments are mutally exclusive in nature. Fixes: 074dbce5fcce (migrati

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-23 Thread Peter Xu
On Tue, Jan 23, 2024 at 08:21:55AM +, Daniel P. Berrangé wrote: > On Tue, Jan 23, 2024 at 06:42:19AM +, Het Gala wrote: > > 'uri' argument should be optional, as 'uri' and 'channels' > > arguments are mutally exclusive in nature. > > > > Fixes: 074dbce5fcce (migration: New migrate and > >

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-23 Thread Daniel P . Berrangé
On Tue, Jan 23, 2024 at 06:42:19AM +, Het Gala wrote: > 'uri' argument should be optional, as 'uri' and 'channels' > arguments are mutally exclusive in nature. > > Fixes: 074dbce5fcce (migration: New migrate and > migrate-incoming argument 'channels') > Signed-off-by: Het Gala > --- > qapi/m

Re: [PATCH] Make 'uri' optional for migrate QAPI

2024-01-22 Thread Het Gala
On 23/01/24 12:12 pm, Het Gala wrote: 'uri' argument should be optional, as 'uri' and 'channels' arguments are mutally exclusive in nature. Also verified by running the qemu CI/CD pipeline. ref: https://gitlab.com/galahet/Qemu/-/pipelines/1147048455 Fixes: 074dbce5fcce (migration: New migr

[PATCH] Make 'uri' optional for migrate QAPI

2024-01-22 Thread Het Gala
'uri' argument should be optional, as 'uri' and 'channels' arguments are mutally exclusive in nature. Fixes: 074dbce5fcce (migration: New migrate and migrate-incoming argument 'channels') Signed-off-by: Het Gala --- qapi/migration.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff