Re: [PATCH] LOCK GUARDS: replace manual lock()/unlock() calls to QEMU_LOCK_GUARD()

2022-11-08 Thread Alex Bennée
nyoro.ga...@gmail.com writes: > From: Samker > > This is patch replaces WITH_QEMU_LOCK_GUARD() call with the > QEMU_LOCK_GUARD() You could extend this description as to why ".. because it extends the scope of the lock to the whole function rather than the non-existent block". Otherwise: Revi

Re: [PATCH] LOCK GUARDS: replace manual lock()/unlock() calls to QEMU_LOCK_GUARD()

2022-11-08 Thread Martin Gachu
Hi Philippe, > This patch doesn't apply... > $ git grep QEMU_LOCK_GUARD origin/master -- softmmu/physmem.c > $ > On what is it based? I initially replaced lock()/unlock() calls in the softmmu/physmem.c with the more preferred WITH_QEMU_LOCK_GUARD() call. However Stefan pointed out that inste

Re: [PATCH] LOCK GUARDS: replace manual lock()/unlock() calls to QEMU_LOCK_GUARD()

2022-11-08 Thread Philippe Mathieu-Daudé
Hi, On 8/11/22 06:11, nyoro.ga...@gmail.com wrote: From: Samker This is patch replaces WITH_QEMU_LOCK_GUARD() call with the QEMU_LOCK_GUARD() Signed-off-by: Samker --- softmmu/physmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/softmmu/physmem.c b/softmmu/phy

[PATCH] LOCK GUARDS: replace manual lock()/unlock() calls to QEMU_LOCK_GUARD()

2022-11-07 Thread nyoro . gachu
From: Samker This is patch replaces WITH_QEMU_LOCK_GUARD() call with the QEMU_LOCK_GUARD() Signed-off-by: Samker --- softmmu/physmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/softmmu/physmem.c b/softmmu/physmem.c index fb00596777..907491ae17 100644 --- a/softmmu