Re: [PATCH] Fix assertion failure in lsi53c810 emulator

2021-06-13 Thread Qiang Liu
Hi Phil, > You didn't Cc'ed the maintainers of the SCSI subsystem (see > https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer > ) so I'm doing it for you: Thank you! > It seems you didn't send your patch with the proper tool, see > https://wiki.qemu.org/Contribute/SubmitAPatch

Re: [PATCH] Fix assertion failure in lsi53c810 emulator

2021-06-12 Thread Philippe Mathieu-Daudé
Hi, On 6/12/21 8:24 AM, Liu Cyrus wrote: > Hi folks, this is a suggestion for fixing this bug. > I'm willing to discuss this with you because I'm new to contribute to QEMU. Thanks for your fix! You didn't Cc'ed the maintainers of the SCSI subsystem (see https://wiki.qemu.org/Contribute/SubmitAPa

[PATCH] Fix assertion failure in lsi53c810 emulator

2021-06-11 Thread Liu Cyrus
From: cyruscyliu An assertion failure can be triggered in the lsi53c810 emulator by a guest when ((s->sstat1 & 0x7) == PHASE_DO) || (s->sstat1 & 0x7) == PHASE_DI)) && (!s->current) holds. Check s->sstat1 and s->current in lsi_reg_writeb before lsi_execute_script() to discard this MMIO write. Fix