Re: [PATCH] COLO: Move some trace code behind qemu_mutex_unlock_iothread()

2021-12-13 Thread Rao, Lei
On 12/13/2021 7:45 PM, Dr. David Alan Gilbert wrote: * Rao, Lei (lei@intel.com) wrote: Signed-off-by: Lei Rao You don't say why you want to move it - it's just a trace, what's the advantage? I think it's not necessary to put trace code in the critical section. So, moving it behind qe

Re: [PATCH] COLO: Move some trace code behind qemu_mutex_unlock_iothread()

2021-12-13 Thread Dr. David Alan Gilbert
* Rao, Lei (lei@intel.com) wrote: > Signed-off-by: Lei Rao You don't say why you want to move it - it's just a trace, what's the advantage? Dave > --- > migration/colo.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/migration/colo.c b/migration/colo.c > in

[PATCH] COLO: Move some trace code behind qemu_mutex_unlock_iothread()

2021-12-09 Thread Rao, Lei
Signed-off-by: Lei Rao --- migration/colo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/colo.c b/migration/colo.c index 2415325262..3ccacb29c8 100644 --- a/migration/colo.c +++ b/migration/colo.c @@ -683,8 +683,8 @@ static void colo_incoming_process_checkp