Re: [PATCH] 9pfs: fix dead code in qemu_open_flags_tostr()

2025-02-11 Thread Christian Schoenebeck
On Tuesday, February 11, 2025 3:47:33 PM CET Peter Maydell wrote: > On Mon, 10 Feb 2025 at 14:40, Christian Schoenebeck > wrote: > > > > Coverity scan complained about expression "|LARGEFILE" to be non reachable > > and the detailed Coverity report claims O_LARGEFILE was zero. I can't > > reproduc

Re: [PATCH] 9pfs: fix dead code in qemu_open_flags_tostr()

2025-02-11 Thread Peter Maydell
On Mon, 10 Feb 2025 at 14:40, Christian Schoenebeck wrote: > > Coverity scan complained about expression "|LARGEFILE" to be non reachable > and the detailed Coverity report claims O_LARGEFILE was zero. I can't > reproduce this here, but I assume that means there are at least some > system(s) which

Re: [PATCH] 9pfs: fix dead code in qemu_open_flags_tostr()

2025-02-11 Thread Christian Schoenebeck
On Monday, February 10, 2025 4:32:08 PM CET Philippe Mathieu-Daudé wrote: > On 10/2/25 15:33, Christian Schoenebeck wrote: > > Coverity scan complained about expression "|LARGEFILE" to be non reachable > > and the detailed Coverity report claims O_LARGEFILE was zero. I can't > > reproduce this here

Re: [PATCH] 9pfs: fix dead code in qemu_open_flags_tostr()

2025-02-10 Thread Philippe Mathieu-Daudé
On 10/2/25 15:33, Christian Schoenebeck wrote: Coverity scan complained about expression "|LARGEFILE" to be non reachable and the detailed Coverity report claims O_LARGEFILE was zero. I can't reproduce this here, but I assume that means there are at least some system(s) which define O_LARGEFILE a

[PATCH] 9pfs: fix dead code in qemu_open_flags_tostr()

2025-02-10 Thread Christian Schoenebeck
Coverity scan complained about expression "|LARGEFILE" to be non reachable and the detailed Coverity report claims O_LARGEFILE was zero. I can't reproduce this here, but I assume that means there are at least some system(s) which define O_LARGEFILE as zero. This is not really an issue, but to sile