Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-31 Thread Will Cohen
On Thu, Mar 31, 2022 at 11:34 AM Christian Schoenebeck < qemu_...@crudebyte.com> wrote: > On Donnerstag, 31. März 2022 15:19:24 CEST Will Cohen wrote: > > On Thu, Mar 31, 2022 at 7:07 AM Christian Schoenebeck < > > > > qemu_...@crudebyte.com> wrote: > > > On Donnerstag, 31. März 2022 10:03:35 CEST

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-31 Thread Christian Schoenebeck
On Donnerstag, 31. März 2022 15:19:24 CEST Will Cohen wrote: > On Thu, Mar 31, 2022 at 7:07 AM Christian Schoenebeck < > > qemu_...@crudebyte.com> wrote: > > On Donnerstag, 31. März 2022 10:03:35 CEST Peter Maydell wrote: > > > On Wed, 30 Mar 2022 at 22:55, Will Cohen wrote: > > > > On Wed, Mar 3

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-31 Thread Will Cohen
On Thu, Mar 31, 2022 at 7:07 AM Christian Schoenebeck < qemu_...@crudebyte.com> wrote: > On Donnerstag, 31. März 2022 10:03:35 CEST Peter Maydell wrote: > > On Wed, 30 Mar 2022 at 22:55, Will Cohen wrote: > > > On Wed, Mar 30, 2022 at 5:31 PM Peter Maydell < > peter.mayd...@linaro.org> > wrote: >

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-31 Thread Christian Schoenebeck
On Donnerstag, 31. März 2022 10:03:35 CEST Peter Maydell wrote: > On Wed, 30 Mar 2022 at 22:55, Will Cohen wrote: > > On Wed, Mar 30, 2022 at 5:31 PM Peter Maydell wrote: > >> Is it possible to do this with a meson.build check for whatever > >> host property we're relying on here rather than wit

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-31 Thread Christian Schoenebeck
On Mittwoch, 30. März 2022 23:17:02 CEST Will Cohen wrote: > On Wed, Mar 30, 2022 at 4:24 PM Philippe Mathieu-Daudé < > > philippe.mathieu.da...@gmail.com> wrote: > > Hi, > > > > On 30/3/22 20:19, Will Cohen wrote: > > > As noted by https://gitlab.com/qemu-project/qemu/-/issues/950, within > > >

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-31 Thread Peter Maydell
On Wed, 30 Mar 2022 at 22:55, Will Cohen wrote: > > On Wed, Mar 30, 2022 at 5:31 PM Peter Maydell > wrote: >> Is it possible to do this with a meson.build check for whatever >> host property we're relying on here rather than with a >> "which OS is this?" ifdef ? > > > To confirm -- the game plan

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-30 Thread Will Cohen
On Wed, Mar 30, 2022 at 5:31 PM Peter Maydell wrote: > On Wed, 30 Mar 2022 at 19:26, Will Cohen wrote: > > > > As noted by https://gitlab.com/qemu-project/qemu/-/issues/950, within > > the patch set adding 9p functionality to darwin, the commit > > 38d7fd68b0c8775b5253ab84367419621aa032e6 introd

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-30 Thread Peter Maydell
On Wed, 30 Mar 2022 at 19:26, Will Cohen wrote: > > As noted by https://gitlab.com/qemu-project/qemu/-/issues/950, within > the patch set adding 9p functionality to darwin, the commit > 38d7fd68b0c8775b5253ab84367419621aa032e6 introduced an issue where > limits.h, which defines XATTR_SIZE_MAX, is

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-30 Thread Will Cohen
On Wed, Mar 30, 2022 at 4:24 PM Philippe Mathieu-Daudé < philippe.mathieu.da...@gmail.com> wrote: > Hi, > > On 30/3/22 20:19, Will Cohen wrote: > > As noted by https://gitlab.com/qemu-project/qemu/-/issues/950, within > > the patch set adding 9p functionality to darwin, the commit > > 38d7fd68b0c8

Re: [PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-30 Thread Philippe Mathieu-Daudé
Hi, On 30/3/22 20:19, Will Cohen wrote: As noted by https://gitlab.com/qemu-project/qemu/-/issues/950, within the patch set adding 9p functionality to darwin, the commit 38d7fd68b0c8775b5253ab84367419621aa032e6 introduced an issue where limits.h, which defines XATTR_SIZE_MAX, is included in 9p.c

[PATCH] 9p: move limits.h include from 9p.c to 9p.h

2022-03-30 Thread Will Cohen
As noted by https://gitlab.com/qemu-project/qemu/-/issues/950, within the patch set adding 9p functionality to darwin, the commit 38d7fd68b0c8775b5253ab84367419621aa032e6 introduced an issue where limits.h, which defines XATTR_SIZE_MAX, is included in 9p.c, though the referenced constant is needed