[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2021-05-09 Thread Philippe Mathieu-Daudé
This is an automated cleanup. This bug report has been moved to QEMU's new bug tracker on gitlab.com and thus gets marked as 'invalid' now. Please continue with the discussion here: https://gitlab.com/qemu-project/qemu/-/issues/241 ** Changed in: qemu Status: Incomplete => Invalid ** Bu

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2021-05-02 Thread Thomas Huth
The QEMU project is currently considering to move its bug tracking to another system. For this we need to know which bugs are still valid and which could be closed already. Thus we are setting older bugs to "Incomplete" now. If you still think this bug report here is valid, then please switch the

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-11-17 Thread Philippe Mathieu-Daudé
** Tags added: linux-user mips -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1858461 Title: Please refactor linux-user/mips/cpu_loop.c Status in QEMU: New Bug description: Hello. I am working

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-15 Thread puchuu
I've created a new patches for getdents bug https://sourceware.org/bugzilla/show_bug.cgi?id=23960 and I can't reproduce python permissions issue anymore. My mips image built with qemu user works perfect. ** Bug watch added: Sourceware.org Bugzilla #23960 https://sourceware.org/bugzilla/show_bug

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread puchuu
Sure, I will try to reproduce permissions issue and create a new issue later. I will try to provide small patches too. I've created a question on kernel bugzilla. https://bugzilla.kernel.org/show_bug.cgi?id=206135 They should know that applications wants much more than "tbl" provides. ** Bug watc

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread Aleksandar Markovic
I have certain concerns over a refactoring that changes the behavior. Refactorings in general should not do it, and if they still do, one should at least have a clear explanation. That is why I want more details on "emerge" problem. -- You received this bug notification because you are a member o

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread Aleksandar Markovic
Also, can you please add more info on "emerge" problem, so that I can repro it with the current QEMU. I would prefer to know the roots cause, rather than just accept that the problem disappeared. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread Aleksandar Markovic
Andrew, Thanks for your input regarding linked patch. The patch is still under review, and it is normal for patches under review to perhaps have some faults, and that is improved in the process of reviewing - that is, among other things, one of benefits of open source development. I will take into

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread puchuu
After applying my patch it seems like another issue was fixed: "emerge" inside qemu has no permissions bug. Without that patch I was able to reproduce "emerge" program can't apply any patch (permission denied). So it looks like old hardcoded table has some wrong values that are not compatible with

Re: [Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread Peter Maydell
On Wed, 8 Jan 2020 at 17:06, puchuu <1858...@bugs.launchpad.net> wrote: > I think about the following development flow: > > 1. Kernel updates and maintains "tbl". > 2. Qemu developer wants to implement new syscall (like clone3) in > "linux-user/syscall.c". > 3. Developer clones new kernel into som

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread puchuu
I've just written these generators in ruby, but it can be rewritten in python, perl, etc. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1858461 Title: Please refactor linux-user/mips/cpu_loop.c St

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread puchuu
** Patch added: "mips_syscall_generators.patch" https://bugs.launchpad.net/qemu/+bug/1858461/+attachment/5318622/+files/mips_syscall_generators.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread puchuu
Hello, thank you. I want to introduce another patch with syscalls related generator. Please review it. I think about the following development flow: 1. Kernel updates and maintains "tbl". 2. Qemu developer wants to implement new syscall (like clone3) in "linux-user/syscall.c". 3. Developer clone

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-08 Thread Aleksandar Markovic
Andrew, Please take a look at the patch: http://patchwork.ozlabs.org/patch/1217454/ Once you apply the patch, it should be straightforward to add getdents64_x32() (right after clone3()) for all MIPS ABIs. The thing is, kernel folks recently made some rearrangements of syscall numbers, so that a

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-07 Thread Aleksandar Markovic
There is already a pending patch for mips that will handle the syscall in question. Will provide drtails tommorow. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1858461 Title: Please refactor linux

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-07 Thread puchuu
It is possible to do the following: cd /usr/src/linux make clean make CC=clang ~/workspace/CastXML/build/bin/castxml -nostdinc -isystem /usr/lib/clang/9.0.1/include -I./arch/x86/include -I./arch/x86/include/generated -I./include -I./arch/x86/include/uapi -I./arch/x86/include/generated/uapi -I.

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-07 Thread puchuu
Unfortunately we can generate only very short table of syscalls using this method. Most of the syscalls are missing from "dwo" files. =( -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1858461 Title:

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-07 Thread puchuu
I've found a reliable way to generate syscall arguments count table. cd /usr/src/linux make clean make CONFIG_DEBUG_INFO=y CONFIG_DEBUG_INFO_SPLIT=y CONFIG_DEBUG_INFO_DWARF4=y llvm-dwarfdump -debug-info --name ksys_getdents64 --show-children --recurse-depth=1 fs/readdir.dwo 0x00013738: DW_TAG_su

Re: [Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-07 Thread Thomas Huth
On 07/01/2020 00.38, puchuu wrote: > ** Patch added: "generated_mips_syscall_table.template.patch" > > https://bugs.launchpad.net/qemu/+bug/1858461/+attachment/5318010/+files/generated_mips_syscall_table.template.patch > Please do not attach patches to the bug tracker, send them to the qemu-d

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-06 Thread puchuu
** Patch added: "generated_mips_syscall_table.template.patch" https://bugs.launchpad.net/qemu/+bug/1858461/+attachment/5318010/+files/generated_mips_syscall_table.template.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. http

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-06 Thread puchuu
Please do not use previous workaround in prod, it is bad, just proof of concept. It looks like nobody is maintaining syscall list. It is not possible to trust it. We have "arch/mips/kernel/syscalls/syscall_o32.tbl", we need to create generator. Generator should provide maximum possible number of

[Bug 1858461] Re: Please refactor linux-user/mips/cpu_loop.c

2020-01-06 Thread puchuu
Added workaround for now ** Patch added: "mips_nr_base patch" https://bugs.launchpad.net/qemu/+bug/1858461/+attachment/5317949/+files/mips_nr_base.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b