Re: [Bug] x86 EFLAGS refresh is not happening correctly

2021-08-05 Thread Stevie Lavern
Thank for your reply! It's still a bit cryptic for me. I think i need to precise that I'm using a x86_64 custom user-mode,base on linux user-mode, that i'm developing (unfortunately i cannot share the code) with modifications in the translation loop (I've added cpu loop exits on specific instructi

Re: [Bug] x86 EFLAGS refresh is not happening correctly

2021-08-05 Thread Paolo Bonzini
On 05/08/21 13:24, Paolo Bonzini wrote: On 05/08/21 11:51, Stevie Lavern wrote: Shouldn't it be: eflags = cpu_cc_compute_all(env, CC_OP) | (env->df & DF_MASK); as eflags is entirely reevaluated by "cpu_cc_compute_all" ? No, both are wrong.  env->eflags contains flags other than the arithmeti

Re: [Bug] x86 EFLAGS refresh is not happening correctly

2021-08-05 Thread Paolo Bonzini
On 05/08/21 11:51, Stevie Lavern wrote: Shouldn't it be: eflags = cpu_cc_compute_all(env, CC_OP) | (env->df & DF_MASK); as eflags is entirely reevaluated by "cpu_cc_compute_all" ? No, both are wrong. env->eflags contains flags other than the arithmetic flags (OF/SF/ZF/AF/PF/CF) and those hav

[Bug] x86 EFLAGS refresh is not happening correctly

2021-08-05 Thread Stevie Lavern
Hello, I'm posting this here instead of opening an issue as it is not clear to me if this is a bug or not. The issue is located in function "cpu_compute_eflags" in target/i386/cpu.h (https://gitlab.com/qemu-project/qemu/-/blob/master/target/i386/cpu.h#L2071) This function is exectued in an out o