Re: [ PATCH v3 02/10] target/riscv: Implement PMU CSR predicate function for

2022-01-05 Thread Atish Patra
On Thu, Nov 4, 2021 at 4:08 AM Bin Meng wrote: > > On Tue, Oct 26, 2021 at 3:56 AM Atish Patra wrote: > > > > The commit title is incomplete > Oops. Fixed it. > > > Currently, the predicate function for PMU related CSRs only works if > > virtualization is enabled. It also does not check mcounte

Re: [ PATCH v3 02/10] target/riscv: Implement PMU CSR predicate function for

2021-11-04 Thread Bin Meng
On Tue, Oct 26, 2021 at 3:56 AM Atish Patra wrote: > The commit title is incomplete > Currently, the predicate function for PMU related CSRs only works if > virtualization is enabled. It also does not check mcounteren bits before > before cycle/minstret/hpmcounterx access. > > Support superviso

Re: [ PATCH v3 02/10] target/riscv: Implement PMU CSR predicate function for

2021-11-02 Thread Alistair Francis
On Tue, Oct 26, 2021 at 5:56 AM Atish Patra wrote: > > Currently, the predicate function for PMU related CSRs only works if > virtualization is enabled. It also does not check mcounteren bits before > before cycle/minstret/hpmcounterx access. > > Support supervisor mode access in the predicate fun

[ PATCH v3 02/10] target/riscv: Implement PMU CSR predicate function for

2021-10-25 Thread Atish Patra
Currently, the predicate function for PMU related CSRs only works if virtualization is enabled. It also does not check mcounteren bits before before cycle/minstret/hpmcounterx access. Support supervisor mode access in the predicate function as well. Signed-off-by: Atish Patra --- target/riscv/c