Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2018-01-04 Thread seeteena
On 01/02/2018 01:54 PM, Markus Armbruster wrote: seeteena writes: On 12/22/2017 01:07 PM, Markus Armbruster wrote: Eric Blake writes: On 12/19/2017 08:20 AM, Max Reitz wrote: So there are three things: (1) We probably should not allow snapshot names that could be IDs. Easiest way to

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2018-01-01 Thread seeteena
On 12/22/2017 01:07 PM, Markus Armbruster wrote: Eric Blake writes: On 12/19/2017 08:20 AM, Max Reitz wrote: So there are three things: (1) We probably should not allow snapshot names that could be IDs. Easiest way to solve this: Names have to start with a non-digit. Yes, that would be a

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-19 Thread seeteena
On 12/19/2017 07:50 PM, Max Reitz wrote: On 2017-12-18 10:24, seeteena wrote: On 12/15/2017 02:48 PM, Max Reitz wrote: On 2017-12-13 05:50, seeteena wrote: Hi David, While creating snapshots when tag name '0' used in the very first and followed by tag name '1' then s

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-18 Thread seeteena
On 12/15/2017 02:48 PM, Max Reitz wrote: On 2017-12-13 05:50, seeteena wrote: Hi David, While creating snapshots when tag name '0' used in the very first and followed by tag name '1' then snapshot created with tag name '0' is getting erased. A snapshot is

Re: [Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-12-12 Thread seeteena
38M 2017-10-16 13:44:35 00:02:07.491 If an ID shown as '1' in the above then user can understand the above documented stuff i.e "If there is already a snapshot with the same tag or ID, it is replaced". The '--' in ID field is annoying. On 12/12/2017 10:11 PM, Dr.

Re: [Qemu-devel] [PATCH v1] spapr.c: Update qemu's maxcpus for pseries machine.

2017-12-03 Thread seeteena
Thanks David for the explanation. I thought the changes been into upstream code for pseries to limit maxcpus to 240 instead of 1024. On 12/01/2017 06:07 PM, David Gibson wrote: On Fri, Dec 01, 2017 at 04:54:09PM +0530, Seeteena Thoufeek wrote: Need to adjust the max cpus supported number

[Qemu-devel] [PATCH v1] spapr.c: Update qemu's maxcpus for pseries machine.

2017-12-01 Thread Seeteena Thoufeek
s since KVM only support 240 so far. Hence,we need to adjust it to an reasonable value 240. Signed-off-by: Seeteena Thoufeek --- hw/ppc/spapr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 9efddea..c753254 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c

[Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-11-21 Thread Seeteena Thoufeek
319M 2017-11-15 15:23:37 00:02:56.328 ID field is showing -- with no information. Signed-off-by: Seeteena Thoufeek --- hmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp.c b/hmp.c index 35a7041..1921b3b 100644 --- a/hmp.c +++ b/hmp.c @@ -1454,7

Re: [Qemu-devel] [Qemu-ppc] [PATCH v1] spapr_pci: fix the path while fetching loc-code from host DT

2017-11-08 Thread seeteena
Apologize for the confusion. I thought devspec is not having leading '/'. I checked devspec in my system and it works as expected. On 11/08/2017 08:00 AM, Alexey Kardashevskiy wrote: On 08/11/17 00:18, Seeteena Thoufeek wrote: The function spapr_phb_vfio_get_loc_code uses wron

[Qemu-devel] [PATCH v1] spapr_pci: fix the path while fetching loc-code from host DT

2017-11-07 Thread Seeteena Thoufeek
The function spapr_phb_vfio_get_loc_code uses wrong path for fetching loc-code from host DT this is the call that needs to be fixed: /* Construct and read from host device tree the loc-code */ path = g_strdup_printf("/proc/device-tree%s/ibm,loc-code", buf); Signed-off-by: Seeteen

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5] vl: exit if maxcpus is negative

2017-10-09 Thread seeteena
Thanks. Eduardo Habkost On 10/06/2017 05:22 PM, Eduardo Habkost wrote: On Fri, Oct 06, 2017 at 03:15:44PM +1100, David Gibson wrote: On Thu, Sep 28, 2017 at 06:38:55PM +0530, seeteena wrote: Thanks Thomas. Since you already put them on cc. I will wait for the response. At this point, I

Re: [Qemu-devel] [Qemu-ppc] [PATCH v5] vl: exit if maxcpus is negative

2017-09-28 Thread seeteena
Thanks Thomas. Since you already put them on cc. I will wait for the response. On 09/25/2017 02:21 PM, Thomas Huth wrote: On 25.09.2017 10:43, seeteena wrote: Hi Philippe, I have not seen patch went upstream.. You need to get the attention of a maintainer who could pick up the patch, e.g

Re: [Qemu-devel] [PATCH v5] vl: exit if maxcpus is negative

2017-09-25 Thread seeteena
Hi Philippe, I have not seen patch went upstream.. On 09/04/2017 09:12 PM, Philippe Mathieu-Daudé wrote: On 09/04/2017 04:43 AM, Seeteena Thoufeek wrote: ---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the followi

Re: [Qemu-devel] [PATCH v4] vl: exit if maxcpus is negative

2017-09-04 Thread seeteena
On 08/30/2017 10:40 PM, Philippe Mathieu-Daudé wrote: Hi Seeteena, On 08/29/2017 02:45 AM, Seeteena Thoufeek wrote: ---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the following command with maxcpus argument as negat

[Qemu-devel] [PATCH v5] vl: exit if maxcpus is negative

2017-09-04 Thread Seeteena Thoufeek
149): GLib-ERROR **: gmem.c:130: failed to allocate 18446744073709550568 bytes Trace/breakpoint trap Reported-by: R.Nageswara Sastry Signed-off-by: Seeteena Thoufeek --- v1 -> v2: - Fix the error check in vl.c to make it generic. v2 -> v3: - Fix coding style pointed out by patchew.

Re: [Qemu-devel] [PATCH v4] vl: exit if maxcpus is negative

2017-09-01 Thread seeteena
On 08/30/2017 10:40 PM, Philippe Mathieu-Daudé wrote: Hi Seeteena, On 08/29/2017 02:45 AM, Seeteena Thoufeek wrote: ---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the following command with maxcpus argument a

Re: [Qemu-devel] [PATCH v4] vl: exit if maxcpus is negative

2017-08-30 Thread seeteena
On 08/30/2017 01:37 PM, seeteena wrote: On 08/29/2017 07:15 PM, Philippe Mathieu-Daudé wrote: Hi Seeteena, On 08/29/2017 02:45 AM, Seeteena Thoufeek wrote: ---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the

Re: [Qemu-devel] [PATCH v4] vl: exit if maxcpus is negative

2017-08-30 Thread seeteena
On 08/29/2017 07:15 PM, Philippe Mathieu-Daudé wrote: Hi Seeteena, On 08/29/2017 02:45 AM, Seeteena Thoufeek wrote: ---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the following command with maxcpus argument a

[Qemu-devel] [PATCH v4] vl: exit if maxcpus is negative

2017-08-28 Thread Seeteena Thoufeek
149): GLib-ERROR **: gmem.c:130: failed to allocate 18446744073709550568 bytes Trace/breakpoint trap Reported-by: R.Nageswara Sastry Signed-off-by: Seeteena Thoufeek --- v1 -> v2: - Fix the error check in vl.c to make it generic. v2 -> v3: - Fix coding style pointed out by patchew.

[Qemu-devel] [PATCH v3] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Seeteena Thoufeek
149): GLib-ERROR **: gmem.c:130: failed to allocate 18446744073709550568 bytes Trace/breakpoint trap Reported-by: R.Nageswara Sastry Signed-off-by: Seeteena Thoufeek Reviewed-by: Bharata B Rao --- vl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/vl.c b/vl.c ind

[Qemu-devel] [PATCH v2] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Seeteena Thoufeek
149): GLib-ERROR **: gmem.c:130: failed to allocate 18446744073709550568 bytes Trace/breakpoint trap Reported-by: R.Nageswara Sastry Signed-off-by: Seeteena Thoufeek Reviewed-by: Bharata B Rao --- vl.c | 5 + 1 file changed, 5 insertions(+) diff --git a/vl.c b/vl.c index 8e247cc..0427