Re: [PATCH v2 1/1] hw/arm/boot: set initrd with #[address/size]-cells type in fdt

Peter Maydell writes: > On Tue, 29 Nov 2022 at 10:48, Schspa Shi wrote: >> >> We use 32bit value for linux,initrd-[start/end], when we have >> loader_start > 4GB, there will be a wrong initrd_start passed >> to the kernel, and the kernel will report the followin

[PATCH v3 1/1] hw/arm/boot: set initrd with #address-cells type in fdt

lls type. Signed-off-by: Schspa Shi -- Changelog: v1 -> v2: - Use #[address/size]-cells for data type. v2 -> v3: - Use #address-cells for all data type. - Fix indent. --- hw/arm/boot.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [PATCH v2 1/1] hw/arm/boot: set initrd with #[address/size]-cells type in fdt

Philippe Mathieu-Daudé writes: > On 29/11/22 11:48, Schspa Shi wrote: >> We use 32bit value for linux,initrd-[start/end], when we have >> loader_start > 4GB, there will be a wrong initrd_start passed >> to the kernel, and the kernel will report the following w

[PATCH v2 1/1] hw/arm/boot: set initrd with #[address/size]-cells type in fdt

lls type. Signed-off-by: Schspa Shi -- Changelog: v1 -> v2: - Use #[address/size]-cells for data type. --- hw/arm/boot.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 57efb61ee419..98cd1fdad2c6 100644 --- a/hw/arm/

Re: [PATCH] hw/arm/boot: set initrd parameters to 64bit in fdt

Peter Maydell writes: > On Tue, 8 Nov 2022 at 02:35, Schspa Shi wrote: >> >> We use 32bit value for linux,initrd-[start/end], when we have >> loader_start > 4GB, there will be a wrong initrd_start passed >> to the kernel, and the kernel will report the following

Re: [PATCH] hw/arm/boot: set initrd parameters to 64bit in fdt

Peter Maydell writes: > On Wed, 16 Nov 2022 at 06:11, Schspa Shi wrote: >> >> >> Peter Maydell writes: >> >> > On Tue, 8 Nov 2022 at 15:50, Schspa Shi wrote: >> >> >> >> >> >> Peter Maydell writes:

Re: [PATCH] hw/arm/boot: set initrd parameters to 64bit in fdt

Peter Maydell writes: > On Tue, 8 Nov 2022 at 15:50, Schspa Shi wrote: >> >> >> Peter Maydell writes: >> >> > On Tue, 8 Nov 2022 at 13:54, Peter Maydell >> > wrote: >> >> >> >> On Tue, 8 Nov 2022 at 12:52, Schspa Shi wro

Re: [PATCH] hw/arm/boot: set initrd parameters to 64bit in fdt

Peter Maydell writes: > On Tue, 8 Nov 2022 at 13:54, Peter Maydell wrote: >> >> On Tue, 8 Nov 2022 at 12:52, Schspa Shi wrote: >> > Alex Bennée writes: >> > > There is a whole comment in boot.c talking about keeping initrd within >> > > lowme

Re: [PATCH] hw/arm/boot: set initrd parameters to 64bit in fdt

Alex Bennée writes: > Schspa Shi writes: > >> We use 32bit value for linux,initrd-[start/end], when we have >> loader_start > 4GB, there will be a wrong initrd_start passed >> to the kernel, and the kernel will report the following warning. >> >>

[PATCH] hw/arm/boot: set initrd parameters to 64bit in fdt

off-by: Schspa Shi --- hw/arm/boot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 57efb61ee419..da719a4f8874 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -638,14 +638,14 @@ int arm_load_dtb(hwaddr addr, const struct arm_boot_i

Re: [PATCH v4] virtio-mmio: improve virtio-mmio get_dev_path alog

Thank you very much. Best regards. Peter Maydell 于2021年3月5日周五 下午7:57写道： > On Thu, 25 Feb 2021 at 05:36, schspa wrote: > > > > At the moment the following QEMU command line triggers an assertion > > failure On xlnx-versal SOC: > > qemu-system-aarch64 \ > >

Re: [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment

think we can reasonably ignore that unlikely corner case.) Thanks for your suggestions, I have tried it on both arm virt & the Xilinx platform works perfectly. I have upload a new patch v4 for it. -- schspa

[PATCH v4] virtio-mmio: improve virtio-mmio get_dev_path alog

cpu. Besides, xlnx-versal can't add sysbus_mmio_map api call too, because this will add memory region to system_memory, and it can't be added to VersalVirt.soc.fpd.apu.mr again. We can solve this by assign correct base address offset on dev_path. This path was test on aarch64 virt &

[PATCH v3] virtio-mmio: improve virtio-mmio unique device path assignment

cpu. Besides, xlnx-versal can't add sysbus_mmio_map api call too, because this will add memory region to system_memory, and it can't be added to VersalVirt.soc.fpd.apu.mr again. We can solve this by assign correct base address offset on dev_path. This path was test on aarch64 virt &

Re: [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment

ify a unique device_path for virtio_mmio TypeInfo. 2. modify TYPE_VIRTIO_MMIO_BUS add a global static instance count to generate a unique device path. -- schspa

[PATCH v2] arm: xlnx-versal: fix virtio-mmio base address assignment

cpu. Besides, xlnx-versal can't add sysbus_mmio_map api call too, because this will add memory region to system_memory, and it can't be added to VersalVirt.soc.fpd.apu.mr again. We can solve this by simply assign mmio[0].addr directly. makes virtio_mmio_bus_get_dev_path to produce correc

Re: [PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment

quot; (maintainer:Xilinx > ZynqMP > and...) > Peter Maydell (maintainer:Xilinx ZynqMP > and...) > qemu-...@nongnu.org (open list:Xilinx ZynqMP and...) > Thanks for reminding, I will pay attention next time > On 2/4/21 7:58 AM, schspa wrote: > > > > At the moment t

[PATCH] arm: xlnx-versal: fix virtio-mmio base address assignment

solve this by simply assign mmio[0].addr directly. makes virtio_mmio_bus_get_dev_path to produce correct unique device path. Signed-off-by: schspa ---  hw/arm/xlnx-versal-virt.c | 1 +  1 file changed, 1 insertion(+) diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c index 8482cd6196..87