Hi,
Allocating txbuf in struct Stream seems to be good. I can see other
pointers of struct Stream being allocated in xilinx_axidma_realize(),
but I am not able to find their deallocation point anywhere?
Regards
Rutuja Shah
On Tue, Oct 4, 2016 at 3:56 AM, Edgar E. Iglesias
wrote:
> On Mon,
++ stefan Sorry for the typo.
Regards
Rutuja Shah
On Mon, Oct 3, 2016 at 10:26 PM, wrote:
> From: Rutuja Shah
>
> This patch allocates memory for txbuf array on the heap rather than the stack.
> As a result, the stack frame size is reduced.
>
> Signed-off-by: Rutuja Sha
.c | 2 +-
> include/hw/acpi/acpi.h| 2 +-
> include/qemu/timer.h | 9 ++---
> monitor.c | 4 ++--
> target-ppc/kvm.c | 4 ++--
> 53 files changed, 143 insertions(+), 134 deletions(-)
> ---
> Thanks,
> Rutuja Shah
Regards
Rutuja Shah
On Tue, Mar 15, 2016 at 6:01 PM, Stefan Hajnoczi wrote:
> On Mon, Mar 14, 2016 at 06:29:06PM +0530, rutuja shah wrote:
>> > What is the benefit of adding the NULL checks? The only difference I
>> > see is that the error message from load_elf() is sile
Regards
Rutuja Shah
On Mon, Mar 14, 2016 at 5:14 PM, Stefan Hajnoczi wrote:
> On Sun, Mar 13, 2016 at 02:06:34AM +0530, rutu.shah...@gmail.com wrote:
>> From: Rutuja Shah
>>
>> This patch adds NULL check for return value from qemu_find_file(), where it
>> is mis
Hi,
Sorry for the inconvenience caused due to the format of my patch.
Due to a typo mail id was wrong, adding blauwir...@gmail.com
On Mar 11, 2016 1:00 AM, wrote:
> From: Rutuja Shah
>
> ---
> audio/audio.c | 2 +-
> audio/noaudio.c | 4 ++--
>
Thanks Eric. I will keep these points in mind while sending patches.
Regards
Rutuja Shah
On Fri, Mar 11, 2016 at 2:40 AM, Eric Blake wrote:
> On 03/10/2016 12:30 PM, rutu.shah...@gmail.com wrote:
>> From: Rutuja Shah
>>
>
> Your commit message body was botched, crammin
t_ticks_per_sec(), clock_freq);
+return muldiv64(ti.QuadPart, NANOSECONDS_PER_SECOND, clock_freq);
}
#else
diff --git a/monitor.c b/monitor.c
index e99ca8c..6bdf174 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1506,9 +1506,9 @@ int64_t dev_time;
static void hmp_info_profile(Monitor *mon, const QDict *qdict)
{
monitor_printf(mon, "async time %" PRId64 " (%0.3f)\n",
- dev_time, dev_time / (double)get_ticks_per_sec());
+ dev_time, dev_time / (double)NANOSECONDS_PER_SECOND);
monitor_printf(mon, "qemu time %" PRId64 " (%0.3f)\n",
- tcg_time, tcg_time / (double)get_ticks_per_sec());
+ tcg_time, tcg_time / (double)NANOSECONDS_PER_SECOND);
tcg_time = 0;
dev_time = 0;
}
diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index d67c169..a095c91 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -1336,7 +1336,7 @@ void kvm_arch_pre_run(CPUState *cs, struct kvm_run *run)
/* Always wake up soon in case the interrupt was level based */
timer_mod(idle_timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
- (get_ticks_per_sec() / 50));
+ (NANOSECONDS_PER_SECOND / 50));
}
/* We don't know if there are more interrupts pending after this. However,
@@ -1796,7 +1796,7 @@ uint32_t kvmppc_get_tbfreq(void)
{
char line[512];
char *ns;
-uint32_t retval = get_ticks_per_sec();
+uint32_t retval = NANOSECONDS_PER_SECOND;
if (read_cpuinfo("timebase", line, sizeof(line))) {
return retval;
--
1.9.1
Regards
Rutuja Shah