Re: [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates

2015-05-10 Thread phoeagon
I'm not familiar with the VirtualBox code base, but looks like " vdIOIntWriteMeta" can work both synchronously & asynchronously, and "vdiBlockAllocUpdate" looks async to me. Frankly, skimming through the code for 5 min doesn't enlighten me too much on its detailed implementation, but looks like at

Re: [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates

2015-05-10 Thread phoeagon
5 um 17:01 schrieb Paolo Bonzini: > > > > On 09/05/2015 05:54, phoeagon wrote: > >> zheq-PC sdb # time ~/qemu-sync-test/bin/qemu-img convert -f raw -t > writeback -O vdi /run/shm/rand 1.vdi > >> > >> real0m8.678s > >> user0m0.169s > >> sys0m0

Re: [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates

2015-05-09 Thread phoeagon
ot; formats like VPC (vanilla VPC 7min43s) The thing is he who needs to set up a new Linux system every day probably have pre-installed images to start with, and others just don't install an OS every day. On Sat, May 9, 2015 at 2:39 PM Stefan Weil wrote: > Am 09.05.2015 um 05:59 schrieb p

Re: [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates

2015-05-08 Thread phoeagon
BTW, how do you usually measure the time to install a Linux distro within? Most distros ISOs do NOT have unattended installation ISOs in place. (True I can bake my own ISOs for this...) But do you have any ISOs made ready for this purpose? On Sat, May 9, 2015 at 11:54 AM phoeagon wrote

Re: [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates

2015-05-08 Thread phoeagon
the window > > smaller would require a journal, which VDI just doesn't have. > > > > I'm not convinced of this patch, but I'll defer to Stefan Weil as the > > VDI maintainer. > > > > Kevin > > Thanks for asking. I share your concerns regardi

Re: [Qemu-devel] [PATCH v4] block/vdi: Use bdrv_flush after metadata updates

2015-05-08 Thread phoeagon
Then I would guess the same reason should apply to VMDK/VPC as well... Their metadata update protocol is not atomic either, and a sync after metadata update doesn't fix the whole thing theoretically either. Yet the metadata sync patches as old as since 2010 are still there. It should also be a perf

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates

2015-05-08 Thread phoeagon
evin Wolf wrote: > Am 08.05.2015 um 13:50 hat phoeagon geschrieben: > > In case of correctness, lacking a sync here does not introduce data > corruption > > I can think of. But this reduces the volatile window during which the > metadata > > changes are NOT guaranteed on

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block/vdi: Use bdrv_flush after metadata updates

2015-05-08 Thread phoeagon
he Qiu geschrieben: > > From: phoeagon > > > > In reference to > b0ad5a455d7e5352d4c86ba945112011dbeadfb8~078a458e077d6b0db262c4b05fee51d01de2d1d2, > metadata writes to qcow2/cow/qcow/vpc/vmdk are all synced prior to > succeeding writes. > > The justification fo

Re: [Qemu-devel] [PATCH] use bdrv_flush to provide barrier semantic in block/vdi.c for metadata updates

2015-05-06 Thread phoeagon
iu >From 19b2fabbe00765b418362d8c1891f266091621f3 Mon Sep 17 00:00:00 2001 From: phoeagon Date: Thu, 7 May 2015 01:09:38 +0800 Subject: [PATCH] block/vdi: Use bdrv_flush after metadata updates In reference to b0ad5a455d7e5352d4c86ba945112011dbeadfb8~078a458e077d6b0db262c4b05fee51d01de2d1d2, me

[Qemu-devel] [PATCH] use bdrv_flush to provide barrier semantic in block/vdi.c for metadata updates

2015-05-01 Thread phoeagon
adds a `bdrv_flush` after updating block map. Signed-off-by: Zhe Qiu --- >From 2ea36d9a0e676b534483dc54c191f421f9889dc6 Mon Sep 17 00:00:00 2001 From: phoeagon Date: Fri, 1 May 2015 19:00:22 +0800 Subject: [PATCH] use bdrv_flush to provide barrier semantic in block/vdi.c