Re: [PATCH v5 04/18] gdbstub: DebugClass added to system mode.

2024-03-05 Thread nicolas.e...@lauterbach.com
Hi Alex, I managed to include all of your feedback except for the one on this patch: You shouldn't need empty functions if you are not using them. Moreover you should use the inheritance feature and have something like: static void gdb_debug_class_init(ObjectClass *klass, void *data) { De

Re: [PATCH v5 11/18] mcdstub: system and core queries added

2024-03-05 Thread nicolas.e...@lauterbach.com
On 29/02/2024 16:11, Alex Bennée wrote: Hopefully the code can be more generic now and avoid having to re-parse generated xml. I adapted my code to the recent register-related changes. There is still some arm-specific code, but thanks to gdb_get_register_list() and gdb_read_register() I coul

Re: [PATCH v5 05/18] mcdstub: memory helper functions added

2024-03-05 Thread nicolas.e...@lauterbach.com
On 29/02/2024 17:56, Alex Bennée wrote: I think there is some scope to re-factor some code that is shared with cpu_memory_rw_debug. In fact rather than using this to feed mcd_read_write_memory() maybe you really just want a cpu_physical_memory_rw_debug()? Although as you are going from vaddr an

Re: [PATCH v3 00/20] first version of mcdstub

2023-11-29 Thread nicolas.e...@lauterbach.com
On 29/11/2023 15:44, Alex Bennée wrote: Nicolas Eder writes: SUMMARY === This patch-set introduces the first version of the mcdstub. The mcdstub is a debug interface, which enables debugging QEMU using the MCD (Multi-Core Debug) API. The mcdstub uses TCP to communicate with the host debu

Re: [PATCH v3 00/20] first version of mcdstub

2023-11-13 Thread nicolas.e...@lauterbach.com
Hi Phil, okay thanks! I'll add the license. Regards, Nicolas On 08/11/2023 15:27, Philippe Mathieu-Daudé wrote: Hi Nicolas, On 7/11/23 14:03, Nicolas Eder wrote: SUMMARY === This patch-set introduces the first version of the mcdstub.   30 files changed, 3749 insertions(+), 38 deletio

Re: [PATCH v3 05/20] mcdstub: tcp packet processing added

2023-11-13 Thread nicolas.e...@lauterbach.com
Hi Phil, as of right now, there is no official spec for the TCP packet contents. However, in the client code it is rather easy see how the packets are constructed. I hope I will get the client code online by the end of the week. I will also look into qtest. We definetely need a test like this