ous and
> would
> be outdated now.
This looks good to me. I can give you an:
Acked-by: Corey Minyard
or I can take it into my tree.
-corey
>
> Fixes: 20d0f9cf6a41 ("i.MX: Add I2C controller emulator")
> cc: qemu-stable
> Signed-off-by: Bernhard Beschow
>
fixes for various things
----
Corey Minyard (1):
hw/ipmi: Move vmsd registration to device class
Nicholas Piggin (5):
ipmi/pci-ipmi-bt: Rename copy-paste variables
ipmi: add fwinfo to pci ipmi devices
ipmi/bmc-sim
ge-ID: <20250401140153.685523-2-npig...@gmail.com>
Signed-off-by: Corey Minyard
---
hw/ipmi/pci_ipmi_bt.c | 38 +++---
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/hw/ipmi/pci_ipmi_bt.c b/hw/ipmi/pci_ipmi_bt.c
index afeea6f303..a3b742d22c 100644
--
mail.com>
Signed-off-by: Corey Minyard
---
hw/ipmi/ipmi_bmc_sim.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c
index 4ed66e1ee0..1c60a71831 100644
--- a/hw/ipmi/ipmi_bmc_sim.c
+++ b/hw/ipmi/ipmi_bmc_sim.c
@@ -2
on.py -d desc -f file1.mig >file1.json
scripts/analyze-migration.py -d desc -f file2.mig >file2.json
diff file1.json file2.json
with no differences.
Signed-off-by: Corey Minyard
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Fabiano Rosas
---
hw/ipmi/ipmi_bmc_extern.
From: Nicholas Piggin
If the dont-log flag is set in the 'timer use' field for the
'set watchdog' command, a watchdog timeout will not get logged as
a timer use expiration.
Signed-off-by: Nicholas Piggin
Message-ID: <20250401140153.685523-5-npig...@gmail.com>
Si
From: Nicholas Piggin
Linux issues this command when booting a powernv machine.
Signed-off-by: Nicholas Piggin
Message-ID: <20250401140153.685523-4-npig...@gmail.com>
Signed-off-by: Corey Minyard
---
hw/ipmi/ipmi_bmc_sim.c | 68 --
hw/ipmi/ipm
nfo to pci_ipmi_kcs_get_fwinfo in the
pci_ipmi_kcs.c file.]
Signed-off-by: Corey Minyard
---
hw/acpi/ipmi.c | 3 ++-
hw/ipmi/isa_ipmi_bt.c | 1 +
hw/ipmi/isa_ipmi_kcs.c | 1 +
hw/ipmi/pci_ipmi_bt.c | 12
hw/ipmi/pci_ipmi_kcs.c | 11 +++
hw/smbios/smbios_type_38.
On Fri, Apr 11, 2025 at 04:25:10PM +1000, Nicholas Piggin wrote:
> On Wed Apr 2, 2025 at 5:17 AM AEST, Corey Minyard wrote:
> > On Wed, Apr 02, 2025 at 12:01:47AM +1000, Nicholas Piggin wrote:
> >> These little things came up when looking at behaviour of IPMI with
> >>
On Tue, Apr 01, 2025 at 09:44:09PM +1000, Nicholas Piggin wrote:
> This requires some adjustments to callers to avoid possible behaviour
> changes for PCI devices.
>
> Signed-off-by: Nicholas Piggin
> ---
> include/hw/ipmi/ipmi.h | 5 +
> hw/acpi/ipmi.c | 2 +-
> hw/ipmi/is
On Tue, Apr 01, 2025 at 09:42:01AM +1000, Nicholas Piggin wrote:
> On Mon Mar 31, 2025 at 11:25 PM AEST, Corey Minyard wrote:
> > On Mon, Mar 31, 2025 at 10:57:24PM +1000, Nicholas Piggin wrote:
> >> +static void get_channel_info(IPMIBmcSim *ibs,
> >> +
On Wed, Mar 19, 2025 at 08:21:20PM +0100, Markus Armbruster wrote:
> Corey Minyard writes:
>
> > Is this official coding style? I'm not a big fan of having return
> > statements in the middle of functions, I generally only put them at
> > the beginning or the end.
Is this official coding style? I'm not a big fan of having return
statements in the middle of functions, I generally only put them at
the beginning or the end.
-corey
On Wed, Mar 19, 2025 at 10:26 AM Markus Armbruster wrote:
>
> Signed-off-by: Markus Armbruster
> ---
> hw/ipmi/ipmi_bmc_extern
On Tue, Apr 01, 2025 at 08:37:19AM +1000, Nicholas Piggin wrote:
> On Mon Mar 31, 2025 at 11:13 PM AEST, Corey Minyard wrote:
> > On Mon, Mar 31, 2025 at 10:57:22PM +1000, Nicholas Piggin wrote:
> >> If the dont-log flag is set in the 'timer use' field for the
&g
On Fri, Apr 04, 2025 at 02:41:46PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Corey,
>
> On 4/4/25 02:57, Corey Minyard wrote:
> > Allow a system to have multiple BMC connections to the same BMC and
> > multiple different BMCs. This can happen on real systems, and is
>
on.py -d desc -f file1.mig >file1.json
scripts/analyze-migration.py -d desc -f file2.mig >file2.json
diff file1.json file2.json
with no differences.
Signed-off-by: Corey Minyard
---
hw/ipmi/ipmi_bmc_extern.c | 3 +--
hw/ipmi/ipmi_bmc_sim.c| 3 +--
hw/ipmi/isa_ipmi_bt.c
On Fri, Apr 04, 2025 at 03:21:09PM +0200, Philippe Mathieu-Daudé wrote:
> On 4/4/25 15:04, Corey Minyard wrote:
> > On Fri, Apr 04, 2025 at 02:41:46PM +0200, Philippe Mathieu-Daudé wrote:
> > > Hi Corey,
> > >
> > > On 4/4/25 02:57, Corey Minyard wrote:
> &g
Allow a system to have multiple BMC connections to the same BMC and
multiple different BMCs. This can happen on real systems, and is
useful for testing the IPMI driver on Linux.
Signed-off-by: Corey Minyard
---
I'm working on a fairly extensive test suite for IPMI, the Linux
driver and
On Mon, Mar 31, 2025 at 10:57:22PM +1000, Nicholas Piggin wrote:
> If the dont-log flag is set in the 'timer use' field for the
> 'set watchdog' command, a watchdog timeout will not get logged as
> a timer use expiration.
>
> Signed-off-by: Nicholas Piggin
> ---
> hw/ipmi/ipmi_bmc_sim.c | 7
Thanks to Philippe for reviewing, too.
I can give you an
Acked-by: Corey Minyard
if you are working on this for your own tree, or I can take it into
mine.
-corey
>
> Since v1 (thanks to Corey for review and suggestions):
> - Added fwinfo to PCI devices
> - Report interrupt number in
On Tue, Apr 01, 2025 at 09:44:11PM +1000, Nicholas Piggin wrote:
> If the dont-log flag is set in the 'timer use' field for the
> 'set watchdog' command, a watchdog timeout will not get logged as
> a timer use expiration.
>
> Signed-off-by: Nicholas Piggin
> ---
> hw/ipmi/ipmi_bmc_sim.c | 32 +++
On Mon, Mar 31, 2025 at 06:03:11PM -0500, Corey Minyard wrote:
> On Tue, Apr 01, 2025 at 08:37:19AM +1000, Nicholas Piggin wrote:
> > On Mon Mar 31, 2025 at 11:13 PM AEST, Corey Minyard wrote:
> > > On Mon, Mar 31, 2025 at 10:57:22PM +1000, Nicholas Piggin wrote:
> > >&g
On Mon, Mar 31, 2025 at 10:57:24PM +1000, Nicholas Piggin wrote:
> Linux issues this command when booting a powernv machine.
This is good, just a couple of nits.
>
> Signed-off-by: Nicholas Piggin
> ---
> include/hw/ipmi/ipmi.h | 14 +++
> hw/ipmi/ipmi_bmc_sim.c | 56 ++
On Tue, Mar 25, 2025 at 11:43:04PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/i2c/i2c_mux_pca954x.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Looks ok to me.
Acked-by: Corey Minyard
>
> diff --git a/hw/i2c/i
On Wed, Mar 19, 2025 at 03:51:45PM -0500, Corey Minyard wrote:
> On Wed, Mar 19, 2025 at 08:49:01PM +0100, Markus Armbruster wrote:
> > Corey Minyard writes:
> >
> > > On Wed, Mar 19, 2025 at 08:21:20PM +0100, Markus Armbruster wrote:
> > >> Corey Minya
On Wed, Mar 19, 2025 at 08:49:01PM +0100, Markus Armbruster wrote:
> Corey Minyard writes:
>
> > On Wed, Mar 19, 2025 at 08:21:20PM +0100, Markus Armbruster wrote:
> >> Corey Minyard writes:
> >>
> >> > Is this official coding style? I'm not a bi
gt; > create mode 100644 hw/rtc/rs5c372.c
> > > > > create mode 100644 tests/qtest/rs5c372-test.c
> > > >
> > > > Ping for just this patch. I'd like to have it merged for 10.0.
> > >
> > > Ping^2 -- just few days left before soft freez
I'm not sure about ownership here, but from an I2C point of view this
all looks ok.
Reviewed-by: Corey Minyard
On Mon, Jan 20, 2025 at 12:43 PM Bernhard Beschow wrote:
>
> Xilinx QEMU implements a TCA6416 device model which may be useful for the
> broader QEMU community, so upstr
On Tue, Jan 21, 2025 at 10:59:34AM +, Titus Rwantare wrote:
> This has been useful when debugging and unsure if the guest is
> generating i2c traffic.
Acked-by: Corey Minyard
>
> Signed-off-by: Titus Rwantare
> ---
> hw/misc/i2c-echo.c | 8
> hw/
d-off-by: Bernhard Beschow
This seems reasonable.
Acked-by: Corey Minyard
> ---
> hw/i2c/imx_i2c.c| 21 +
> hw/i2c/trace-events | 5 +
> 2 files changed, 10 insertions(+), 16 deletions(-)
>
> diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c
&
Yeah, a no brainer.
Acked-by: Corey Minyard
On Fri, Dec 13, 2024 at 01:07:02PM -0600, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> hw/i2c/aspeed_i2c.c | 4 ++--
> hw/i2c/core.c| 2 +-
> hw/i2c/i2c_mux_pca954x.c | 2 +-
> hw/i2c/oma
Acked-by: Corey Minyard
On Fri, Dec 13, 2024 at 01:07:08PM -0600, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> hw/ipmi/ipmi.c| 2 +-
> hw/ipmi/ipmi_bmc_extern.c | 2 +-
> hw/ipmi/ipmi_bmc_sim.c| 2 +-
> hw/ipmi/isa_ipmi_bt.c
On Thu, Nov 07, 2024 at 07:54:51PM +, Titus Rwantare wrote:
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Titus Rwantare
Acked-by: Corey Minyard
> ---
> hw/i2c/core.c | 8 +---
> hw/i2c/trace-events | 2 +-
> 2 files changed, 6 insertions(+), 4 dele
On Sun, Nov 03, 2024 at 02:33:58PM +0100, Bernhard Beschow wrote:
> Reviewed-by: Cédric Le Goater
> Signed-off-by: Bernhard Beschow
Acked-by: Corey Minyard
> ---
> hw/i2c/mpc_i2c.c | 20
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
>
On Sun, Nov 03, 2024 at 02:34:08PM +0100, Bernhard Beschow wrote:
> Reviewed-by: Cédric Le Goater
> Signed-off-by: Bernhard Beschow
Yeah, I think this is best.
Acked-by: Corey Minyard
> ---
> hw/i2c/smbus_eeprom.c | 19 ---
> 1 file changed, 8 insertions(+
On Sun, Nov 03, 2024 at 12:08:22AM +0100, BALATON Zoltan wrote:
> On Sat, 2 Nov 2024, Corey Minyard wrote:
> > On Sat, Nov 02, 2024 at 02:17:00PM +0100, Bernhard Beschow wrote:
> > > Reviewed-by: Cédric Le Goater
> > > Signed-off-by: Bernhard Beschow
> >
On Sat, Nov 02, 2024 at 02:17:01PM +0100, Bernhard Beschow wrote:
> Reviewed-by: Cédric Le Goater
> Signed-off-by: Bernhard Beschow
> ---
> hw/i2c/mpc_i2c.c | 20
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
> diff --git a/hw/i2c/mpc_i2c.c b/hw/i2c/mpc_i2c.c
> index
On Sat, Nov 02, 2024 at 02:17:00PM +0100, Bernhard Beschow wrote:
> Reviewed-by: Cédric Le Goater
> Signed-off-by: Bernhard Beschow
Signed-off-by: Corey Minyard
> ---
> hw/i2c/mpc_i2c.c| 9 +
> hw/i2c/trace-events | 5 +
> 2 files changed, 10 insertio
On Sat, Nov 2, 2024 at 8:25 AM Bernhard Beschow wrote:
>
> Reviewed-by: Cédric Le Goater
> Signed-off-by: Bernhard Beschow
> ---
> hw/i2c/smbus_eeprom.c | 19 ---
> 1 file changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
>
Thanks, this all looks good to me. And FIELD() is the right way to
go, as Peter said.
-corey
On Fri, Sep 20, 2024 at 1:03 PM Octavian Purdila wrote:
>
> On Thu, Sep 19, 2024 at 2:36 AM Peter Maydell
> wrote:
> >
> > On Wed, 18 Sept 2024 at 22:31, Corey Minyard wrote:
On Wed, Sep 18, 2024 at 04:03:12PM -0700, Octavian Purdila wrote:
> On Wed, Sep 18, 2024 at 1:06 PM Corey Minyard wrote:
> >
> > On Wed, Sep 18, 2024 at 12:22:47PM -0700, Octavian Purdila wrote:
> > > Add a simple i2c peripheral to be used for testing I2C device
> >
On Wed, Sep 18, 2024 at 02:04:58PM -0700, Octavian Purdila wrote:
> On Wed, Sep 18, 2024 at 1:17???PM Corey Minyard wrote:
> >
> > On Wed, Sep 18, 2024 at 12:22:36PM -0700, Octavian Purdila wrote:
> > > Add support for NXP's flexcomm i2c. It does not su
On Wed, Sep 18, 2024 at 12:22:36PM -0700, Octavian Purdila wrote:
> Add support for NXP's flexcomm i2c. It does not support slave mode or
> DMA.
>
> The patch includes an automatically generated header which contains
> the register layout and helpers.
>
> The header can be regenerated with the sv
On Wed, Sep 18, 2024 at 12:22:47PM -0700, Octavian Purdila wrote:
> Add a simple i2c peripheral to be used for testing I2C device
> models. The peripheral has a fixed number of registers that can be
> read and written.
Why is this better than just using the eeprom device?
This has some uncommon a
On Mon, Apr 08, 2024 at 11:33:34PM +0200, Philippe Mathieu-Daudé wrote:
> Mechanical (mostly) conversion inspired by Wolfram [*] to
> use inclusive terminology, similarly to the other renames
> we did 3 years ago, shortly before the I2C spec v7 was
> published.
Sorry, I've been extremely busy on t
mu device. And i2c
bus mastering in qemu is pretty esoteric, not many people know anything
about it.
-corey
>
> Thanks again,
> Paz
>
>
>
>
>
> From: Corey Minyard on behalf of Corey Minyard
>
> Sent: Monday, February 19, 2024
On Mon, Feb 19, 2024 at 01:49:44PM +, Paz Offer wrote:
> Hi,
>
> I am new to QEMU development, so please excuse if I my direction here is
> wrong:
>
> I am trying to implement an i2c slave device.
> My device should be able to read/write data from its i2c bus.
>
> I defined my device-state
On Thu, Feb 08, 2024 at 04:39:10PM +, Peter Maydell wrote:
> On Fri, 2 Feb 2024 at 20:48, Joe Komlodi wrote:
> >
> > It's possible for a reset to come in the middle of a transaction, which
> > causes the bus to be in an old state when a new transaction comes in.
> >
> > Signed-off-by: Joe Koml
On Wed, Jan 10, 2024 at 09:26:37PM +, Joe Komlodi wrote:
> Hi all,
>
> This series adds some resets for SMBus and for the I2C core. Along with
> it, we make SMBus slave error printing a little more helpful.
>
> These reset issues were very infrequent, they would maybe occur in 1 out
> of hund
From: Corey Minyard
Some minor I2C changes. One has been sitting in my queue forgotten for
a while, but still needs to go in. The other is fairly recent. Both
are for BMC related stuff.
These are available at:
https://github.com/cminyard/qemu.git i2c-for-release-2023-12-06
and signed by
From: Titus Rwantare
Reviewed-by: Patrick Venture
Reviewed-by: Chris Rauer
Reviewed-by: Hao Wu
Signed-off-by: Titus Rwantare
Message-Id: <20220106173814.3580141-1-vent...@google.com>
Signed-off-by: Corey Minyard
---
hw/sensor/adm1272.c| 27 ++-
tests
From: Potin Lai
Add pca9543 2-channel i2c-mux switch support.
Signed-off-by: Potin Lai
Reviewed-by: Patrick Venture
Message-Id: <20231113063156.2264941-1-potin.lai...@gmail.com>
Signed-off-by: Corey Minyard
---
hw/i2c/i2c_mux_pca954x.c | 12
include/
On Tue, Dec 05, 2023 at 11:05:33AM -0800, Patrick Venture wrote:
> On Tue, Nov 14, 2023 at 3:30 PM Corey Minyard wrote:
>
> > On Mon, Nov 13, 2023 at 02:31:56PM +0800, Potin Lai wrote:
> > > Add pca9543 2-channel i2c-mux switch support.
> > >
> > > Signed-o
On Mon, Nov 13, 2023 at 02:31:56PM +0800, Potin Lai wrote:
> Add pca9543 2-channel i2c-mux switch support.
>
> Signed-off-by: Potin Lai
Looks good to me.
Acked-by: Corey Minyard
> ---
> hw/i2c/i2c_mux_pca954x.c | 12
> include/hw/i2c/i2c_mux_pca954x.h
w
Looks good to me.
Acked-by: Corey Minyard
> ---
> hw/i2c/pm_smbus.c | 18 --
> hw/i2c/trace-events | 6 ++
> 2 files changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/pm_smbus.c
> index 4e1b8a5182..78e7c229a8
> >
> > Signed-off-by: Thomas Huth
>
> Reviewed-by: Juan Quintela
>
> It fixes my issues.
>
> Should I take this through the Migration tree?
That's fine with me.
Acked-by: Corey Minyard
>
+" -chardev socket,id=ipmi0,host=127.0.0.1,port=%d,reconnect=10"
Yeah, this make sense.
Acked-by: Corey Minyard
> " -device ipmi-bmc-extern,chardev=ipmi0,id=bmc0"
> " -device isa-ipmi-bt,bmc=bmc0", emu_port);
> qtest_irq_intercept_in(global_qtest, "ioapic");
> --
> 2.34.1
>
On Mon, Sep 25, 2023 at 04:47:39PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> hw/i2c/pm_smbus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
This looks ok to me.
Acked-by: Corey Minyard
>
> diff --git a/hw/i2c/pm_smbus.c b/hw/i2c/
On Wed, Sep 20, 2023 at 06:31:25AM -0700, Klaus Jensen wrote:
> On Sep 20 07:54, Corey Minyard wrote:
> > On Wed, Sep 20, 2023 at 12:48:03PM +0100, Jonathan Cameron via wrote:
> > > On Thu, 14 Sep 2023 11:53:40 +0200
> > > Klaus Jensen wrote:
> > >
> > &
On Wed, Sep 20, 2023 at 12:48:03PM +0100, Jonathan Cameron via wrote:
> On Thu, 14 Sep 2023 11:53:40 +0200
> Klaus Jensen wrote:
>
> > This adds a generic MCTP endpoint model that other devices may derive
> > from.
> >
> > Also included is a very basic implementation of an NVMe-MI device,
> > su
previously posted code by Padmakar Kalghatgi, Arun
> Kumar Agasar and Saurav Kumar.
This seems fine.
Acked-by: Corey Minyard
One question, though. You don't have any tests. Did you test invalid
packets and such? I think the logic is correct, but those are things
that are good to test.
derive from this and implement the class
> methods.
>
> Parts of this implementation is inspired by code[1] previously posted by
> Jonathan Cameron.
I've been kind of watching this, I guess I need to review. I've been
over the logic and it all looks good, I think. So I c
On Thu, Sep 14, 2023 at 11:53:41AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add i2c_smbus_pec() to calculate the SMBus Packet Error Code for a
> message.
Seems fine.
Acked-by: Corey Minyard
>
> Reviewed-by: Jonathan Cameron
> Signed-off-by: Klaus Je
On Wed, May 31, 2023 at 01:47:41PM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> This adds a generic MCTP endpoint model that other devices may derive
> from. I'm not 100% happy with the design of the class methods, but it's
> a start.
>
> Also included is a very basic implementation of an
On Wed, Apr 26, 2023 at 09:11:16AM +0200, Klaus Jensen wrote:
> On Apr 25 10:19, Corey Minyard wrote:
> > On Tue, Apr 25, 2023 at 08:35:38AM +0200, Klaus Jensen wrote:
> > > From: Klaus Jensen
> > >
> > > Add an abstract MCTP over I2C endpoint model. This i
On Tue, Apr 25, 2023 at 08:35:38AM +0200, Klaus Jensen wrote:
> From: Klaus Jensen
>
> Add an abstract MCTP over I2C endpoint model. This implements MCTP
> control message handling as well as handling the actual I2C transport
> (packetization).
>
> Devices are intended to derive from this and im
On Mon, Apr 24, 2023 at 11:02:08AM -0500, Corey Minyard wrote:
> On Mon, Apr 24, 2023 at 02:09:50PM +, Karol Nowak wrote:
> > Hi Corey,
> >
> >
> >
> > Have you got a chance to look at the I2C code?
>
> No, I have not. I've been pretty busy with
slave.
-corey
>
>
>
> Karol
>
>
> ________
> From: Corey Minyard on behalf of Corey Minyard
>
> Sent: Wednesday, April 19, 2023 4:35 PM
> To: Karol Nowak
> Cc: qemu-devel@nongnu.org ; phi...@linaro.org
> ; c...@kaod.org
> Subject: Re: [RFC PATCH v1] hw/misc: add i2
tment to accommodate this.
-corey
>
> Best regards,
> Karol
>
>
>
>
> From: Corey Minyard on behalf of Corey Minyard
>
> Sent: Monday, April 17, 2023 4:34 PM
> To: Karol Nowak
> Cc: qemu-devel@nongnu.org ; phi...@linaro.org
;
You can look at hw/ipmi/ipmi_bmc_extern.c for an example.
-corey
>
> Karol
>
>
> ____
> From: Corey Minyard on behalf of Corey Minyard
>
> Sent: Thursday, March 23, 2023 5:03 PM
> To: Karol Nowak
> Cc: qemu-devel@nongnu.org ; phi...@li
e cast-related issue in the
> CXL code in pci_expander_bridge.c.
>
> Signed-off-by: Peter Maydell
Looks correct ot me.
Reviewed-by: Corey Minyard
> ---
> hw/i2c/allwinner-i2c.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/i2c/allwinner-i2
But those are really
minor nits, I didn't see anything really wrong with this.
Reviewed-by: Corey Minyard
>
> Testing:
> TPM I2C device module is tested using SWTPM (software based TPM
> package). Qemu uses the rainier machine and is connected to swtpm over
> the soc
On Fri, Mar 31, 2023 at 12:07:56AM +, Titus Rwantare wrote:
> The ADM1266 can have string fields written by the driver, so
> it's worth specifically testing.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
Acked-by: Corey Minyard
> ---
> tests/
mit adds basic support for its PMBus commands and models
> the identification registers that can be modified in a firmware
> update.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
Looks good.
Acked-by: Corey Minyard
> ---
> hw/arm/Kconfig| 1 +
>
On Fri, Mar 31, 2023 at 12:07:54AM +, Titus Rwantare wrote:
> VCAP is a register for devices with energy storage capacitors.
>
> Reviewed-by: Benjamin Streb
> Signed-off-by: Titus Rwantare
Acked-by: Corey Minyard
> ---
> hw/i2c/pmbus_device.c | 8
On Fri, Mar 31, 2023 at 12:07:53AM +, Titus Rwantare wrote:
> Devices models calling pmbus_send_string can't be relied upon to
> send a non-zero pointer. This logs an error and doesn't segfault.
>
> Reviewed-by: Patrick Venture
> Signed-off-by: Titus Rwantare
ephen Longfield
> Signed-off-by: Titus Rwantare
Acked-by: Corey Minyard
> ---
> hw/i2c/pmbus_device.c | 176 ++
> include/hw/i2c/pmbus_device.h | 1 +
> 2 files changed, 177 insertions(+)
>
> diff --git a/hw/i2c/pmbus_devi
uint16, uint16,
> VID, and Direct modes. VID and Direct modes use the remaining 5 bits
> to scale the voltage readings.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
Ok, I see the new sensor later.
Acked-by: Corey Minyard
> ---
> include/hw/i2c/pmbus_device
gs. Devices can
> respond to a block read with an empty string.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
Acked-by: Corey Minyard
> ---
> hw/i2c/pmbus_device.c | 30 +-
> include/hw/i2c/pmbus_device.h | 7 +++
> 2 file
On Thu, Mar 30, 2023 at 11:20:11AM -0500, Corey Minyard wrote:
> I almost never say this, as patches are usually too large :), but it
> would be nice if you combined this with the patch that uses the
> structure so we can see what it's used for. Especially since that patch
> i
On Wed, Mar 22, 2023 at 05:55:13PM +, Titus Rwantare wrote:
> VCAP is a register for devices with energy storage capacitors.
Acked-by: Corey MInyard
>
> Reviewed-by: Benjamin Streb
> Signed-off-by: Titus Rwantare
> ---
> hw/i2c/pmbus_device.c | 8
On Wed, Mar 22, 2023 at 05:55:12PM +, Titus Rwantare wrote:
> Devices models calling pmbus_send_string can't be relied upon to
> send a non-zero pointer. This logs an error and doesn't segfault.
Yes, a good idea.
Acked-by: Corey Minyard
>
> Reviewed-by: Patrick Ve
Empty description, but the code itself looks ok.
Acked-by: Corey Minyard
On Wed, Mar 22, 2023 at 05:55:11PM +, Titus Rwantare wrote:
> Reviewed-by: Stephen Longfield
> Signed-off-by: Titus Rwantare
> ---
> hw/i2c/pmbus_device.c | 176 +
I almost never say this, as patches are usually too large :), but it
would be nice if you combined this with the patch that uses the
structure so we can see what it's used for. Especially since that patch
is several patches down the line.
-corey
On Wed, Mar 22, 2023 at 05:55:10PM +, Titus Rw
It's generally frowned upon to have empty descriptions, some rationale
would be helpful. For instance, you remove a length check from the send
string, why did you do that?
Any why is this being added? What's it supporting?
-corey
On Wed, Mar 22, 2023 at 05:55:09PM +, Titus Rwantare wrote:
en't done this before, keeping the old
branch and then using "git diff" against it as you break it up in a new
branch will help make sure you haven't changed anything when you break
it up.
-corey
>
> On Sat, Mar 25, 2023 at 4:51 PM Corey Minyard wrote:
>
> > O
On Mon, Mar 27, 2023 at 10:11:50AM -0700, Hao Wu wrote:
> Hi, Cedric
>
> The naming scheme is suggested by Corey in a previous review:
>
> https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg02691.html
>
> I originally kept "IpmIBmc" for the host side code talking to BMC but it
> might also
On Fri, Mar 24, 2023 at 04:08:59PM -0700, Hao Wu wrote:
> From: Havard Skinnemoen
>
> This document is an attempt to briefly document the existing IPMI
> emulation support on the main processor. It provides the necessary
> background for the BMC-side IPMI emulation proposed by the next patch.
>
On Fri, Mar 24, 2023 at 04:09:01PM -0700, Hao Wu wrote:
> This patch refactors the IPMI interface so that it can be used by both
> the BMC side and core-side simulation.
This patch is hard to review because it does so many different things
and they are all mixed up. It looks ok, but it's hard to
On Thu, Mar 23, 2023 at 10:09:02AM +, Karol Nowak wrote:
> Hi,
>
> There is a feature I prepared which may be practical for some QEMU users.
>
> The feature provides a new I2C slave device
> that prepares a message depending what i2c-slave callback was called
> and sends it outside of QEMU th
> behind a bus.
>
> Tested: Verified that by default the device was findable with the name
> 'pca954x[77]', for an instance attached at that address.
This looks good to me.
Acked-by: Corey Minyard
if you are taking this in through another tree. Or do you want me to
take this?
On Wed, Mar 22, 2023 at 10:03:27AM -0700, Patrick Venture wrote:
> On Tue, Mar 21, 2023 at 6:41 PM Corey Minyard wrote:
>
> > On Tue, Mar 21, 2023 at 11:27:44AM -0700, Patrick Venture wrote:
> > > This allows the devices to be more readily found and specified.
> > >
On Tue, Mar 21, 2023 at 11:27:44AM -0700, Patrick Venture wrote:
> This allows the devices to be more readily found and specified.
> Without setting the id field, they can only be found by device type
> name, which doesn't let you specify the second of the same device type
> behind a bus.
So basic
. There's no checking of the
reset type, but there's only one reset type right now, so I guess any
changes due to reset type will have to come when new types come.
Acked-by: Corey Minyard
for another tree, or I can take them.
Thanks,
-corey
>
> Thanks!
> Joe
>
> Jo
On Mon, Feb 27, 2023 at 12:53:23PM +0100, Philippe Mathieu-Daudé wrote:
> On 19/2/23 15:21, Corey Minyard wrote:
> > On Sun, Feb 19, 2023 at 02:45:44PM +0100, Philippe Mathieu-Daudé wrote:
> > > On 18/2/23 21:25, Corey Minyard wrote:
> > > > On Mon, Feb 13, 2023
On Sun, Feb 19, 2023 at 02:45:44PM +0100, Philippe Mathieu-Daudé wrote:
> On 18/2/23 21:25, Corey Minyard wrote:
> > On Mon, Feb 13, 2023 at 06:30:26PM +0100, Bernhard Beschow wrote:
> > > ich9_smb_init() is a legacy init function, so modernize the code.
> > >
>
On Mon, Feb 13, 2023 at 06:30:26PM +0100, Bernhard Beschow wrote:
> ich9_smb_init() is a legacy init function, so modernize the code.
>
> Note that the smb_io_base parameter was unused.
Acked-by: Corey Minyard
>
> Signed-off-by: Bernhard Beschow
> ---
> include/hw/i38
On Mon, Feb 06, 2023 at 07:49:34PM +, Titus Rwantare wrote:
> This is a simple i2c device that allows i2c capable devices to have
> GPIOs.
>
> Reviewed-by: Hao Wu
> Signed-off-by: Titus Rwantare
> ---
> hw/arm/Kconfig | 1 +
> hw/gpio/meson.build | 1 +
> hw
Yes, I agree, I was actually wondering about this reviewing earlier
changes. Thanks for fixing this.
Reviewed-by: Corey Minyard
>
> The current implementation of the at24c EEPROM resets its internal memory on
> reset. This matches the specification in docs/devel/reset.rst:
>
>
t_rom helper to initialize BMC FRUID EEPROM with
> data
> from aspeed_eeprom.c
Reviewed-by: Corey Minyard
>
> wget
> https://github.com/facebook/openbmc/releases/download/openbmc-e2294ff5d31d/fby35.mtd
> qemu-system-aarch64 -machine fby35-bmc -nographic -mtdblock fby35.mtd
&
1 - 100 of 1082 matches
Mail list logo
