Re: [PATCH RESEND] firmware: qemu_fw_cfg: Do not hard depend on CONFIG_HAS_IOPORT_MAP

2025-06-17 Thread kernel test robot
Hi Takashi, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.16-rc2 next-20250617] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [PATCH v4 2/2] cxl: avoid duplicated report from MCE & device

2024-08-09 Thread kernel test robot
Hi Shiyang, kernel test robot noticed the following build warnings: [auto build test WARNING on tip/x86/core] [also build test WARNING on cxl/next linus/master v6.11-rc2 next-20240809] [cannot apply to cxl/pending] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v4 2/2] cxl: avoid duplicated report from MCE & device

2024-08-09 Thread kernel test robot
Hi Shiyang, kernel test robot noticed the following build errors: [auto build test ERROR on tip/x86/core] [also build test ERROR on cxl/next linus/master v6.11-rc2 next-20240809] [cannot apply to cxl/pending] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v4 2/2] cxl: avoid duplicated report from MCE & device

2024-08-09 Thread kernel test robot
Hi Shiyang, kernel test robot noticed the following build errors: [auto build test ERROR on tip/x86/core] [also build test ERROR on cxl/next linus/master v6.11-rc2 next-20240809] [cannot apply to cxl/pending] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v3 2/2] cxl/core: add poison creation event handler

2024-04-21 Thread kernel test robot
Hi Shiyang, kernel test robot noticed the following build errors: [auto build test ERROR on cxl/next] [also build test ERROR on linus/master v6.9-rc4 next-20240419] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

Re: [PATCH 3/3] virtio_balloon: Introduce memory recover

2022-05-20 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/zhenwei-pi/recover-hardware-corrupted-page-by-virtio-balloon/20220520-151328 base: https://git.kernel.org/pub/scm/linux/kernel/git/a

Re: [PATCH 3/3] virtio_balloon: Introduce memory recover

2022-05-20 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/zhenwei-pi/recover-hardware-corrupted-page-by-virtio-balloon/20220520-151328 base: https://git.kernel.org/pub/scm/linux/kernel/git/a

Re: [PATCH 3/3] virtio_balloon: Introduce memory recover

2022-05-20 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/zhenwei-pi/recover-hardware-corrupted-page-by-virtio-balloon/20220520-151328 base: https://git.kernel.org/pub/scm/linux/kerne

[Bug 1915063] Status changed to Confirmed

2021-04-08 Thread Ubuntu Kernel Bot
This change was made by a bot. ** Changed in: linux (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1915063 Title: Windows 10 wil not install using qemu-syst

[Bug 1920784] Status changed to Confirmed

2021-03-23 Thread Ubuntu Kernel Bot
of selected component (if applicable): qemu 5.2.0 Linux kernel 5.11 glibc 2.33 all latest updates as of submitting the bug report How reproducible: Always Steps to Reproduce: 1. Run qemu with kvm acceleration Actual results: Illegal instruction Expected results: Normal

Re: [PATCH 2/5 v4] KVM: SVM: Fill in conforming svm_x86_ops via macro

2020-11-09 Thread kernel test robot
e: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 407ab579637ced6dc32cfb2295afb7259cca4b22 config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/li

[Qemu-devel] [lkp-robot] [fw_cfg] 9f0f3ea314: BUG:KASAN:null-ptr-deref_on_address

2017-05-04 Thread kernel test robot
_fork+0x31/0x40 [ 276.982788] == [ 276.982788] == [ 276.982818] Disabling lock debugging due to kernel taint [ 276.982818] Disabling lock debugging due to ke

[Qemu-devel] [PATCH] libcacard: fix compile error on glib2-2.12.3-4.el5

2014-09-26 Thread zwu . kernel
From: Zhi Yong Wu lt LINK libcacard.la CClibcacard/vscclient.o lt LINK vscclient /usr/bin/ld: -f may not be used without -shared collect2: ld returned 1 exit status make: *** [vscclient] Error 1 Signed-off-by: Zhi Yong Wu --- libcacard/Makefile |3 ++- 1 files changed, 2 insertions(+

[Qemu-devel] [PATCH v2] OVS: update INSTALL.KVM

2013-05-28 Thread zwu . kernel
From: Zhi Yong Wu When i played with OVS again today, i found that the argument of "ovs-dpctl show" is not correct, so INSTALL.KVM need to be updated accordingly. Signed-off-by: Zhi Yong Wu --- INSTALL.KVM |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/INSTALL.KV

[Qemu-devel] [PATCH] net, hub: fix the indent in the comments

2012-12-06 Thread zwu . kernel
From: Zhi Yong Wu Remove some redundant blanks in the comments of net_hub_id_for_client(). Signed-off-by: Zhi Yong Wu --- net/hub.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/hub.c b/net/hub.c index be41301..3b2d1ff 100644 --- a/net/hub.c +++ b/net/hub.c @@

[Qemu-devel] [PATCH v6 06/17] net: Remove vlan qdev property

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature is implemented using hubs and no longer uses special-purpose VLANState structs that are accessible as qdev properties. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/qdev-properties.c | 72 -

[Qemu-devel] [PATCH v6 15/17] net: determine if packets can be sent before net queue deliver packets

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net/queue.c |8 net/slirp.c |7 --- slirp/if.c |5 - slirp/libslirp.h |1 - 4 files changed, 4 insertions(+), 17 deletions(-) diff --git a/net/queue.c b/net/queue.c i

[Qemu-devel] [PATCH v6 09/17] net: Rename non_vlan_clients to net_clients

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Si

[Qemu-devel] [PATCH v6 05/17] net: Drop vlan argument to qemu_new_net_client()

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27

[Qemu-devel] [PATCH v6 01/17] net: Add a hub net client

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature can be implemented in terms of hubs. By introducing a hub net client it becomes possible to remove the special case vlan code from net.c and push the vlan feature out of generic networking code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu -

[Qemu-devel] [PATCH v6 17/17] net: roll back qdev_prop_vlan

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu We're trying to preserve backward compatibility. This command-line break: x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device virtio-net-pci,vlan=1 Instead of dropping the qdev_prop_vlan completely the hw/qdev-properties.c code needs to call net/hub.h external function

[Qemu-devel] [PATCH v6 13/17] net: Make "info network" output more readable info

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu --- net.c | 14 +- net.h |1 + net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 32 insertions(+), 7 deletions(-) diff --git a/net.c b/net.c index e7d49b3..d0be471 10

[Qemu-devel] [PATCH v6 00/17] hub-based networking patchset

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu All comments have been addressed and stefan has completed one more reviewing. For this patchset, my git repo: g...@github.com:wuzhy/qemu.git for-anthony Changelog from v5: 1.) cleanup VLANState in other targets files [anthony] v5: 1.) roll back qdev_prop_vlan [stefanha] v

[Qemu-devel] [PATCH v6 07/17] net: Remove vlan code from net.c

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1

[Qemu-devel] [PATCH v6 12/17] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/e1000.c |2 +- hw/eepr

[Qemu-devel] [PATCH v6 02/17] net: Use hubs for the vlan feature

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi Stop using the special-case vlan code in net.c. Instead use the hub net client to implement the vlan feature. The next patch will remove vlan code from net.c completely. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 38 ++

[Qemu-devel] [PATCH v6 14/17] net: cleanup deliver/deliver_iov func pointers

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net.c | 35 +++ net.h | 11 +++ net/queue.c | 13 - net/queue.h | 17 ++--- 4 files changed, 28 insertions(+), 48 deletions(-) diff

[Qemu-devel] [PATCH v6 03/17] net: Look up 'vlan' net clients using hubs

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 28 +--- net/hub.c | 24 net/hub.h |2 ++ net/slirp.c |5 +++-- 4 files changed, 30 insertions(+), 29 deletions(-) diff --git a/ne

[Qemu-devel] [PATCH v6 16/17] hub: add the support for hub own flow control

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu Only when all other hub port's *peer* .can_receive() all return 1, the source hub port .can_receive() return 1. Reviewed-off-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net/hub.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v6 04/17] hub: Check that hubs are configured correctly

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks perfo

[Qemu-devel] [PATCH v6 11/17] net: Rename vc local variables to nc

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/ne2000.h |

[Qemu-devel] [PATCH v6 08/17] net: Remove VLANState

2012-06-20 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/dp8393x.c|1 - hw/exynos4_boards.c |2 +- hw/highbank.c |2 +- hw/integratorcp.c |2 +- hw/mcf5208.c|2 +- hw/mcf_

[Qemu-devel] [PATCH v2 3/3] net: complete NetSocketState lifecycle handling

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu The NetSocketState struct contains two file descriptors: an active connection and a listen socket for new connections. It's important that we clean up after ourselves so these file descriptors are initialized to -1 when unused. This allows makes it possible to call cleanup fun

[Qemu-devel] [PATCH v2 0/3] Some socket fix patches

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu The patchset is on top of hub-based networking patchset. For this patchset, my git repo: g...@github.com:wuzhy/qemu.git for-anthony Zhi Yong Wu (3): net: fix the coding style net: add the support for -netdev socket, listen net: complete NetSocketState lifecycle handling

[Qemu-devel] [PATCH v2 2/3] net: add the support for -netdev socket, listen

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will also provide the support. S

[Qemu-devel] [PATCH v2 1/3] net: fix the coding style

2012-06-20 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/socket.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/socket.c b/net/socket.c index dc5ba40..ba8583f 100644 --- a/net/socket.c +++ b/net/socket.c @@ -301,7 +301,9 @@ static NetSocketState *net_socket_fd_ini

[Qemu-devel] [PATCH 08/17] net: Remove VLANState

2012-06-19 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/dp8393x.c|1 - hw/exynos4_boards.c |2 +- hw/highbank.c |2 +- hw/integratorcp.c |2 +- hw/mcf5208.c|2 +- hw/mcf_

[Qemu-devel] [PATCH v5 06/17] net: Remove vlan qdev property

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature is implemented using hubs and no longer uses special-purpose VLANState structs that are accessible as qdev properties. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/qdev-properties.c | 72 -

[Qemu-devel] [PATCH v5 15/17] net: determine if packets can be sent before net queue deliver packets

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net/queue.c |8 net/slirp.c |7 --- slirp/if.c |5 - slirp/libslirp.h |1 - 4 files changed, 4 insertions(+), 17 deletions(-) diff --git a/net/queue.c b/net/queue.c i

[Qemu-devel] [PATCH v5 02/17] net: Use hubs for the vlan feature

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Stop using the special-case vlan code in net.c. Instead use the hub net client to implement the vlan feature. The next patch will remove vlan code from net.c completely. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 38 ++

[Qemu-devel] [PATCH v5 17/17] net: roll back qdev_prop_vlan

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu We're trying to preserve backward compatibility. This command-line break: x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device virtio-net-pci,vlan=1 Instead of dropping the qdev_prop_vlan completely the hw/qdev-properties.c code needs to call net/hub.h external function

[Qemu-devel] [PATCH v5 14/17] net: cleanup deliver/deliver_iov func pointers

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net.c | 35 +++ net.h | 11 +++ net/queue.c | 13 - net/queue.h | 17 ++--- 4 files changed, 28 insertions(+), 48 deletions(-) diff

[Qemu-devel] [PATCH v5 05/17] net: Drop vlan argument to qemu_new_net_client()

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27

[Qemu-devel] [PATCH v5 09/17] net: Rename non_vlan_clients to net_clients

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Si

[Qemu-devel] [PATCH 3/3] net: complete NetSocketState lifecycle handling

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu The NetSocketState struct contains two file descriptors: an active connection and a listen socket for new connections. It's important that we clean up after ourselves so these file descriptors are initialized to -1 when unused. This allows makes it possible to call cleanup fun

[Qemu-devel] [PATCH 3/3] net: complete NetSocketS?tate lifecycle handling

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu The NetSocketState struct contains two file descriptors: an active connection and a listen socket for new connections. It's important that we clean up after ourselves so these file descriptors are initialized to -1 when unused. This allows makes it possible to call cleanup fun

[Qemu-devel] [PATCH 0/3] Some socket fix patches

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu The patchset is on top of hub-based networking patchset. Zhi Yong Wu (3): net: fix the coding style net: add the support for -netdev socket, listen net: complete NetSocketState lifecycle handling net/socket.c | 82 +++---

[Qemu-devel] [PATCH 1/3] net: fix the coding style

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/socket.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/socket.c b/net/socket.c index dc5ba40..ba8583f 100644 --- a/net/socket.c +++ b/net/socket.c @@ -301,7 +301,9 @@ static NetSocketState *net_socket_fd_ini

[Qemu-devel] [PATCH 2/3] net: add the support for -netdev socket, listen

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will also provide the support. S

[Qemu-devel] [PATCH v5 16/17] hub: add the support for hub own flow control

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Only when all other hub port's *peer* .can_receive() all return 1, the source hub port .can_receive() return 1. Reviewed-off-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net/hub.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v5 13/17] net: Make "info network" output more readable info

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu --- net.c | 14 +- net.h |1 + net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 32 insertions(+), 7 deletions(-) diff --git a/net.c b/net.c index e7d49b3..d0be471 10

[Qemu-devel] [PATCH v5 11/17] net: Rename vc local variables to nc

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/ne2000.h |

[Qemu-devel] [PATCH v5 04/17] hub: Check that hubs are configured correctly

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks perfo

[Qemu-devel] [PATCH v5 12/17] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/e1000.c |2 +- hw/eepr

[Qemu-devel] [PATCH v5 08/17] net: Remove VLANState

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 127 ++--- net.h |8 net/socket.c |6 +- net/tap.c |6 +- net/

[Qemu-devel] [PATCH v5 07/17] net: Remove vlan code from net.c

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1

[Qemu-devel] [PATCH v5 03/17] net: Look up 'vlan' net clients using hubs

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 28 +--- net/hub.c | 24 net/hub.h |2 ++ net/slirp.c |5 +++-- 4 files changed, 30 insertions(+), 29 deletions(-) diff --git a/ne

[Qemu-devel] [PATCH v5 01/17] net: Add a hub net client

2012-06-18 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature can be implemented in terms of hubs. By introducing a hub net client it becomes possible to remove the special case vlan code from net.c and push the vlan feature out of generic networking code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu -

[Qemu-devel] [PATCH v5 00/17] hub-based networking patches

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu All comments have been addressed and stefan has completed one more reviewing. Changelog from v4: 1.) roll back qdev_prop_vlan [stefanha] v4: 1.) refactor hub own flow control [paolo] 2.) refactor the output for monitor command "info network" [jan kiszka] v3: 1.) add the s

[Qemu-devel] [PATCH v2] net: roll back qdev_prop_vlan

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu We're trying to preserve backward compatibility. This command-line break: x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device virtio-net-pci,vlan=1 Instead of dropping the qdev_prop_vlan completely the hw/qdev-properties.c code needs to call net/hub.h external function

[Qemu-devel] [PATCH] net: roll back qdev_prop_vlan

2012-06-16 Thread zwu . kernel
From: Zhi Yong Wu We're trying to preserve backward compatibility. This command-line break: x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device virtio-net-pci,vlan=1 Instead of dropping the qdev_prop_vlan completely the hw/qdev-properties.c code needs to call net/hub.h external function

[Qemu-devel] [PATCH v6 2/2] net: add the support for -netdev socket, listen

2012-06-11 Thread zwu . kernel
From: Zhi Yong Wu The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will also provide the support. S

[Qemu-devel] [PATCH v6 1/2] net: fix the coding style

2012-06-11 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/socket.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/socket.c b/net/socket.c index fcd0a3c..7194345 100644 --- a/net/socket.c +++ b/net/socket.c @@ -301,7 +301,9 @@ static NetSocketState *net_socket_fd_init

[Qemu-devel] [PATCH v5 2/2] net: add the support for -netdev socket, listen

2012-06-07 Thread zwu . kernel
From: Zhi Yong Wu The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will also provide the support. S

[Qemu-devel] [PATCH v5 1/2] net: fix the coding style

2012-06-07 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/socket.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/net/socket.c b/net/socket.c index fcd0a3c..7194345 100644 --- a/net/socket.c +++ b/net/socket.c @@ -301,7 +301,9 @@ static NetSocketState *net_socket_fd_init

[Qemu-devel] [PATCH v4] net: add the support for -netdev socket, listen

2012-06-06 Thread zwu . kernel
From: Zhi Yong Wu The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will also provide the support. S

[Qemu-devel] [PATCH v3] net: add the support for -netdev socket, listen

2012-06-04 Thread zwu . kernel
From: Zhi Yong Wu The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will also provide the support. S

[Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-06-04 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu --- net.c | 14 +- net.h |1 + net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 32 insertions(+), 7 deletions(-) diff --git a/net.c b/net.c index 61dc28d..6cedc7a 10

[Qemu-devel] [PATCH v4 12/16] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-06-04 Thread zwu . kernel
From: Stefan Hajnoczi Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/e1000.c |2 +- hw/eepr

[Qemu-devel] [PATCH v4 08/16] net: Remove VLANState

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 127 ++--- net.h |8 net/socket.c |6 +- net/tap.c |6 +- net/

[Qemu-devel] [PATCH v4 11/16] net: Rename vc local variables to nc

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/ne2000.h |

[Qemu-devel] [PATCH v4 09/16] net: Rename non_vlan_clients to net_clients

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Si

[Qemu-devel] [PATCH v4 06/16] net: Remove vlan qdev property

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature is implemented using hubs and no longer uses special-purpose VLANState structs that are accessible as qdev properties. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/qdev-properties.c | 72 -

[Qemu-devel] [PATCH v4 07/16] net: Remove vlan code from net.c

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1

[Qemu-devel] [PATCH v4 16/16] hub: add the support for hub own flow control

2012-06-03 Thread zwu . kernel
From: Zhi Yong Wu Only when all other hub port's *peer* .can_receive() all return 1, the source hub port .can_receive() return 1. Reviewed-off-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net/hub.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v4 14/16] net: cleanup deliver/deliver_iov func pointers

2012-06-03 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net.c | 35 +++ net.h | 11 +++ net/queue.c | 13 - net/queue.h | 17 ++--- 4 files changed, 28 insertions(+), 48 deletions(-) diff

[Qemu-devel] [PATCH v4 04/16] hub: Check that hubs are configured correctly

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks perfo

[Qemu-devel] [PATCH v4 01/16] net: Add a hub net client

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature can be implemented in terms of hubs. By introducing a hub net client it becomes possible to remove the special case vlan code from net.c and push the vlan feature out of generic networking code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu -

[Qemu-devel] [PATCH v4 15/16] net: determine if packets can be sent before net queue deliver packets

2012-06-03 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu --- net/queue.c |8 net/slirp.c |7 --- slirp/if.c |5 - slirp/libslirp.h |1 - 4 files changed, 4 insertions(+), 17 deletions(-) diff --git a/net/queue.c b/net/queue.c i

[Qemu-devel] [PATCH v4 05/16] net: Drop vlan argument to qemu_new_net_client()

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27

[Qemu-devel] [PATCH v4 03/16] net: Look up 'vlan' net clients using hubs

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 28 +--- net/hub.c | 24 net/hub.h |2 ++ net/slirp.c |5 +++-- 4 files changed, 30 insertions(+), 29 deletions(-) diff --git a/ne

[Qemu-devel] [PATCH v4 02/16] net: Use hubs for the vlan feature

2012-06-03 Thread zwu . kernel
From: Stefan Hajnoczi Stop using the special-case vlan code in net.c. Instead use the hub net client to implement the vlan feature. The next patch will remove vlan code from net.c completely. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 46 ++

[Qemu-devel] [PATCH v4 00/16] hub-based networking patches

2012-06-03 Thread zwu . kernel
From: Zhi Yong Wu All comments from other guys were addressed. The following changes since commit a854972f8cdec0148087789d62777d8f7176933d: Update version to open the 1.2 development branch (Fri Jun 1 16:56:16 2012 +0800) are available in the git repository at: g...@github.com:wuzhy/qemu.g

[Qemu-devel] [PULL 1.2 00/16] hub-based networking patches

2012-06-03 Thread zwu . kernel
From: Zhi Yong Wu All comments from other guys were addressed. The following changes since commit a854972f8cdec0148087789d62777d8f7176933d: Update version to open the 1.2 development branch (Fri Jun 1 16:56:16 2012 +0800) are available in the git repository at: g...@github.com:wuzhy/qemu.g

[Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu --- net.c | 18 ++ net.h |1 + net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 37 insertions(+), 6 deletions(-) diff --git a/net.c b/net.c index 61dc28d..ae0dee

[Qemu-devel] [PATCH v4 13/16] net: Make "info network" output more readable info

2012-05-25 Thread zwu . kernel
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu --- net.c | 18 ++ net.h | 12 net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 48 insertions(+), 6 deletions(-) diff --git a/net.c b/net.c index 61dc

[Qemu-devel] [PATCH v4 16/16] hub: add the support for hub own flow control

2012-05-25 Thread zwu . kernel
From: Zhi Yong Wu Only when all other hub port's *peer* .can_receive() all return 1, the source hub port .can_receive() return 1. Signed-off-by: Zhi Yong Wu --- net/hub.c | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/net/hub.c b/net/hub.c

[Qemu-devel] [PATCH v3 05/16] net: Drop vlan argument to qemu_new_net_client()

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27

[Qemu-devel] [PATCH v3 06/16] net: Remove vlan qdev property

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi The vlan feature is implemented using hubs and no longer uses special-purpose VLANState structs that are accessible as qdev properties. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/qdev-properties.c | 72 -

[Qemu-devel] [PATCH v3 03/16] net: Look up 'vlan' net clients using hubs

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 28 +--- net/hub.c | 24 net/hub.h |2 ++ net/slirp.c |5 +++-- 4 files changed, 30 insertions(+), 29 deletions(-) diff --git a/ne

[Qemu-devel] [PATCH v3 11/16] net: Rename vc local variables to nc

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/ne2000.h |

[Qemu-devel] [PATCH v3 14/16] net: cleanup deliver/deliver_iov func pointers

2012-05-24 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net.c | 35 +++ net.h | 11 +++ net/queue.c | 13 - net/queue.h | 17 ++--- 4 files changed, 28 insertions(+), 48 deletions(-) diff --git a/net.c b/net.c index 7

[Qemu-devel] [PATCH v3 13/16] net: Make the monitor output more reasonable hub info

2012-05-24 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net.c |7 ++- net/hub.c |2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/net.c b/net.c index 61dc28d..79ac51f 100644 --- a/net.c +++ b/net.c @@ -887,6 +887,12 @@ static const struct { }, }, #end

[Qemu-devel] [PATCH v3 15/16] net: determine if packets can be sent before net queue deliver packets

2012-05-24 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/queue.c |8 net/slirp.c |7 --- slirp/if.c |5 - slirp/libslirp.h |1 - 4 files changed, 4 insertions(+), 17 deletions(-) diff --git a/net/queue.c b/net/queue.c index 0afd783..7484d2a 100644 -

[Qemu-devel] [PATCH v3 16/16] hub: add the support for hub own flow control

2012-05-24 Thread zwu . kernel
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu --- net/hub.c | 35 --- net/hub.h |2 ++ net/queue.c |5 + 3 files changed, 39 insertions(+), 3 deletions(-) diff --git a/net/hub.c b/net/hub.c index 8a583ab..d27c52a 100644 --- a/net/hub.c +++ b/net

[Qemu-devel] [PATCH v3 12/16] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/e1000.c |2 +- hw/eepr

[Qemu-devel] [PATCH v3 08/16] net: Remove VLANState

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 127 ++--- net.h |8 net/socket.c |6 +- net/tap.c |6 +- net/

[Qemu-devel] [PATCH v3 09/16] net: Rename non_vlan_clients to net_clients

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Si

[Qemu-devel] [PATCH v3 07/16] net: Remove vlan code from net.c

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1

[Qemu-devel] [PATCH v3 04/16] hub: Check that hubs are configured correctly

2012-05-24 Thread zwu . kernel
From: Stefan Hajnoczi Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks perfo

  1   2   >