Re: [PATCH 1/1] target/riscv: log guest errors when reserved bits are set in PTEs

2025-02-02 Thread Julia
errors, it builds on 32 & 64 bit on my system. Cheers As for the Signed-off-by, I'd rather not, and the contributing guide does not require it. Regards, Julia

[PATCH v2 1/1] target/riscv: log guest errors when reserved bits are set in PTEs

2025-02-02 Thread julia
future, incorrectly set up page tables can be debugged without bisecting QEMU. Signed-off-by: julia --- target/riscv/cpu_helper.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index e1dfc4ecbf

[PATCH 1/1] target/riscv: log guest errors when reserved bits are set in PTEs

2025-02-01 Thread julia
future, incorrectly set up page tables can be debugged without bisecting QEMU. Signed-off-by: julia --- target/riscv/cpu_helper.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index e1dfc4ecbf

[PATCH 0/1] -----BEGIN SSH SIGNATURE-----

2025-02-01 Thread julia
fY3jfRbpdO9l1l2wwDZ2l0AAZzaGE1MTIAAABTC3NzaC1lZDI1NTE5 QP6c2B82m4kq6h046Ou/LV6c9I/D/uUtUlivmbvR/lSdCWOiPIYnpK5HPtvhcgVYoQ 8X1k8kKjplch4iy6JnNgU= -END SSH SIGNATURE- julia (1): target/riscv: log guest errors when reserved bits are set in PTEs target/riscv

[PATCH 0/3] Support getting p2pdma_distance

2024-12-07 Thread Julia Zhang
. This series is to support handling the new virtgpu command from the guest VM to get the physical p2pdma_distance of two PCI devices of guest VM. Julia Zhang (3): virtio-gpu: set hostaddr for virtio iGPU pci: introduce a function to get PCIDevice virtio-gpu: add a new command to calculate

[PATCH 3/3] virtio-gpu: add a new command to get p2pdma_distance

2024-12-07 Thread Julia Zhang
To implement passthrough dGPU prime in guest, virtio-gpu need to check p2pdma_distance of two GPUs. This adds a new command for guest to pass virtual pci notations of two pci devices to host and send xen privcmd to calculate physical p2pdma_distance. Signed-off-by: Julia Zhang --- hw/display

[PATCH 2/3] pci: introduce a function to get PCIDevice

2024-12-07 Thread Julia Zhang
Introduce a helper function to get PCIDevice from qdev pci notation. Signed-off-by: Julia Zhang --- hw/pci/pci.c | 22 ++ include/hw/pci/pci.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 1416ae202c..95806ead4f 100644

[PATCH 1/3] virtio-gpu: set hostaddr for virtio iGPU

2024-12-07 Thread Julia Zhang
Get physical pci notation from hvm file and set hostaddr for virtio iGPU. Signed-off-by: Julia Zhang --- hw/display/virtio-gpu.c| 6 ++ hw/xen/xen_pt.c| 10 +- hw/xen/xen_pt.h| 1 - include/hw/pci/pci_device.h| 1 + include/hw/virtio

Re: [PATCH] hw/nvme: Remove references to PCI IRQ "pulsing" when asserting

2024-10-17 Thread Julia
, or just leave it to the standard PCI IRQ traces. Julia On Tue, 15 Oct 2024, at 21:33, julia wrote: > The NVMe subsystem logs "pulsing IRQ pin" when it is asserting the PCI(e) > IRQ. This is confusing as it implies a short pulse, not the level-triggered > interrupt

[PATCH] hw/nvme: Remove references to PCI IRQ "pulsing" when asserting

2024-10-15 Thread julia
The NVMe subsystem logs "pulsing IRQ pin" when it is asserting the PCI(e) IRQ. This is confusing as it implies a short pulse, not the level-triggered interrupts PCI(e) uses. Also remove the pci_irq_pulse() function marked with FIXME as it is no longer used by any calls. Signed-off

[PATCH v2 1/2] kvm: Allow kvm_arch_get/put_registers to accept Error**

2024-09-27 Thread Julia Suvorova
This is necessary to provide discernible error messages to the caller. Signed-off-by: Julia Suvorova Reviewed-by: Peter Xu --- accel/kvm/kvm-all.c| 41 +- include/sysemu/kvm.h | 4 ++-- target/arm/kvm.c | 4 ++-- target/i386/kvm

[PATCH v2 0/2] kvm: Improve register failure reports for migration

2024-09-27 Thread Julia Suvorova
. [1] https://issues.redhat.com/browse/RHEL-7558 [2] 7191f24c7fcf "accel/kvm/kvm-all: Handle register access errors" -- v2: * made all reports as error_reportf_err() and fixed prefixes [Peter] Julia Suvorova (2): kvm: Allow kvm_arch_get/put_registers to accept Error** targe

[PATCH v2 2/2] target/i386/kvm: Report which action failed in kvm_arch_put/get_registers

2024-09-27 Thread Julia Suvorova
: Julia Suvorova Reviewed-by: Peter Xu --- target/i386/kvm/kvm.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 039ed08825..7cdc87f855 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5133,6 +5133,7

Re: [PATCH 1/2] kvm: Allow kvm_arch_get/put_registers to accept Error**

2024-09-26 Thread Julia Suvorova
On Wed, Sep 25, 2024 at 8:53 PM Peter Xu wrote: > > On Wed, Sep 25, 2024 at 05:36:22PM +0200, Julia Suvorova wrote: > > This is necessary to provide discernible error messages to the caller. > > > > Signed-off-by: Julia Suvorova > > Reviewed-by: P

[PATCH 2/2] target/i386/kvm: Report which action failed in kvm_arch_put/get_registers

2024-09-25 Thread Julia Suvorova
: Julia Suvorova --- target/i386/kvm/kvm.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 039ed08825..7cdc87f855 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5133,6 +5133,7 @@ int

[PATCH 0/2] kvm: Improve register failure reports for migration

2024-09-25 Thread Julia Suvorova
. [1] https://issues.redhat.com/browse/RHEL-7558 [2] 7191f24c7fcf "accel/kvm/kvm-all: Handle register access errors" Julia Suvorova (2): kvm: Allow kvm_arch_get/put_registers to accept Error** target/i386/kvm: Report which action failed in kvm_arch_put/get_registers accel/kvm

[PATCH 1/2] kvm: Allow kvm_arch_get/put_registers to accept Error**

2024-09-25 Thread Julia Suvorova
This is necessary to provide discernible error messages to the caller. Signed-off-by: Julia Suvorova --- accel/kvm/kvm-all.c| 41 +- include/sysemu/kvm.h | 4 ++-- target/arm/kvm.c | 4 ++-- target/i386/kvm/kvm.c | 4

[PATCH v2 0/1] Implementation of resource_query_layout

2023-12-21 Thread Julia Zhang
Hi all, Sorry to late reply. This is v2 of the implementation of resource_query_layout. This adds a new ioctl to let guest query information of host resource, which is originally from Daniel Stone. We add some changes to support query the correct stride of host resource before it's created, which

[PATCH v2 1/1] virgl: Implement resource_query_layout

2023-12-21 Thread Julia Zhang
From: Daniel Stone A new ioctl to shuttle information between host and guest about the actual buffer allocation, which can be used for interop between GL and Vulkan when supporting standard window systems. Signed-off-by: Daniel Stone Co-developed-by: Julia Zhang Signed-off-by: Julia Zhang

[PATCH 1/2] virgl: Implement resource_query_layout

2023-11-10 Thread Julia Zhang
From: Daniel Stone A new ioctl to shuttle information between host and guest about the actual buffer allocation, which can be used for interop between GL and Vulkan when supporting standard window systems. --- hw/display/virtio-gpu-base.c| 4 ++ hw/display/virtio-gpu-virgl.c

[PATCH 2/2] virgl: Modify resource_query_layout

2023-11-10 Thread Julia Zhang
Modify resource_query_layout to handle the use case that need to query correct stride for guest linear resource before it is created. Signed-off-by: Julia Zhang --- hw/display/virtio-gpu-virgl.c | 20 +++- include/standard-headers/linux/virtio_gpu.h | 8

[PATCH 0/2] Implementation of resource_query_layout

2023-11-10 Thread Julia Zhang
/-/merge_requests/23896 virglrenderer mr: https: //gitlab.freedesktop.org/virgl/virglrenderer/-/merge_requests/1268 Daniel Stone (1): virgl: Implement resource_query_layout Julia Zhang (1): virgl: Modify resource_query_layout hw/display/virtio-gpu-base.c| 4 +++ hw/display/virtio-gpu

Re: [PATCH v2 5/5] hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port

2023-06-23 Thread Julia Suvorova
On Thu, Jun 22, 2023 at 7:48 PM Michael S. Tsirkin wrote: > > On Thu, Jun 22, 2023 at 05:46:40PM +0200, Julia Suvorova wrote: > > On Thu, Jun 22, 2023 at 12:34 PM Ani Sinha wrote: > > > > > > PCI Express ports only have one slot, so PCI Express devices can only be

Re: [PATCH v1 02/23] pc/q35: Apply PCI bus BSEL property for Xen PCI device hotplug

2023-06-22 Thread Julia Suvorova
gt; > > > I make use of the find_q35() function in later patches, but I agree now a > > majority of this patch is a bit different. > > There is likely an existing alternative already. (probably introduced by ACPI > PIC hotplug for q35) There is a similar function acpi_get_

Re: [PATCH v2 5/5] hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port

2023-06-22 Thread Julia Suvorova
; +error_setg(errp, "PCI: slot %d is not valid for %s," > + " PCI express devices can only be plugged into slot 0.", This is not technically correct, because downstream ports and root ports are also PCIe devices, and they can have di

[PATCH v2] hw/smbios: fix field corruption in type 4 table

2023-02-23 Thread Julia Suvorova
: add core_count2 to smbios table type 4") Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2169904 Signed-off-by: Julia Suvorova --- v2: * add fixes tag * check tbl_len instead of ep_type hw/smbios/smbios.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a

[PATCH] hw/smbios: fix field corruption in type 4 table

2023-02-22 Thread Julia Suvorova
/show_bug.cgi?id=2169904 Signed-off-by: Julia Suvorova --- hw/smbios/smbios.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index b4243de735..903fd22350 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -749,14 +749,16

[PATCH v2] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-10-23 Thread Julia Suvorova
ng Structure "NVDIMM State Flags" Bit 3 Fixes: dbd730e859 ("nvdimm: check -object memory-backend-file, readonly=on option") Signed-off-by: Julia Suvorova Reviewed-by: Stefan Hajnoczi Reviewed-by: Pankaj Gupta Reviewed-by: Philippe Mathieu-Daudé Acked-by: David Hildenbrand --

Re: [RESEND PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-10-19 Thread Julia Suvorova
On Tue, Oct 18, 2022 at 6:49 PM Michael S. Tsirkin wrote: > > On Tue, Oct 18, 2022 at 06:17:55PM +0200, Philippe Mathieu-Daudé wrote: > > On 18/10/22 17:25, Julia Suvorova wrote: > > > In the ACPI specification [1], the 'unarmed' bit is set when a device > &g

[RESEND PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-10-18 Thread Julia Suvorova
ng Structure "NVDIMM State Flags" Bit 3 Signed-off-by: Julia Suvorova Reviewed-by: Stefan Hajnoczi --- hw/mem/nvdimm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 7c7d81..bfb76818c1 100644 --- a/hw/mem/nvdimm.c +++ b/hw

[PATCH v3 0/5] hw/smbios: add core_count2 to smbios table type 4

2022-10-11 Thread Julia Suvorova
on of the structure loop [Ani] Julia Suvorova (5): hw/smbios: add core_count2 to smbios table type 4 bios-tables-test: teach test to use smbios 3.0 tables tests/acpi: allow changes for core_count2 test bios-tables-test: add test for number of cores > 255 tests/acpi: update tables for

[PATCH v3 4/5] bios-tables-test: add test for number of cores > 255

2022-10-11 Thread Julia Suvorova
The new test is run with a large number of cpus and checks if the core_count field in smbios_cpu_test (structure type 4) is correct. Choose q35 as it allows to run with -smp > 255. Signed-off-by: Julia Suvorova Message-Id: <20220731162141.178443-5-jus...@redhat.com> --- tests/qtest/bi

[PATCH v3 2/5] bios-tables-test: teach test to use smbios 3.0 tables

2022-10-11 Thread Julia Suvorova
Introduce the 64-bit entry point. Since we no longer have a total number of structures, stop checking for the new ones at the EOF structure (type 127). Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov Message-Id: <20220731162141.178443-3-jus...@redhat.com> --- tests/qtest/bios-

[PATCH v3 5/5] tests/acpi: update tables for new core count test

2022-10-11 Thread Julia Suvorova
_OST: OSPM Status Indication +{ +COST (0xFF, Arg0, Arg1, Arg2) +} +} + ... Signed-off-by: Julia Suvorova Message-Id: <20220731162141.178443-6-jus...@redhat.com> --- tests/data/acpi/q35/APIC.core-count2| Bin 0 -> 2478 byt

[PATCH v3 3/5] tests/acpi: allow changes for core_count2 test

2022-10-11 Thread Julia Suvorova
Signed-off-by: Julia Suvorova Message-Id: <20220731162141.178443-4-jus...@redhat.com> --- tests/data/acpi/q35/APIC.core-count2| 0 tests/data/acpi/q35/DSDT.core-count2| 0 tests/data/acpi/q35/FACP.core-count2| 0 tests/qtest/bios-tables-test-allowed-diff.h | 3

[PATCH v3 1/5] hw/smbios: add core_count2 to smbios table type 4

2022-10-11 Thread Julia Suvorova
. core_enabled2 and thread_count2 fields work the same way. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov Message-Id: <20220731162141.178443-2-jus...@redhat.com> --- hw/smbios/smbios.c | 19 --- hw/smbios/smbios_build.h | 9 +++-- include/hw/fi

[PATCH v2 3/5] tests/acpi: allow changes for core_count2 test

2022-07-31 Thread Julia Suvorova
Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ tests/data/acpi/q35/APIC.core-count2| 0 tests/data/acpi/q35/DSDT.core-count2| 0 tests/data/acpi/q35/FACP.core-count2| 0 4 files changed, 3 insertions(+) create mode 100644 tests

[PATCH v2 2/5] bios-tables-test: teach test to use smbios 3.0 tables

2022-07-31 Thread Julia Suvorova
Introduce the 64-bit entry point. Since we no longer have a total number of structures, stop checking for the new ones at the EOF structure (type 127). Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test.c | 95 +- 1 file changed, 71 insertions(+), 24

[PATCH v2 4/5] bios-tables-test: add test for number of cores > 255

2022-07-31 Thread Julia Suvorova
The new test is run with a large number of cpus and checks if the core_count field in smbios_cpu_test (structure type 4) is correct. Choose q35 as it allows to run with -smp > 255. Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test.c | 53 +- 1 f

[PATCH v2 5/5] tests/acpi: update tables for new core count test

2022-07-31 Thread Julia Suvorova
_OST: OSPM Status Indication +{ +COST (0xFF, Arg0, Arg1, Arg2) +} +} + ... Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 3 --- tests/data/acpi/q35/APIC.core-count2| Bin 0 -> 2478 bytes te

[PATCH v2 0/5] hw/smbios: add core_count2 to smbios table type 4

2022-07-31 Thread Julia Suvorova
ad of creating new constants * refactor smbios_cpu_test [Igor, Ani] * clarify signature check [Igor] * add comments with specifications and clarification of the structure loop [Ani] Julia Suvorova (5): hw/smbios: add core_count2 to smbios table type 4 bios-tables-test: teach test t

[PATCH v2 1/5] hw/smbios: add core_count2 to smbios table type 4

2022-07-31 Thread Julia Suvorova
. core_enabled2 and thread_count2 fields work the same way. Signed-off-by: Julia Suvorova --- hw/smbios/smbios_build.h | 9 +++-- include/hw/firmware/smbios.h | 11 +++ hw/smbios/smbios.c | 18 +++--- 3 files changed, 33 insertions(+), 5 deletions(-) diff

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-14 Thread Julia Suvorova
On Tue, Jun 14, 2022 at 11:50 AM David Hildenbrand wrote: > > On 14.06.22 10:54, Igor Mammedov wrote: > > On Mon, 13 Jun 2022 16:09:53 +0100 > > Stefan Hajnoczi wrote: > > > >> On Mon, Jun 13, 2022 at 05:01:10PM +0200, Julia Suvorova wrote: > >>> On

Re: [PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-06-13 Thread Julia Suvorova
On Tue, May 31, 2022 at 5:32 PM Stefan Hajnoczi wrote: > > On Tue, May 31, 2022 at 04:51:47PM +0200, Julia Suvorova wrote: > > In the ACPI specification [1], the 'unarmed' bit is set when a device > > cannot accept a persistent write. This means that when a memdev is

Re: [PATCH 4/5] bios-tables-test: add test for number of cores > 255

2022-06-06 Thread Julia Suvorova
On Thu, Jun 2, 2022 at 5:20 PM Igor Mammedov wrote: > > On Fri, 27 May 2022 18:56:50 +0200 > Julia Suvorova wrote: > > > The new test is run with a large number of cpus and checks if the > > core_count field in smbios_cpu_test (structure type 4) is correct. > > >

Re: [PATCH 1/5] hw/smbios: add core_count2 to smbios table type 4

2022-06-06 Thread Julia Suvorova
On Thu, Jun 2, 2022 at 4:35 PM Igor Mammedov wrote: > > On Thu, 2 Jun 2022 16:31:25 +0200 > Igor Mammedov wrote: > > > On Tue, 31 May 2022 14:40:15 +0200 > > Julia Suvorova wrote: > > > > > On Sat, May 28, 2022 at 6:34 AM Ani Sinha wrote: > > &g

Re: [PATCH 2/5] bios-tables-test: teach test to use smbios 3.0 tables

2022-06-06 Thread Julia Suvorova
On Thu, Jun 2, 2022 at 5:04 PM Igor Mammedov wrote: > > On Fri, 27 May 2022 18:56:48 +0200 > Julia Suvorova wrote: > > > Introduce the 64-bit entry point. Since we no longer have a total > > number of structures, stop checking for the new ones at the EOF > > struct

Re: [PATCH 4/5] bios-tables-test: add test for number of cores > 255

2022-05-31 Thread Julia Suvorova
On Tue, May 31, 2022 at 3:14 PM Ani Sinha wrote: > > On Tue, May 31, 2022 at 5:53 PM Julia Suvorova wrote: > > > > On Sat, May 28, 2022 at 7:22 AM Ani Sinha wrote: > > > > > > > > > > > > On Fri, 27 May 2022, Julia Suvorova wrote: > &g

[PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

2022-05-31 Thread Julia Suvorova
ng Structure "NVDIMM State Flags" Bit 3 Signed-off-by: Julia Suvorova --- hw/mem/nvdimm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 7c7d81..bfb76818c1 100644 --- a/hw/mem/nvdimm.c +++ b/hw/mem/nvdimm.c @

Re: [PATCH 1/5] hw/smbios: add core_count2 to smbios table type 4

2022-05-31 Thread Julia Suvorova
On Sat, May 28, 2022 at 6:34 AM Ani Sinha wrote: > > > > On Fri, 27 May 2022, Julia Suvorova wrote: > > > In order to use the increased number of cpus, we need to bring smbios > > tables in line with the SMBIOS 3.0 specification. This allows us to > > intr

Re: [PATCH 4/5] bios-tables-test: add test for number of cores > 255

2022-05-31 Thread Julia Suvorova
On Sat, May 28, 2022 at 7:22 AM Ani Sinha wrote: > > > > On Fri, 27 May 2022, Julia Suvorova wrote: > > > The new test is run with a large number of cpus and checks if the > > core_count field in smbios_cpu_test (structure type 4) is correct. > > > > Choose

Re: [PATCH 2/5] bios-tables-test: teach test to use smbios 3.0 tables

2022-05-31 Thread Julia Suvorova
On Mon, May 30, 2022 at 8:11 AM Ani Sinha wrote: > > On Fri, May 27, 2022 at 10:27 PM Julia Suvorova wrote: > > > > Introduce the 64-bit entry point. Since we no longer have a total > > number of structures, stop checking for the new ones at the EOF > > structure

[PATCH 4/5] bios-tables-test: add test for number of cores > 255

2022-05-27 Thread Julia Suvorova
The new test is run with a large number of cpus and checks if the core_count field in smbios_cpu_test (structure type 4) is correct. Choose q35 as it allows to run with -smp > 255. Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test.c | 35 +- 1 f

[PATCH 3/5] tests/acpi: allow changes for core_count2 test

2022-05-27 Thread Julia Suvorova
Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 3 +++ tests/data/acpi/q35/APIC.core-count2| 0 tests/data/acpi/q35/DSDT.core-count2| 0 tests/data/acpi/q35/FACP.core-count2| 0 4 files changed, 3 insertions(+) create mode 100644 tests

[PATCH 2/5] bios-tables-test: teach test to use smbios 3.0 tables

2022-05-27 Thread Julia Suvorova
Introduce the 64-bit entry point. Since we no longer have a total number of structures, stop checking for the new ones at the EOF structure (type 127). Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test.c | 101 - 1 file changed, 75 insertions(+), 26

[PATCH 0/5] hw/smbios: add core_count2 to smbios table type 4

2022-05-27 Thread Julia Suvorova
... Core Count: 24 Core Enabled: 24 Thread Count: 1 ... Big update in the bios-tables-test as it couldn't work with SMBIOS 3.0. Julia Suvorova (5): hw/smbios: add core_count2 to smbios table type 4 bios-tables-test: teach test to use smbios 3.0 tables

[PATCH 1/5] hw/smbios: add core_count2 to smbios table type 4

2022-05-27 Thread Julia Suvorova
. core_enabled2 and thread_count2 fields work the same way. Signed-off-by: Julia Suvorova --- include/hw/firmware/smbios.h | 3 +++ hw/smbios/smbios.c | 11 +-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/include/hw/firmware/smbios.h b/include/hw/firmware

[PATCH 5/5] tests/acpi: update tables for new core count test

2022-05-27 Thread Julia Suvorova
EJx: Eject Device, x=0-9 +{ +CEJ0 (0xFF) +} + +Method (_OST, 3, Serialized) // _OST: OSPM Status Indication +{ + COST (0x0101, Arg0, Arg1, Arg2) +} +} ... Signed-off

Re: [PATCH] pc: q35: Bump max_cpus to 512

2022-05-19 Thread Julia Suvorova
hing KVM's limit is unblock upstream > > > testing so it would be easier to push limits for others. > > > Downstream can clamp that value down to whatever it deems as supported. > > > > > > > Going beyond 710 CPUs value requires using the SMBIOS 3 entry

Re: [PATCH 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC

2021-11-10 Thread Julia Suvorova
On Wed, Nov 10, 2021 at 2:58 PM Igor Mammedov wrote: > > On Wed, 10 Nov 2021 02:21:34 -0500 > "Michael S. Tsirkin" wrote: > > > On Wed, Nov 10, 2021 at 06:30:13AM +0100, Julia Suvorova wrote: > > > There are two ways to enable ACPI PCI Hot-plug: > > >

[PATCH 4/5] hw/i386/acpi-build: Deny control on PCIe Native Hot-plug in _OSC

2021-11-09 Thread Julia Suvorova
: --global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off Change the bit in _OSC method so that the OS selects ACPI PCI Hot-plug instead of PCIe Native. [1] https://gitlab.com/qemu-project/qemu/-/issues/641 [2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409 Signed-off-by: Julia

[PATCH 3/5] bios-tables-test: Allow changes in DSDT ACPI tables

2021-11-09 Thread Julia Suvorova
Prepare for changing the _OSC method in q35 DSDT. Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 16 1 file changed, 16 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index

[PATCH 1/5] hw/pci/pcie_port: Rename 'native-hotplug' to 'native-hpc-bit'

2021-11-09 Thread Julia Suvorova
Rename the option to better represent its function - toggle Hot-Plug Capable bit in the PCIe Slot Capability. Signed-off-by: Julia Suvorova --- include/hw/pci/pcie_port.h | 2 +- hw/i386/pc_q35.c | 2 +- hw/pci-bridge/gen_pcie_root_port.c | 6 +- hw/pci/pcie.c

[PATCH 5/5] bios-tables-test: Update golden binaries

2021-11-09 Thread Julia Suvorova
Local0 &= 0x1F +Local0 &= 0x1E Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 16 tests/data/acpi/q35/DSDT| Bin 8289 -> 8289 bytes tests/data/acpi/q35/DSDT.acpihmat | Bin

[PATCH 2/5] hw/acpi/ich9: Add compatibility option for 'native-hpc-bit'

2021-11-09 Thread Julia Suvorova
oot-ports in 6.1 too. [1] https://gitlab.com/qemu-project/qemu/-/issues/641 [2] https://bugzilla.redhat.com/show_bug.cgi?id=2006409 Signed-off-by: Julia Suvorova --- include/hw/acpi/ich9.h | 1 + hw/acpi/ich9.c | 18 ++ hw/i386/pc.c | 2 ++ hw/i386/pc_q35.c

[PATCH 0/5] Fix Q35 ACPI PCI Hot-plug I/O issues

2021-11-09 Thread Julia Suvorova
g IO' [2] https://gitlab.com/qemu-project/qemu/-/issues/641 [3] https://bugzilla.redhat.com/show_bug.cgi?id=2006409 Julia Suvorova (5): hw/pci/pcie_port: Rename 'native-hotplug' to 'native-hpc-bit' hw/acpi/ich9: Add compatibility option for 'native-hpc-bit' b

Re: [PULL 1/5] hw/pcie-root-port: Fix hotplug for PCI devices requiring IO

2021-11-02 Thread Julia Suvorova
.com/qemu-project/qemu/-/issues/641 > > > > > > This regression is significant, because it has broken the out of the > > > box default configuration that OpenStack uses for booting all VMs. > > > They add 16 pcie-root-ports by defalt to allow empty slots for de

Re: [PATCH 2/3] hw/i386/acpi: fix conflicting IO address range for acpi pci hotplug in q35

2021-09-16 Thread Julia Suvorova
hange has been tested using a Windows Server 2019 guest VM. Windows > no longer complains after this change. > > Fixes: caf108bc58790 ("hw/i386/acpi-build: Add ACPI PCI hot-plug methods to > Q35") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/561 > >

[PATCH v6 5/6] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-07-12 Thread Julia Suvorova
=1752465 * https://bugzilla.redhat.com/show_bug.cgi?id=1690256 To return to PCIe Native hot-plug: -global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/acpi/ich9.c | 2 +- hw/i386/pc.c | 1 + 2 files changed, 2

[PATCH v6 6/6] bios-tables-test: Update golden binaries

2021-07-12 Thread Julia Suvorova
} + ... +Method (DVNT, 2, NotSerialized) +{ +If ((Arg0 & One)) +{ +Notify (S00, Arg1) +} ... Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 11 --- tests/dat

[PATCH v6 1/6] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2021-07-12 Thread Julia Suvorova
Implement notifications and gpe to support q35 ACPI PCI hot-plug. Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov Reviewed-by: Marcel Apfelbaum --- hw/i386/acpi-build.h| 4 include/hw/acpi/ich9.h | 2 ++

[PATCH v6 3/6] hw/pci/pcie: Do not set HPC flag if acpihp is used

2021-07-12 Thread Julia Suvorova
e 'hotplug=off' on the port means all hot-plug types are disabled. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov Reviewed-by: Marcel Apfelbaum Reviewed-by: David Gibson --- include/hw/pci/pcie_port.h | 5 - hw/acpi/pcihp.c| 8 hw/core/machine.c

[PATCH v6 4/6] bios-tables-test: Allow changes in DSDT ACPI tables

2021-07-12 Thread Julia Suvorova
All DSDT Q35 tables will be modified because ACPI hot-plug is enabled by default. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov Reviewed-by: Marcel Apfelbaum --- tests/qtest/bios-tables-test-allowed-diff.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/qtest

[PATCH v6 2/6] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-07-12 Thread Julia Suvorova
Add acpi_pcihp to ich9_pm as part of 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. Signed-off-by: Julia Suvorova Signed-off-by: Marcel Apfelbaum Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.h| 1 + include/hw/acpi/ich9.h | 3 ++ hw/acpi/acpi-x86-s

[PATCH v6 0/6] Use ACPI PCI hot-plug for Q35

2021-07-12 Thread Julia Suvorova
idges * use 'acpi-root-pci-hotplug' * add migration states [Igor] * minor style changes v2: * new ioport range for acpiphp [Gerd] * drop find_pci_host() [Igor] * explain magic numbers in _OSC [Igor] * drop build_q35_pci_hotplug() wrapper [Igor] Julia Suvorova (6)

Re: [PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-07-02 Thread Julia Suvorova
On Thu, Jul 1, 2021 at 6:59 AM David Gibson wrote: > > On Thu, Jun 17, 2021 at 09:07:35PM +0200, Julia Suvorova wrote: > > Add acpi_pcihp to ich9_pm as part of > > 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. > > > > Signed-off-b

[PATCH] hw/pci/pcie_port: Rename "enable-native-hotplug" property

2021-06-23 Thread Julia Suvorova
PCIE_SLOT property renamed to "native-hotplug" to be more concise and consistent with other properties. Signed-off-by: Julia Suvorova --- hw/i386/pc_q35.c | 4 ++-- hw/pci/pcie_port.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i38

[PATCH v5 7/7] bios-tables-test: Update golden binaries

2021-06-17 Thread Julia Suvorova
} + ... +Method (DVNT, 2, NotSerialized) +{ +If ((Arg0 & One)) +{ +Notify (S00, Arg1) +} ... Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 11 --- tests/dat

[PATCH v5 4/7] hw/pci/pcie: Do not set HPC flag if acpihp is used

2021-06-17 Thread Julia Suvorova
e 'hotplug=off' on the port means all hot-plug types are disabled. Signed-off-by: Julia Suvorova --- include/hw/pci/pcie_port.h | 5 - hw/acpi/pcihp.c| 8 hw/core/machine.c | 1 - hw/i386/pc_q35.c | 11 +++ hw/pci/pcie.c

[PATCH v5 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2021-06-17 Thread Julia Suvorova
Implement notifications and gpe to support q35 ACPI PCI hot-plug. Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.h| 4 include/hw/acpi/ich9.h | 2 ++ include/hw/acpi/pcihp.h | 3 ++

[PATCH v5 6/7] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-06-17 Thread Julia Suvorova
=1752465 * https://bugzilla.redhat.com/show_bug.cgi?id=1690256 To return to PCIe Native hot-plug: -global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/acpi/ich9.c | 2 +- hw/i386/pc.c | 1 + 2 files changed, 2

[PATCH v5 5/7] bios-tables-test: Allow changes in DSDT ACPI tables

2021-06-17 Thread Julia Suvorova
All DSDT Q35 tables will be modified because ACPI hot-plug is enabled by default. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- tests/qtest/bios-tables-test-allowed-diff.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed

[PATCH v5 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-06-17 Thread Julia Suvorova
Add acpi_pcihp to ich9_pm as part of 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.h | 1 + include/hw/acpi/ich9.h | 3 ++ hw/acpi/ich9.c

[PATCH v5 0/7] Use ACPI PCI hot-plug for Q35

2021-06-17 Thread Julia Suvorova
ci_hotplug() wrapper [Igor] Julia Suvorova (7): hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35 hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35 hw/acpi/ich9: Enable ACPI PCI hot-plug hw/pci/pcie: Do not set HPC flag if acpihp is used bios-tables-test: Allow

[PATCH v5 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35

2021-06-17 Thread Julia Suvorova
PCI Express does not allow hot-plug on pcie.0. Check for Q35 in acpi_pcihp_disable_root_bus() to be able to forbid hot-plug using the 'acpi-root-pci-hotplug' flag. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/acpi/pcihp.c | 3 ++- 1 file changed, 2 insertions(+),

Re: [RFC PATCH v4 0/7] Use ACPI PCI hot-plug for Q35

2021-06-16 Thread Julia Suvorova
On Sun, May 23, 2021 at 10:26 AM Michael S. Tsirkin wrote: > > On Thu, May 13, 2021 at 08:26:35AM +0200, Julia Suvorova wrote: > > The patch set consists of two parts: > > patches 1-4: introduce new feature > > 'acpi-pci-hotplug-with-bridge-support'

[RFC PATCH v4 1/7] hw/acpi/pcihp: Enhance acpi_pcihp_disable_root_bus() to support Q35

2021-05-12 Thread Julia Suvorova
PCI Express does not allow hot-plug on pcie.0. Check for Q35 in acpi_pcihp_disable_root_bus() to be able to forbid hot-plug using the 'acpi-root-pci-hotplug' flag. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/acpi/pcihp.c | 3 ++- 1 file changed, 2 insertions(+),

[RFC PATCH v4 7/7] bios-tables-test: Update golden binaries

2021-05-12 Thread Julia Suvorova
} + ... +Method (DVNT, 2, NotSerialized) +{ +If ((Arg0 & One)) +{ +Notify (S00, Arg1) +} ... Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 11 --- tests/dat

[RFC PATCH v4 5/7] bios-tables-test: Allow changes in DSDT ACPI tables

2021-05-12 Thread Julia Suvorova
All DSDT Q35 tables will be modified because ACPI hot-plug is enabled by default. Signed-off-by: Julia Suvorova --- tests/qtest/bios-tables-test-allowed-diff.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables

[RFC PATCH v4 6/7] hw/acpi/ich9: Set ACPI PCI hot-plug as default on Q35

2021-05-12 Thread Julia Suvorova
-hotplug-with-bridge-support=off Signed-off-by: Julia Suvorova --- hw/acpi/ich9.c | 2 +- hw/i386/pc.c | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index f6819c4f2a..e7b2cd9719 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -425,7

[RFC PATCH v4 4/7] hw/pci/pcie: Do not set HPC flag if acpihp is used

2021-05-12 Thread Julia Suvorova
e 'hotplug=off' on the port means all hot-plug types are disabled. Signed-off-by: Julia Suvorova --- include/hw/boards.h | 1 + hw/acpi/pcihp.c | 8 hw/core/machine.c | 19 +++ hw/i386/pc_q35.c| 8 hw/pci/pcie.c | 11 ++-

[RFC PATCH v4 0/7] Use ACPI PCI hot-plug for Q35

2021-05-12 Thread Julia Suvorova
ed bridges * use 'acpi-root-pci-hotplug' * add migration states [Igor] * minor style changes v2: * new ioport range for acpiphp [Gerd] * drop find_pci_host() [Igor] * explain magic numbers in _OSC [Igor] * drop build_q35_pci_hotplug() wrapper [Igor] Julia Suv

[RFC PATCH v4 2/7] hw/i386/acpi-build: Add ACPI PCI hot-plug methods to Q35

2021-05-12 Thread Julia Suvorova
Implement notifications and gpe to support q35 ACPI PCI hot-plug. Use 0xcc4 - 0xcd7 range for 'acpi-pci-hotplug' io ports. Signed-off-by: Julia Suvorova Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.h| 4 include/hw/acpi/ich9.h | 2 ++ include/hw/acpi/pcihp.h | 3 ++

[RFC PATCH v4 3/7] hw/acpi/ich9: Enable ACPI PCI hot-plug

2021-05-12 Thread Julia Suvorova
Add acpi_pcihp to ich9_pm as part of 'acpi-pci-hotplug-with-bridge-support' option. Set default to false. Signed-off-by: Julia Suvorova --- hw/i386/acpi-build.h | 1 + include/hw/acpi/ich9.h | 3 ++ hw/acpi/ich9.c | 68 ++ hw/ac

Re: [PATCH] hw/pci-host/pam: Replace magic number by PAM_REGIONS_COUNT definition

2020-12-02 Thread Julia Suvorova
> > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/pci-host/i440fx.h | 2 +- > include/hw/pci-host/pam.h| 2 ++ > include/hw/pci-host/q35.h| 2 +- > hw/pci-host/pam.c| 2 +- > hw/pci-host/q35.c| 2 +- > 5 files changed, 6 insertio

Re: hw/i386/q35: Where go LPC irqs?

2020-11-11 Thread Julia Suvorova
On Sat, Nov 7, 2020 at 3:48 PM Philippe Mathieu-Daudé wrote: > > Hi, I am confuse with the LPC/GSI code. > > In pc_q35_init() we connect the LPC outputs to > GSI input: > > 116 static void pc_q35_init(MachineState *machine) > 117 { > ... > 240 /* irq lines */ > 241 gsi_state = pc_gsi_creat

Re: [PATCH v2] hw/pci/pci: Fix slot check for plugged devices

2020-10-07 Thread Julia Suvorova
On Wed, Oct 7, 2020 at 9:39 AM Stefano Garzarella wrote: > > On Tue, Oct 06, 2020 at 02:59:08PM +0200, Julia Suvorova wrote: > > If devfn is assigned automatically, 'else' clauses will never be > > executed. And if it does not matter for the reserved and availabl

[PATCH] hw/pci: Fix typo in PCI hot-plug error message

2020-10-06 Thread Julia Suvorova
'occupied' is spelled like 'ocuppied' in the message. Signed-off-by: Julia Suvorova --- hw/pci/pci.c | 2 +- hw/ppc/spapr_pci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 3c8f10b461..100c9381c2 100644 ---

[PATCH v2] hw/pci/pci: Fix slot check for plugged devices

2020-10-06 Thread Julia Suvorova
-device pcie-root-port,id=rp,.. \ -device pci-device,bus=rp 2. Add a new device to the same port: device_add pci-device,bus=rp The last command will add the device to slot 1 instead of failing with "PCI: slot 0 function 0 already occupied..." Signed-off-by: Julia Suvorov

Re: [RFC PATCH v3 0/7] Use ACPI PCI hot-plug for Q35

2020-10-01 Thread Julia Suvorova
On Thu, Oct 1, 2020 at 1:40 PM Michael S. Tsirkin wrote: > > On Thu, Oct 01, 2020 at 10:55:35AM +0200, Julia Suvorova wrote: > > On Thu, Sep 24, 2020 at 11:20 AM Michael S. Tsirkin wrote: > > > > > > On Thu, Sep 24, 2020 at 09:00:06AM +0200, Julia Suvorova wrote:

  1   2   3   >