Re: [PATCH v5 1/3] hw/misc: Implement STM32L4x5 EXTI

2024-01-04 Thread inesvarhol
Le jeudi 4 janvier 2024 à 14:40, Philippe Mathieu-Daudé a écrit : > If you don't have access to similar compiler, you can fork on GitLab > and push a branch to trigger the CI; I expect it to fail. Thanks for the tip ! Ines Varhol

Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2024-01-04 Thread inesvarhol
Le jeudi 4 janvier 2024 à 14:05, Philippe Mathieu-Daudé a écrit : Hello, > > +static void test_edge_selector(void) > > +{ > > + enable_nvic_irq(EXTI0_IRQ); > > + > > + / Configure EXTI line 0 irq on rising edge */ > > + qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti", > >

Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2024-01-04 Thread inesvarhol
Le jeudi 4 janvier 2024 à 14:33, Philippe Mathieu-Daudé a écrit : > On 28/12/23 17:19, Inès Varhol wrote: > > > Signed-off-by: Arnaud Minier arnaud.min...@telecom-paris.fr > > Signed-off-by: Inès Varhol ines.var...@telecom-paris.fr > > --- > > tests/qtest/meson.build | 5 + > > tests/qtest/stm32

[PATCH qemu v2 0/3] Add device STM32L4x5 SYSCFG

2023-12-18 Thread ~inesvarhol
Hello Alistair, thank you for your comments. Changes from v1 to v2: - explain in 3rd commit why SYSCFG input GPIOs aren't connected and add a TODO comment in stm32l4x5_soc.c - use macros `NUM_GPIOS` and `GPIO_NUM_PINS` in `stm32l4x5_syscfg_set_irq` - rename STM32L4XX to STM32L4X5, Stm32l4xx to Stm

[PATCH qemu v2 1/3] hw/misc: Implement STM32L4x5 SYSCFG

2023-12-18 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/misc/Kconfig| 3 + hw/misc/meson.build| 1 + hw/misc/stm32l4x5_syscfg.c | 265 + hw/misc/trace-events | 6 + include/hw/m

[PATCH qemu v2 3/3] hw/arm: Connect STM32L4x5 SYSCFG to STM32L4x5 SoC

2023-12-18 Thread ~inesvarhol
From: Inès Varhol The SYSCFG input GPIOs aren't connected yet. When the STM32L4x5 GPIO device will be implemented, its output GPIOs will be connected to the SYSCFG input GPIOs. Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig | 1 + hw/arm/stm32l4x5_

[PATCH qemu v2 2/3] tests/qtest: Add STM32L4x5 SYSCFG QTest testcase

2023-12-18 Thread ~inesvarhol
From: Inès Varhol Acked-by: Alistair Francis Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 3 +- tests/qtest/stm32l4x5_syscfg-test.c | 408 2 files changed, 410 insertions(+), 1 deletion(-) create mode 100644

[PATCH qemu v3 0/3] Add device STM32L4x5 EXTI

2023-12-18 Thread ~inesvarhol
Changes from non-RFC v2 to non-RFC v3: - corrected the license Changes from non-RFC v1 to non-RFC v2: - correct the commit messages - remove a misleading comment Changes from v3 to non-RFC v1: - separating the patch in 3 commits - justifying in the commit message why we implement a new model inst

[PATCH qemu v3 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2023-12-18 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 5 + tests/qtest/stm32l4x5_exti-test.c | 485 ++ 2 files changed, 490 insertions(+) create mode 100644 tests/qtest/stm32l4x5_exti-test.c diff --git

[PATCH qemu v3 3/3] hw/arm: Connect STM32L4x5 EXTI to STM32L4x5 SoC

2023-12-18 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig | 1 + hw/arm/stm32l4x5_soc.c | 56 -- include/hw/arm/stm32l4x5_soc.h | 3 ++ 3 files changed, 58 insertions(+), 2 deletions(-) diff --git a/h

[PATCH qemu v3 1/3] hw/misc: Implement STM32L4x5 EXTI

2023-12-18 Thread ~inesvarhol
From: Inès Varhol Although very similar to the STM32F4xx EXTI, STM32L4x5 EXTI generates more than 32 event/interrupt requests and thus uses more registers than STM32F4xx EXTI which generates 23 event/interrupt requests. Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/misc/Kconf

[PATCH qemu v3 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-12-14 Thread ~inesvarhol
From: Inès Varhol This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC. The implementation is derived from the Netduino Plus 2 machine. There are no peripherals implemented yet, only memory regions. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Arnaud Minier Signed-off-b

[PATCH qemu v3 0/2] Add minimal support for the B-L475E-IOT01A board

2023-12-14 Thread ~inesvarhol
This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC and NetduinoPlus2 board. The implementation contains no peripherals, only memory regions are implemented. Sorry about the inconsistency in licenses

[PATCH qemu v3 1/2] hw/arm: Add minimal support for the STM32L4x5 SoC

2023-12-14 Thread ~inesvarhol
From: Inès Varhol This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC. The implementation contains no peripherals, only memory regions are implemented. Reviewed-by: Philippe Mathieu-Daudé Signed-

[PATCH qemu v2 0/3] Add device STM32L4x5 EXTI

2023-12-12 Thread ~inesvarhol
This patch adds a new STM32L4x5 EXTI device and is part of a series implementing the STM32L4x5 with a few peripherals. Thank you Philippe for letting us know we're on your review list and that you're busy. Please take your time, in the meantime we'll make progress on more peripherals :-) Sincerel

[PATCH qemu v2 3/3] hw/arm: Connect STM32L4x5 EXTI to STM32L4x5 SoC

2023-12-12 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig | 1 + hw/arm/stm32l4x5_soc.c | 56 -- include/hw/arm/stm32l4x5_soc.h | 3 ++ 3 files changed, 58 insertions(+), 2 deletions(-) diff --git a/h

[PATCH qemu v2 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2023-12-12 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 5 + tests/qtest/stm32l4x5_exti-test.c | 485 ++ 2 files changed, 490 insertions(+) create mode 100644 tests/qtest/stm32l4x5_exti-test.c diff --git

[PATCH qemu v2 1/3] hw/misc: Implement STM32L4x5 EXTI

2023-12-12 Thread ~inesvarhol
From: Inès Varhol Although very similar to the STM32F4xx EXTI, STM32L4x5 EXTI generates more than 32 event/interrupt requests and thus uses more registers than STM32F4xx EXTI which generates 23 event/interrupt requests. Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/misc/Kconf

[PATCH qemu 1/3] hw/misc: Implement STM32L4xx SYSCFG

2023-12-10 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/misc/Kconfig| 3 + hw/misc/meson.build| 1 + hw/misc/stm32l4xx_syscfg.c | 277 + hw/misc/trace-events | 6 + include/hw/m

[PATCH qemu 2/3] tests/qtest: Add STM32L4xx SYSCFG QTest testcase

2023-12-10 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 3 +- tests/qtest/stm32l4xx_syscfg-test.c | 408 2 files changed, 410 insertions(+), 1 deletion(-) create mode 100644 tests/qtest/stm32l4xx_syscfg

[PATCH qemu 3/3] hw/arm: Connect STM32L4xx SYSCFG to STM32L4x5 SoC

2023-12-10 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig | 1 + hw/arm/stm32l4x5_soc.c | 24 include/hw/arm/stm32l4x5_soc.h | 2 ++ 3 files changed, 19 insertions(+), 8 deletions(-) diff --git a/hw/arm/Kcon

[PATCH qemu 0/3] [PATCH qemu 0/3] hw/arm: Add device STM32L4x5 SYSCFG

2023-12-10 Thread ~inesvarhol
This patch adds a new SYSCFG peripheral used by the STM32L4x5 SoC. The implementation is inspired from the STM32F4xx SYSCFG, the device registers however aren't the same. The patch is split up in 3 commits : - implementing the SYSCFG device - adding tests (that fail in this commit) - connecting th

[PATCH qemu v2 1/2] hw/arm: Add minimal support for the STM32L4x5 SoC

2023-12-07 Thread ~inesvarhol
From: Inès Varhol This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC. The implementation contains no peripherals, only memory regions are implemented. Reviewed-by: Philippe Mathieu-Daudé Signed-

[PATCH qemu v2 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-12-07 Thread ~inesvarhol
From: Inès Varhol This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC. The implementation is derived from the Netduino Plus 2 machine. There are no peripherals implemented yet, only memory regions. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Arnaud Minier Signed-off-b

[PATCH qemu v2 0/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-12-07 Thread ~inesvarhol
This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC and NetduinoPlus2 board. The implementation contains no peripherals, only memory regions are implemented. Changes from v1 to v2: Thank you Alistair

[PATCH qemu 2/3] hw/arm: Add STM32L4x5 EXTI QTest testcase

2023-12-07 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 5 + tests/qtest/stm32l4x5_exti-test.c | 485 ++ 2 files changed, 490 insertions(+) create mode 100644 tests/qtest/stm32l4x5_exti-test.c diff --git

[PATCH qemu 1/3] hw/arm: Implement STM32L4x5 EXTI

2023-12-07 Thread ~inesvarhol
From: Inès Varhol Although very similar to the STM32F4xx EXTI, STM32L4x5 EXTI generates more than 32 event/interrupt requests and thus uses more registers than STM32F4xx EXTI which generates 23 event/interrupt requests. Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/misc/Kconf

[PATCH qemu 0/3] hw/arm: Add device STM32L4x5 EXTI

2023-12-07 Thread ~inesvarhol
This patch adds a new STM32L4x5 EXTI device and is part of a series implementing the STM32L4x5 with a few peripherals. The patch is split up in 3 commits : - implementing the EXTI device - adding tests (that fail in this commit) - connecting the EXTI device to the SoC (the tests pass in this commi

[PATCH qemu 3/3] hw/arm: Connect STM32L4x5 EXTI to STM32L4x5 SoC

2023-12-07 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig | 1 + hw/arm/stm32l4x5_soc.c | 65 -- include/hw/arm/stm32l4x5_soc.h | 3 ++ 3 files changed, 67 insertions(+), 2 deletions(-) diff --git a/h

[PATCH RFC v3 0/1] Implement STM32L4x5 EXTI

2023-12-04 Thread ~inesvarhol
This patch allows to emulate the STM32L4x5 EXTI device. It implements register access and software interruptions. This is RFC because we're new at contributing to QEMU. We had some difficulties writing qtests and the result might be bizarre. We have some questions about the next steps for our stm

[PATCH RFC v3 1/1] Implement STM32L4x5 EXTI

2023-12-04 Thread ~inesvarhol
From: Inès Varhol Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig| 1 + hw/arm/stm32l4x5_soc.c| 65 +++- hw/misc/Kconfig | 3 + hw/misc/meson.build | 1 + hw/misc/stm32l4x5_exti.c | 306 +

[PATCH qemu 1/2] hw/arm: Add minimal support for the STM32L4x5 SoC

2023-11-26 Thread ~inesvarhol
From: Inès Varhol This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC. The implementation contains no peripherals, only memory regions are implemented. Reviewed-by: Philippe Mathieu-Daudé Signed-

[PATCH qemu 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-11-26 Thread ~inesvarhol
From: Inès Varhol This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC. The implementation is derived from the Netduino Plus 2 machine. There are no peripherals implemented yet, only memory regions. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Arnaud Minier Signed-off-b

[PATCH qemu 0/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-11-26 Thread ~inesvarhol
This patch allows to emulate the B-L475E-IOT01A ARM Cortex-M4 board. It's a minimal version without any implemented peripherals yet. We've corrected the patch according to the reviews of Philippe Mathieu- Daudé (thank you !), and additionally completed the MAINTAINERS file with the new devices. I'

[PATCH RFC v3 1/2] hw/arm: Add minimal support for the STM32L4x5 SoC

2023-11-20 Thread ~inesvarhol
From: Inès Varhol This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC. The implementation contains no peripherals, only memory regions are implemented. Reviewed-by: Philippe Mathieu-Daudé Signed-

[PATCH RFC v3 0/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-11-20 Thread ~inesvarhol
This patch allows to emulate the B-L475E-IOT01A ARM Cortex-M4 board. This is RFC since the implementation isn't complete yet, there are no implemented peripherals, and it's a first contribution to QEMU. The changes from v1 follow the reviews from Philippe Mathieu-Daudé. We additionally changed the

[PATCH RFC v3 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-11-20 Thread ~inesvarhol
From: Inès Varhol This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC. The implementation is derived from the Netduino Plus 2 machine. There are no peripherals implemented, only memory regions. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Arnaud Minier Signed-off-by: I

[PATCH RFC v2 0/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-11-20 Thread ~inesvarhol
This patch allows to emulate the B-L475E-IOT01A ARM Cortex-M4 board. This is RFC since the implementation isn't complete yet, there are no implemented peripherals, and it's a first contribution to QEMU. The changes from v1 follow the reviews from Philippe Mathieu-Daudé. We additionally changed the

[PATCH RFC v2 1/2] hw/arm: Add minimal support for the STM32L4x5 SoC

2023-11-20 Thread ~inesvarhol
From: Inès Varhol This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC. The implementation contains no peripherals, only memory regions are implemented. Signed-off-by: Arnaud Minier Signed-off-by:

[PATCH RFC v2 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-11-20 Thread ~inesvarhol
From: Inès Varhol This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC. The implementation is derived from the Netduino Plus 2 machine. There are no peripherals implemented, only memory regions. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Arnaud Minier Signed-off-by: I

[PATCH RFC 1/2] hw/arm: Add minimal support for the STM32L475VG SoC

2023-11-15 Thread ~inesvarhol
From: Inès Varhol This patch adds a new STM32L475VG SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC. The implementation contains no peripherals, only memory regions are implemented. Signed-off-by: Arnaud Minier Signed-off-by

[PATCH RFC 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-11-15 Thread ~inesvarhol
From: Inès Varhol This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC. The implementation is derived from the Netduino Plus 2 machine. There are no peripherals implemented, only memory regions. Signed-off-by: default avatarArnaud Minier Signed-off-by: Inès Varhol --- configs

[PATCH RFC 0/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-11-15 Thread ~inesvarhol
This patch allows to emulate the B-L475E-IOT01A ARM Cortex-M4 board. This is RFC since the implementation isn't complete yet, there are no implemented peripherals, and it's a first contribution to QEMU. Inès Varhol (2): hw/arm: Add minimal support for the STM32L475VG SoC hw/arm: Add minimal su