Re: [PATCH] docs/devel/submitting-a-patch.rst: add b4 section

2025-07-17 Thread Gustavo Romero
x27;s guidelines about proper commit messages etc. +4. Write a descriptive cover later with ``b4 prep --edit-cover``. Nit: You meant "cover letter" here maybe? Otherwise: Reviewed-by: Gustavo Romero Cheers, Gustavo +5. Add maintainer and reviewer CCs with ``b4 prep --auto-to-cc`

Re: [PATCH v8 0/4] target/arm: Add FEAT_MEC to max cpu

2025-07-16 Thread Gustavo Romero
Hi Pierrick! On 7/16/25 02:56, Pierrick Bouvier wrote: On 7/15/25 8:13 PM, Gustavo Romero wrote: Hi Pierrick, On 7/14/25 22:26, Pierrick Bouvier wrote: On 7/14/25 4:31 PM, Gustavo Romero wrote: Hi folks, Richard, thanks for v8. Pierrick, thanks for testing it. :) On 7/14/25 14:09

Re: [PATCH v8 0/4] target/arm: Add FEAT_MEC to max cpu

2025-07-15 Thread Gustavo Romero
Hi Pierrick, On 7/14/25 22:26, Pierrick Bouvier wrote: On 7/14/25 4:31 PM, Gustavo Romero wrote: Hi folks, Richard, thanks for v8. Pierrick, thanks for testing it. :) On 7/14/25 14:09, Pierrick Bouvier wrote: On 7/14/25 8:58 AM, Richard Henderson wrote: Changes for v8:     - Re-order

Re: [PATCH v8 0/4] target/arm: Add FEAT_MEC to max cpu

2025-07-14 Thread Gustavo Romero
ipts in [0], enabling ENABLE_FEAT_TCR2 and ENABLE_FEAT_SCTLR2, but no way to get it booting. I understand we can embed a OP-TEE into the TF_A via BL32= when building TF-A. Is that what you're using? Thanks. Cheers, Gustavo [0] https://github.com/pbo-linaro/qemu-linux-stack.git As I&#x

Re: [PATCH v7 4/6] target/arm: Add FEAT_TCR2

2025-07-14 Thread Gustavo Romero
Hi Richard, On 7/14/25 09:58, Richard Henderson wrote: On 7/14/25 00:21, Pierrick Bouvier wrote: On 7/13/25 2:59 PM, Richard Henderson wrote: On 7/11/25 08:08, Gustavo Romero wrote: Add FEAT_TCR2, which introduces the TCR2_EL1 and TCR2_EL2 registers. These registers are extensions of the

[PATCH v7 5/6] target/arm: Implement FEAT_MEC cache instructions

2025-07-11 Thread Gustavo Romero
: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/helper.c | 24 1 file changed, 24 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 973b276d90..ce981191b3 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -5225,6 +5225,18

[PATCH v7 6/6] target/arm: Advertise FEAT_MEC in cpu max

2025-07-11 Thread Gustavo Romero
context is not possible. An encryption context allow the selection of a memory encryption engine. At this point, no real memory encryption is supported, but software stacks that rely on FEAT_MEC to run should work properly. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- docs

[PATCH v7 2/6] target/arm: Add FEAT_MEC registers

2025-07-11 Thread Gustavo Romero
. FEAT_MEC also requires two new cache management instructions, not included in this commit, that will be implemented in a subsequent commit. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/cpu-features.h | 5 +++ target/arm/cpu.c | 3 ++ target/arm/cpu.h

[PATCH v7 1/6] target/arm: Add the MECEn SCR_EL3 bit

2025-07-11 Thread Gustavo Romero
The MECEn bit in SCR_EL3 enables access to the EL2 MECID registers from EL2, so add it to the SCR mask list to use it later on. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm

[PATCH v7 4/6] target/arm: Add FEAT_TCR2

2025-07-11 Thread Gustavo Romero
the moment, the FEAT_TCR2 only implements the AMEC bits for now. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.c | 3 ++ target/arm/cpu.h | 2 ++ target/arm/helper.c | 62

[PATCH v7 3/6] target/arm: Add FEAT_SCTLR2

2025-07-11 Thread Gustavo Romero
in CTLR2_EL2 and SCTLR2_EL3. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.c | 3 ++ target/arm/cpu.h | 15 +++ target/arm/helper.c | 80

[PATCH-for-10.1 v7 0/6] target/arm: Add FEAT_MEC to max cpu

2025-07-11 Thread Gustavo Romero
rently exploring possibilities to support FEAT_MEC encryption (or obfuscation, for testing purposes) in QEMU for the various translation regimes on arm64, hence the encryption part of FEAT_MEC will be contributed later and is not targeted for QEMU 10.1. Cheers, Gustavo Gustavo Romero (6): tar

[PATCH v6 2/6] target/arm: Add FEAT_MEC registers

2025-07-10 Thread Gustavo Romero
. FEAT_MEC also requires two new cache management instructions, not included in this commit, that will be implemented in a subsequent commit. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 9 + target/arm

[PATCH-for-10.1 v6 0/6] target/arm: Add FEAT_MEC to max cpu

2025-07-10 Thread Gustavo Romero
x27;m currently exploring possibilities to support FEAT_MEC encryption (or obfuscation, for testing purposes) in QEMU for the various translation regimes on arm64, hence the encryption part of FEAT_MEC will be contributed later and is not targeted for QEMU 10.1. Cheers, Gustavo Gustavo Romero (6):

[PATCH v6 3/6] target/arm: Add FEAT_SCTLR2

2025-07-10 Thread Gustavo Romero
in CTLR2_EL2 and SCTLR2_EL3. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 15 +++ target/arm/helper.c | 80 +++ target

[PATCH v6 4/6] target/arm: Add FEAT_TCR2

2025-07-10 Thread Gustavo Romero
the moment, the FEAT_TCR2 only implements the AMEC bits for now. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 2 ++ target/arm/helper.c | 62 +++ target/arm

[PATCH v6 5/6] target/arm: Implement FEAT_MEC cache instructions

2025-07-10 Thread Gustavo Romero
: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/helper.c | 24 1 file changed, 24 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index ecfd53cc5a..c030f0a0da 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6856,6 +6856,18

[PATCH v6 6/6] target/arm: Advertise FEAT_MEC in cpu max

2025-07-10 Thread Gustavo Romero
context is not possible. An encryption context allow the selection of a memory encryption engine. At this point, no real memory encryption is supported, but software stacks that rely on FEAT_MEC to run should work properly. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- docs

[PATCH v6 1/6] target/arm: Add the MECEn SCR_EL3 bit

2025-07-10 Thread Gustavo Romero
The MECEn bit in SCR_EL3 enables access to the EL2 MECID registers from EL2, so add it to the SCR mask list to use it later on. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm

[PATCH v5 6/6] target/arm: Advertise FEAT_MEC in cpu max

2025-07-10 Thread Gustavo Romero
context is not possible. An encryption context allow the selection of a memory encryption engine. At this point, no real memory encryption is supported, but software stacks that rely on FEAT_MEC to run should work properly. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- docs

[PATCH v5 5/6] target/arm: Implement FEAT_MEC cache instructions

2025-07-10 Thread Gustavo Romero
: Gustavo Romero --- target/arm/helper.c | 24 1 file changed, 24 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 6f678aceeb..5aab9294bc 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -6856,6 +6856,18 @@ static void mecid_write

[PATCH v5 4/6] target/arm: Add FEAT_TCR2

2025-07-10 Thread Gustavo Romero
the moment, the FEAT_TCR2 only implements the AMEC bits for now. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 2 ++ target/arm/helper.c | 60 +++ target/arm

[PATCH v5 2/6] target/arm: Add FEAT_MEC registers

2025-07-10 Thread Gustavo Romero
. FEAT_MEC also requires two new cache management instructions, not included in this commit, that will be implemented in a subsequent commit. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 9 + target/arm

[PATCH v5 3/6] target/arm: Add FEAT_SCTLR2

2025-07-10 Thread Gustavo Romero
in CTLR2_EL2 and SCTLR2_EL3. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 15 +++ target/arm/helper.c | 78 +++ target

[PATCH-for-10.1 v5 0/6] target/arm: Add FEAT_MEC to max cpu

2025-07-10 Thread Gustavo Romero
ryption part of FEAT_MEC will be contributed later and is not targeted for QEMU 10.1. Cheers, Gustavo Gustavo Romero (6): target/arm: Add the MECEn SCR_EL3 bit target/arm: Add FEAT_MEC registers target/arm: Add FEAT_SCTLR2 target/arm: Add FEAT_TCR2 target/arm: Implement FEAT_MEC cache instru

[PATCH v5 1/6] target/arm: Add the MECEn SCR_EL3 bit

2025-07-10 Thread Gustavo Romero
The MECEn bit in SCR_EL3 enables access to the EL2 MECID registers from EL2, so add it to the SCR mask list to use it later on. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm

Re: [PATCH v4 6/6] target/arm: Advertise FEAT_MEC in cpu max

2025-07-10 Thread Gustavo Romero
Hi Richard! On 7/9/25 17:54, Richard Henderson wrote: On 7/9/25 12:03, Gustavo Romero wrote: At this point, no real memory encryption is supported, but most software stacks that rely on FEAT_MEC to run should work properly. s/most //? Anyway, Reviewed-by: Richard Henderson Thanks a lot

[PATCH v4 3/6] target/arm: Add FEAT_SCTLR2

2025-07-09 Thread Gustavo Romero
in CTLR2_EL2 and SCTLR2_EL3. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 15 +++ target/arm/helper.c | 78 +++ target/arm/internals.h| 1

[PATCH v4 6/6] target/arm: Advertise FEAT_MEC in cpu max

2025-07-09 Thread Gustavo Romero
context is not possible. An encryption context allow the selection of a memory encryption engine. At this point, no real memory encryption is supported, but most software stacks that rely on FEAT_MEC to run should work properly. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 3

[PATCH v4 4/6] target/arm: Add FEAT_TCR2

2025-07-09 Thread Gustavo Romero
the moment, the FEAT_TCR2 only implements the AMEC bits for now. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 2 ++ target/arm/helper.c | 60 +++ target/arm

[PATCH v4 2/6] target/arm: Add FEAT_MEC registers

2025-07-09 Thread Gustavo Romero
management instructions, not included in this commit, that will be implemented in subsequent commits. Signed-off-by: Gustavo Romero --- target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 11 ++ target/arm/helper.c | 70 +++ 3 files changed, 86

[PATCH v4 1/6] target/arm: Add the MECEn SCR_EL3 bit

2025-07-09 Thread Gustavo Romero
The MECEn bit in SCR_EL3 enables access to the EL2 MECID registers from EL2, so add it to the SCR mask list to use it later on. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm

[PATCH v4 5/6] target/arm: Implement FEAT_MEC cache instructions

2025-07-09 Thread Gustavo Romero
: Gustavo Romero --- target/arm/helper.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 34e12bde90..36cf2b6415 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -4996,6 +4996,34 @@ static void

[PATCH-for-10.1 v4 0/6] target/arm: Add FEAT_MEC to max cpu

2025-07-09 Thread Gustavo Romero
s not targeted for QEMU 10.1. Cheers, Gustavo Gustavo Romero (6): target/arm: Add the MECEn SCR_EL3 bit target/arm: Add FEAT_MEC registers target/arm: Add FEAT_SCTLR2 target/arm: Add FEAT_TCR2 target/arm: Implement FEAT_MEC cache instructions target/arm: Advertise FEAT_MEC in cpu max

[RFC PATCH-for-10.1 v3 3/5] target/arm: Add FEAT_SCTLR2

2025-07-08 Thread Gustavo Romero
in CTLR2_EL2 and SCTLR2_EL3. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 15 +++ target/arm/helper.c | 78 +++ target/arm/internals.h| 1

[RFC PATCH-for-10.1 v3 4/5] target/arm: Add FEAT_TCR2

2025-07-08 Thread Gustavo Romero
the moment, the FEAT_TCR2 only implements the AMEC bits for now. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 2 ++ target/arm/helper.c | 60 +++ target/arm

[RFC PATCH-for-10.1 v3 2/5] target/arm: Add FEAT_MEC registers

2025-07-08 Thread Gustavo Romero
management instructions, not included in this commit, that will be implemented in subsequent commits. Signed-off-by: Gustavo Romero --- target/arm/cpu-features.h | 5 +++ target/arm/cpu.h | 11 ++ target/arm/helper.c | 70 +++ 3 files changed, 86

[RFC PATCH-for-10.1 v3 0/5] target/arm: Add FEAT_MEC to max cpu

2025-07-08 Thread Gustavo Romero
T_MEC encryption (or obfuscation, for testing purposes) in QEMU for the various translation regimes used on arm64. Cheers, Gustavo Gustavo Romero (5): target/arm: Add the MECEn SCR_EL3 bit target/arm: Add FEAT_MEC registers target/arm: Add FEAT_SCTLR2 target/arm: Add FEAT_TCR2 targe

[RFC PATCH-for-10.1 v3 1/5] target/arm: Add the MECEn SCR_EL3 bit

2025-07-08 Thread Gustavo Romero
The MECEn bit in SCR_EL3 enables access to the EL2 MECID registers from EL2, so add it to the SCR mask list to use it later on. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm

Re: [WIP-for-10.1 v2 5/5] target/arm: Advertise FEAT_MEC in cpu max

2025-07-08 Thread Gustavo Romero
Hi Richard, Thanks a lot for the reviews! On 7/4/25 19:56, Richard Henderson wrote: On 7/4/25 09:14, Gustavo Romero wrote: Advertise FEAT_MEC in AA64MMFR3 ID register for the Arm64 cpu max as a first step to fully support FEAT_MEC. The FEAT_MEC is an extension to FEAT_RME that implements

[RFC PATCH-for-10.1 v3 5/5] target/arm: Advertise FEAT_MEC in cpu max

2025-07-08 Thread Gustavo Romero
will be implement in a subsequent commit. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/tcg/cpu64.c| 1 + 2 files changed, 2 insertions(+) diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst index 1c597d8673..1b47246d2a 100644

[WIP-for-10.1 v2 4/5] target/arm: Add FEAT_TCR2

2025-07-04 Thread Gustavo Romero
moment, the FEAT_TCR2 registers only implement the bits related to FEAT_MEC for now. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 + target/arm/cpu.h | 1 + target/arm/helper.c | 40

[WIP-for-10.1 v2 1/5] target/arm: Add the MECEn SCR_EL3 bit

2025-07-04 Thread Gustavo Romero
The MECEn bit in SCR_EL3 enables access to the EL2 MECID registers from EL2, so add it to the SCR mask list to use it later on. Signed-off-by: Gustavo Romero --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 302c24e232..8ce30ca857

[WIP-for-10.1 v2 2/5] target/arm: Add FEAT_MEC registers

2025-07-04 Thread Gustavo Romero
management instructions, not included in this commit, that will be implemented in subsequent commits. Signed-off-by: Gustavo Romero --- target/arm/cpu.h| 14 +++ target/arm/helper.c | 98 + 2 files changed, 112 insertions(+) diff --git a/target/arm

[WIP-for-10.1 v2 3/5] target/arm: Add FEAT_SCTLR2

2025-07-04 Thread Gustavo Romero
related to FEAT_MEC in CTLR2_EL2 and SCTLR2_EL3. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 target/arm/cpu.h | 15 +++ target/arm/helper.c | 51 +++ target/arm/tcg

[WIP-for-10.1 v2 5/5] target/arm: Advertise FEAT_MEC in cpu max

2025-07-04 Thread Gustavo Romero
will be implement in a subsequent commit. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 + target/arm/tcg/cpu64.c| 1 + 3 files changed, 7 insertions(+) diff --git a/docs/system/arm/emulation.rst b/docs/system/arm

[WIP-for-10.1 v2 0/5] target/arm: Add FEAT_MEC to max cpu

2025-07-04 Thread Gustavo Romero
, most software stacks that rely on FEAT_MEC should work properly with this minimal support at the moment. I'm currently exploring possibilities to support FEAT_MEC encryption (or obfuscation, for testing purposes) in QEMU for the various translation regimes used on arm64. Gustavo Rome

[PATCH 3/3] target/arm: Add FEAT_MEC registers

2025-06-29 Thread Gustavo Romero
Add FEAT_MEC registers to the arm max cpu. To work properly, FEAT_MEC also depends on FEAT_SCTLR2 and FEAT_TCR2, which are not implemented in this commit. The bits in SCTLR2 and TCR2 control which translation regimes use MECIDs, and determine which MECID is selected. Signed-off-by: Gustavo

[PATCH 1/3] target/arm: Add the MECEn SCR_EL3 bit

2025-06-29 Thread Gustavo Romero
The MECEn bit in SCR_EL3 enables access to the EL2 MECID registers from EL2, so add it to the SCR mask list to use it later on. Signed-off-by: Gustavo Romero --- target/arm/cpu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 302c24e232..8ce30ca857

[WIP-for-10.1 0/3] target/arm: Add FEAT_MEC to max cpu

2025-06-29 Thread Gustavo Romero
heers, Gustavo Gustavo Romero (3): target/arm: Add the MECEn SCR_EL3 bit target/arm: Advertise FEAT_MEC in cpu max target/arm: Add FEAT_MEC registers docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 ++ target/arm/cpu.h | 15 ++ target/arm/helper.c

[PATCH 2/3] target/arm: Advertise FEAT_MEC in cpu max

2025-06-29 Thread Gustavo Romero
context is not possible. An encryption context allow the selection of a memory encryption engine. Signed-off-by: Gustavo Romero --- docs/system/arm/emulation.rst | 1 + target/arm/cpu-features.h | 5 + target/arm/tcg/cpu64.c| 1 + 3 files changed, 7 insertions(+) diff --git a/docs

[PATCH v6 1/9] hw/intc/gicv3_its: Do not check its_class_name()

2025-06-28 Thread Gustavo Romero
at use the its_class_name() returned value. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Reviewed-by: Eric Auger --- hw/arm/virt-acpi-build.c | 32 +++--- include/hw/intc/arm_gicv3_its_common.h | 2 +- 2 fil

[PATCH v6 6/9] qtest/bios-tables-test: Add test for when ITS is off on aarch64

2025-06-28 Thread Gustavo Romero
ITS-related data is correctly pruned from the ACPI tables. The new blobs for this test will be added in a following commit. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Gustavo Romero Reviewed-by: Eric Auger --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ tests/qtest/bios-t

[PATCH v6 8/9] hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables when its=off

2025-06-28 Thread Gustavo Romero
mmu_idmaps and rc_its_idmaps, respectively, to make it clearer which nodes are involved in the mappings associated with these variables. Reported-by: Udo Steinberg Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2886 Signed-off-by: Gustavo Romero Co-authored-by: Philippe Mathieu-Daudé -

[PATCH v6 7/9] qtest/bios-tables-test: Add blobs for its=off test on aarch64

2025-06-28 Thread Gustavo Romero
100 +[0DCh 0220 4] ID Count : FEFF +[0E0h 0224 4] Output Base : 0100 +[0E4h 0228 4] Output Reference : 0030 +[0E8h 0232 4]Flags (decoded below) : 0000 + Single Mapping : 0 Signed-off-by: Gustavo

[PATCH v6 9/9] qtest/bios-tables-test: Update blobs for its=off test on aarch64

2025-06-28 Thread Gustavo Romero
t base : +[09Ch 0156 4] ID Count : 00FF +[0A0h 0160 4] Output Base : +[0A4h 0164 4] Output Reference : 0030 +[0A8h 0168 4]Flags (decoded below) : Single Mapping : 0 Signed-off-by: Gusta

[PATCH v6 4/9] hw/arm/virt-acpi-build: Improve comment in build_iort

2025-06-28 Thread Gustavo Romero
actually defined in another table (in the SMMUv3 node). So change the comment to read "RC -> SMMUv3" instead. Signed-off-by Gustavo Romero Reviewed-by: Eric Auger --- hw/arm/virt-acpi-build.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git

[PATCH v6 2/9] hw/arm/virt: Simplify logic for setting instance's 'tcg_its' variable

2025-06-28 Thread Gustavo Romero
Because 'tcg_its' in the machine instance is set based on the machine class’s negated variable 'no_tcg_its', 'tcg_its' is the opposite of 'no_tcg_its' and hence the code in question can be simplified as: tcg_its = !no_tcg_its. Signed-off-by: Gustavo Rome

[PATCH v6 5/9] hw/arm/virt-acpi-build: Factor out create_its_idmaps

2025-06-28 Thread Gustavo Romero
Factor out a new function, create_its_idmaps(), from the current build_iort code. Add proper comments to it clarifying how the ID ranges that go directly to the ITS Group node are computed based on the ones that are directed to the SMMU node. Suggested-by: Eric Auger Signed-off-by: Gustavo

[PATCH v6 3/9] hw/arm/virt: Simplify create_its()

2025-06-28 Thread Gustavo Romero
From: Philippe Mathieu-Daudé No need to strstr() check the class name when we can use kvm_irqchip_in_kernel() to check if the ITS from the host can be used. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Reviewed-by: Gustavo Romero --- hw/arm

[PATCH-for-10.1 v6 0/9] hw/arm: GIC 'its=off' ACPI table fixes

2025-06-28 Thread Gustavo Romero
/2025-06/msg03793.html Fix ACPI tables for '-M its=off' CLI option and resolve the issue: https://gitlab.com/qemu-project/qemu/-/issues/2886 Cheers, Gustavo Gustavo Romero (6): hw/arm/virt: Simplify logic for setting instance's 'tcg_its' variable hw/arm/virt-acpi-b

Re: [PATCH v5 8/9] hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables when its=off

2025-06-28 Thread Gustavo Romero
Hi Eric, On 6/27/25 12:44, Eric Auger wrote: Hi Gustavo, On 6/23/25 3:57 PM, Gustavo Romero wrote: Currently, the ITS Group nodes in the IORT table and the GIC ITS Struct in the MADT table are always generated, even if GIC ITS is not available on the machine. This commit fixes it by not

Re: [PATCH v5 5/9] hw/arm/virt-acpi-build: Factor out create_its_idmaps

2025-06-28 Thread Gustavo Romero
Hi Eric, Thanks a lot for another round of reviews :) On 6/27/25 12:28, Eric Auger wrote: Hi Gustavo, On 6/23/25 3:57 PM, Gustavo Romero wrote: Factor out a new function, create_its_idmaps(), from the current I would call it build_rc_its_idmap() to be clearer on what relationship we build

Re: [PATCH-for-10.1 v4 0/8] hw/arm: GIC 'its=off' ACPI table fixes

2025-06-23 Thread Gustavo Romero
Hi Eric, On 6/17/25 10:26, Eric Auger wrote: Hi Gustavo, On 6/17/25 3:01 PM, Gustavo Romero wrote: Hi Eric, Thanks a lot for doing a first pass on this series! On 6/17/25 06:35, Eric Auger wrote: Hi Gustavo, On 6/16/25 3:18 PM, Gustavo Romero wrote: Since v2: - Fixed no_tcg_its inverted

[PATCH v5 8/9] hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables when its=off

2025-06-23 Thread Gustavo Romero
ned-off-by: Gustavo Romero Co-authored-by: Philippe Mathieu-Daudé --- hw/arm/virt-acpi-build.c| 128 tests/qtest/bios-tables-test-allowed-diff.h | 2 + 2 files changed, 80 insertions(+), 50 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm

[PATCH v5 5/9] hw/arm/virt-acpi-build: Factor out create_its_idmaps

2025-06-23 Thread Gustavo Romero
Factor out a new function, create_its_idmaps(), from the current build_iort code. Add proper comments to it clarifying how the ID ranges that go directly to the ITS Group node are computed based on the ones that go to the SMMU node. Suggested-by: Eric Auger Signed-off-by: Gustavo Romero --- hw

[PATCH v5 4/9] hw/arm/virt-acpi-build: Improve comment in build_iort

2025-06-23 Thread Gustavo Romero
actually defined in another table (in the SMMUv3 node). So change the comment to read "RC -> SMMUv3" instead. Signed-off-by Gustavo Romero --- hw/arm/virt-acpi-build.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/hw/arm/virt-acpi-build

[PATCH v5 9/9] qtest/bios-tables-test: Update blobs for its=off test on aarch64

2025-06-23 Thread Gustavo Romero
t base : +[09Ch 0156 4] ID Count : 00FF +[0A0h 0160 4] Output Base : +[0A4h 0164 4] Output Reference : 0030 +[0A8h 0168 4]Flags (decoded below) : Single Mapping : 0 Signed-off-by: Gust

[PATCH v5 6/9] qtest/bios-tables-test: Add test for when ITS is off on aarch64

2025-06-23 Thread Gustavo Romero
ITS-related data is correctly pruned from the ACPI tables. The new blobs for this test will be added in a following commit. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Gustavo Romero --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ tests/qtest/bios-tables-test.c | 21

[PATCH v5 2/9] hw/arm/virt: Simplify logic for setting instance's 'tcg_its' variable

2025-06-23 Thread Gustavo Romero
Because 'tcg_its' in the machine instance is set based on the machine class’s negated variable 'no_tcg_its', 'tcg_its' is the opposite of 'no_tcg_its' and hence the code in question can be simplified as: tcg_its = !no_tcg_its. Signed-off-by: Gustavo Rome

[PATCH-for-10.1 v5 0/9] hw/arm: GIC 'its=off' ACPI table fixes

2025-06-23 Thread Gustavo Romero
06/msg02583.html Fix ACPI tables for '-M its=off' CLI option and resolve the issue: https://gitlab.com/qemu-project/qemu/-/issues/2886 Cheers, Gustavo Gustavo Romero (6): hw/arm/virt: Simplify logic for setting instance's 'tcg_its' variable hw/arm/virt-acpi-build: Impr

[PATCH v5 7/9] qtest/bios-tables-test: Add blobs for its=off test on aarch64

2025-06-23 Thread Gustavo Romero
100 +[0DCh 0220 4] ID Count : FEFF +[0E0h 0224 4] Output Base : 0100 +[0E4h 0228 4] Output Reference : 0030 +[0E8h 0232 4]Flags (decoded below) : 0000 + Single Mapping : 0 Signed-off-by: Gusta

[PATCH v5 3/9] hw/arm/virt: Simplify create_its()

2025-06-23 Thread Gustavo Romero
From: Philippe Mathieu-Daudé No need to strstr() check the class name when we can use kvm_irqchip_in_kernel() to check if the ITS from the host can be used. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Reviewed-by: Gustavo Romero --- hw/arm

[PATCH v5 1/9] hw/intc/gicv3_its: Do not check its_class_name()

2025-06-23 Thread Gustavo Romero
at use the its_class_name() returned value. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Reviewed-by: Eric Auger --- hw/arm/virt-acpi-build.c | 32 +++--- include/hw/intc/arm_gicv3_its_common.h | 2 +- 2 fil

Re: [PATCH v4 4/8] hw/arm/virt-acpi-build: Fix comment in build_iort

2025-06-19 Thread Gustavo Romero
Hi Eric, On 6/17/25 10:22, Eric Auger wrote: Hi Gustavo, On 6/16/25 3:18 PM, Gustavo Romero wrote: The comment about the mapping from SMMU to ITS is incorrect and it reads "RC -> ITS". The code in question actually maps SMMU -> ITS, so the mapping in question is not direct. Th

Re: [PATCH v4 5/8] qtest/bios-tables-test: Add test for when ITS is off on aarch64

2025-06-17 Thread Gustavo Romero
Hi Eric, On 6/17/25 12:51, Eric Auger wrote: On 6/17/25 5:12 PM, Gustavo Romero wrote: Hi Eric, On 6/17/25 10:34, Eric Auger wrote: Hi Gustavo, On 6/16/25 3:18 PM, Gustavo Romero wrote: From: Philippe Mathieu-Daudé Arm64 GIC ITS (Interrupt Translation Service) is an optional piece of

Re: [PATCH v4 5/8] qtest/bios-tables-test: Add test for when ITS is off on aarch64

2025-06-17 Thread Gustavo Romero
Hi Eric, On 6/17/25 12:51, Eric Auger wrote: On 6/17/25 5:12 PM, Gustavo Romero wrote: Hi Eric, On 6/17/25 10:34, Eric Auger wrote: Hi Gustavo, On 6/16/25 3:18 PM, Gustavo Romero wrote: From: Philippe Mathieu-Daudé Arm64 GIC ITS (Interrupt Translation Service) is an optional piece of

Re: [PATCH-for-10.1 v4 0/8] hw/arm: GIC 'its=off' ACPI table fixes

2025-06-17 Thread Gustavo Romero
Hi Eric, Thanks a lot for doing a first pass on this series! On 6/17/25 06:35, Eric Auger wrote: Hi Gustavo, On 6/16/25 3:18 PM, Gustavo Romero wrote: Since v2: - Fixed no_tcg_its inverted logic (rth) Since v3: - Fixed remappings in the IORT table when ITS is no present - Rebased on master

Re: [PATCH v5] tests/functional: Add PCI hotplug test for aarch64

2025-06-17 Thread Gustavo Romero
Hi Alex, On 6/17/25 06:49, Alex Bennée wrote: Gustavo Romero writes: Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and hot-unplug on arm64. Queued to testing/next, thanks. Thanks a lot! Cheers, Gustavo

Re: [PATCH v4 5/8] qtest/bios-tables-test: Add test for when ITS is off on aarch64

2025-06-17 Thread Gustavo Romero
Hi Eric, On 6/17/25 10:34, Eric Auger wrote: Hi Gustavo, On 6/16/25 3:18 PM, Gustavo Romero wrote: From: Philippe Mathieu-Daudé Arm64 GIC ITS (Interrupt Translation Service) is an optional piece of hardware introduced in GICv3 and, being optional, it can be disabled in QEMU aarch64 VMs that

Re: [PATCH v4 1/8] hw/intc/gicv3_its: Do not check its_class_name()

2025-06-16 Thread Gustavo Romero
Hi Phil, On 6/16/25 10:33, Philippe Mathieu-Daudé wrote: Hi Gustavo, why reset authorship? It was not intentional. hmm maybe it changed because I tweaked the commit message and the code due to rebasing as well? Do you know how to restore it? Cheers, Gustavo On 16/6/25 15:18, Gustavo

[PATCH v4 3/8] hw/arm/virt: Simplify create_its()

2025-06-16 Thread Gustavo Romero
No need to strstr() check the class name when we can use kvm_irqchip_in_kernel() to check if the ITS from the host can be used. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Eric Auger Reviewed-by: Gustavo Romero --- hw/arm/virt.c | 17 +++-- 1

[PATCH v4 1/8] hw/intc/gicv3_its: Do not check its_class_name()

2025-06-16 Thread Gustavo Romero
rned value. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Reviewed-by: Eric Auger --- hw/arm/virt-acpi-build.c | 32 +++--- include/hw/intc/arm_gicv3_its_common.h | 2 +- 2 files changed, 15 insertions(+), 19

[PATCH v4 8/8] qtest/bios-tables-test: Update blobs for its=off test on aarch64

2025-06-16 Thread Gustavo Romero
t base : +[09Ch 0156 4] ID Count : 00FF +[0A0h 0160 4] Output Base : +[0A4h 0164 4] Output Reference : 0030 +[0A8h 0168 4]Flags (decoded below) : Single Mapping : 0 Signed-off-by: Gust

[PATCH v4 2/8] hw/arm/virt: Simplify logic for setting instance's 'tcg_its' variable

2025-06-16 Thread Gustavo Romero
Because 'tcg_its' in the machine instance is set based on the machine class’s negated variable 'no_tcg_its', 'tcg_its' is the opposite of 'no_tcg_its' and hence the code in question can be simplified as: tcg_its = !no_tcg_its. Signed-off-by: Gustavo Romero

[PATCH v4 7/8] hw/arm/virt-acpi-build: Fix ACPI IORT and MADT tables when its=off

2025-06-16 Thread Gustavo Romero
ned-off-by: Gustavo Romero Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/virt-acpi-build.c| 152 tests/qtest/bios-tables-test-allowed-diff.h | 2 + 2 files changed, 93 insertions(+), 61 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm

[PATCH v4 5/8] qtest/bios-tables-test: Add test for when ITS is off on aarch64

2025-06-16 Thread Gustavo Romero
lated data is correctly pruned from the ACPI tables. The new blobs for this test will be added in a following commit. Signed-off-by: Gustavo Romero Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/bios-tables-test-allowed-diff.h | 2 ++ tests/qtest/bios-tables-test.c | 21

[PATCH-for-10.1 v4 0/8] hw/arm: GIC 'its=off' ACPI table fixes

2025-06-16 Thread Gustavo Romero
.org/archive/html/qemu-devel/2025-04/msg00567.html Fix ACPI tables for '-M its=off' CLI option and resolve the issue: https://gitlab.com/qemu-project/qemu/-/issues/2886 Cheers, Gustavo Gustavo Romero (7): hw/intc/gicv3_its: Do not check its_class_name() hw/arm/virt: Simplify logi

[PATCH v4 4/8] hw/arm/virt-acpi-build: Fix comment in build_iort

2025-06-16 Thread Gustavo Romero
ck, and we take the opportunity to update that as well, adding "RC -> ITS" to the text so it's easier to see it's the direct map to the ITS Group node. Signed-off-by Gustavo Romero --- hw/arm/virt-acpi-build.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-)

[PATCH v4 6/8] qtest/bios-tables-test: Add blobs for its=off test on aarch64

2025-06-16 Thread Gustavo Romero
100 +[0DCh 0220 4] ID Count : FEFF +[0E0h 0224 4] Output Base : 0100 +[0E4h 0228 4] Output Reference : 0030 +[0E8h 0232 4]Flags (decoded below) : 0000 + Single Mapping : 0 Signed-off-by: Gusta

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-13 Thread Gustavo Romero
Hi Eric, On 6/13/25 02:05, Eric Auger wrote: Hi Gustavo, On 6/13/25 5:01 AM, Gustavo Romero wrote: Hi Eric, On 6/12/25 09:55, Igor Mammedov wrote: On Wed, 11 Jun 2025 10:50:04 +0200 Eric Auger wrote: Hi Igor, On 6/11/25 10:45 AM, Igor Mammedov wrote: On Wed, 11 Jun 2025 08:53:28 +0200

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-12 Thread Gustavo Romero
Hi Eric, On 6/12/25 09:55, Igor Mammedov wrote: On Wed, 11 Jun 2025 10:50:04 +0200 Eric Auger wrote: Hi Igor, On 6/11/25 10:45 AM, Igor Mammedov wrote: On Wed, 11 Jun 2025 08:53:28 +0200 Eric Auger wrote: Hi Gustavo, Alex, On 5/28/25 12:33 PM, Igor Mammedov wrote: On Tue, 27 May 2025

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-06-11 Thread Gustavo Romero
Hi Igor, On 6/11/25 05:54, Igor Mammedov wrote: On Tue, 10 Jun 2025 11:29:02 -0300 Gustavo Romero wrote: Hi Igor, On 6/2/25 03:06, Gustavo Romero wrote: Hi Igor and Eric, I'm sending again this to the mailing list since it seems the first one got lost... I can't find it eith

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-06-10 Thread Gustavo Romero
Hi Igor, On 6/2/25 03:06, Gustavo Romero wrote: Hi Igor and Eric, I'm sending again this to the mailing list since it seems the first one got lost... I can't find it either in qemu-devel@ or in qemu-arm@ :( On 5/30/25 08:51, Igor Mammedov wrote: On Wed, 28 May 2025 12:04:26 -03

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-06-01 Thread Gustavo Romero
Hi Eric, On 5/28/25 06:48, Eric Auger wrote: Hi Igor, On 5/28/25 11:38 AM, Igor Mammedov wrote: On Tue, 27 May 2025 09:40:26 +0200 Eric Auger wrote: From: Gustavo Romero ACPI PCI hotplug is now turned on by default so we need to change the existing tests to keep it off. However, even

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-06-01 Thread Gustavo Romero
Hi Igor and Eric, I'm sending again this to the mailing list since it seems the first one got lost... I can't find it either in qemu-devel@ or in qemu-arm@ :( On 5/30/25 08:51, Igor Mammedov wrote: On Wed, 28 May 2025 12:04:26 -0300 Gustavo Romero wrote: Hi Igor, On 5/28/25 1

Re: [PATCH v2 24/25] tests/qtest/bios-tables-test: Keep ACPI PCI hotplug off

2025-06-01 Thread Gustavo Romero
Hi Igor and Eric, On 5/30/25 08:51, Igor Mammedov wrote: On Wed, 28 May 2025 12:04:26 -0300 Gustavo Romero wrote: Hi Igor, On 5/28/25 10:02, Igor Mammedov wrote: On Wed, 28 May 2025 09:41:15 -0300 Gustavo Romero wrote: Hi Igor, On 5/28/25 06:38, Igor Mammedov wrote: On Tue, 27 May

Re: [PATCH v2 08/25] tests/qtest/bios-tables-test: Prepare for changes in the DSDT table

2025-06-01 Thread Gustavo Romero
Hi Igor and Eric, On 5/27/25 10:03, Igor Mammedov wrote: On Tue, 27 May 2025 14:38:16 +0200 Igor Mammedov wrote: On Tue, 27 May 2025 09:40:10 +0200 Eric Auger wrote: From: Gustavo Romero This commit adds DSDT blobs to the whilelist in the prospect to allow changes in the GPEX _OSC

Re: [PATCH] tests/functional/test_aarch64_hotplug_pci: Update images

2025-05-28 Thread Gustavo Romero
Hi Thomas, On 5/28/25 09:11, Gustavo Romero wrote: Hi Thomas, On 5/28/25 04:57, Thomas Huth wrote: On 28/05/2025 03.47, Gustavo Romero wrote: The current links for the Linux and initrd.gz images are not truly immutable, so let's change them to point to immutable versions, to avoid havi

[PATCH v5] tests/functional: Add PCI hotplug test for aarch64

2025-05-28 Thread Gustavo Romero
Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and hot-unplug on arm64. Signed-off-by: Gustavo Romero Reviewed-by: Daniel P. Berrangé Acked-by: Thomas Huth --- MAINTAINERS | 6 ++ tests/functional/meson.build | 1 + tests

  1   2   3   4   5   6   >