[Qemu-devel] [PATCH] vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation

2014-09-11 Thread damarion
From: Damjan Marion Header length check should happen only if backend is kernel. For user backend there is no reason to reset this bit. vhost-user code does not define .has_vnet_hdr_len so VIRTIO_NET_F_MRG_RXBUF cannot be negotiated even if both sides support it. Signed-off-by: Damjan Marion -

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 13:37, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 11:35:13AM +, Damjan Marion (damarion) wrote: >> >> On 26 Jun 2014, at 13:30, Michael S. Tsirkin wrote: >> >>> On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: >&g

Re: [Qemu-devel] [PATCH v2] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 13:30, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 12:22:59PM +0200, Damjan Marion wrote: >> Old code was affected by memory gaps which >> resulted in buffer pointers pointing to >> address outside of the mapped regions. >> >> Signed-off-by: Damjan Marion >> --- > >

Re: [Qemu-devel] [PATCH] vhost-user: fix VHOST_USER_SET_MEM_TABLE

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 10:01, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 09:55:03AM +0200, Damjan Marion wrote: >> Old code was affected by memory gaps which >> resulted in buffer pointers pointing to >> address outside of the mapped regions. >> >> Signed-off-by: Damjan Marion >> --- >> d

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 09:56, Michael S. Tsirkin wrote: > On Thu, Jun 26, 2014 at 07:44:24AM +, Damjan Marion (damarion) wrote: >> >> On 26 Jun 2014, at 09:13, Michael S. Tsirkin wrote: >> >>> On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wr

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-26 Thread Damjan Marion (damarion)
On 26 Jun 2014, at 09:13, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 09:52:09PM +, Damjan Marion (damarion) wrote: >> >> On 25 Jun 2014, at 18:44, Paolo Bonzini wrote: >> >>>> nregions: 4 >>>> region: >>>>

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 18:44, Paolo Bonzini wrote: >> nregions: 4 >> region: >> gpa = 0x1 >> size = 3221225472 >> ua = 0x2aab6ac0 > > High memory, above 3 gigabytes. > >> region: >> gpa = 0xFFFC >> size = 262144 >> ua = 0x7fc13d20 > > This is the

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 20:18, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 09:13:36PM +0300, Nikolay Nikolaev wrote: >> On Wed, Jun 25, 2014 at 9:07 PM, Michael S. Tsirkin wrote: >>> On Wed, Jun 25, 2014 at 07:56:46PM +0300, Nikolay Nikolaev wrote: On Wed, Jun 25, 2014 at 7:44 PM, Paolo

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 17:50, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 03:46:04PM +, Damjan Marion (damarion) wrote: >> >> On 25 Jun 2014, at 17:29, Michael S. Tsirkin wrote: >> >>> On Wed, Jun 25, 2014 at 02:57:52PM +, Damjan Marion (damarion) wr

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 17:29, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 02:57:52PM +, Damjan Marion (damarion) wrote: >> >> On 25 Jun 2014, at 16:27, Michael S. Tsirkin wrote: >> >>> On Wed, Jun 25, 2014 at 02:20:56PM +, Damjan Marion (damarion) wr

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 16:27, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 02:20:56PM +, Damjan Marion (damarion) wrote: >> >> On 25 Jun 2014, at 16:13, Nikolay Nikolaev >> wrote: >> >>>>> - it will require changes on the user side also

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 16:13, Nikolay Nikolaev wrote: > >> - it will require changes on the user side also > > > > why would it? > > format seems unchanged, right? > > yes, but it will happen that multiple regions have same FD so call to mmap() > should look different, I’m still playing with this

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 16:06, Nikolay Nikolaev wrote: > +msg.memory.regions[fd_num].memory_size = reg->memory_size; > so this is size > +msg.memory.regions[fd_num].guest_phys_addr = > reg->memory_size; > and this is size again? mistake, i alredy noticed it. It

Re: [Qemu-devel] vhost-user: broken mem regions

2014-06-25 Thread Damjan Marion (damarion)
On 25 Jun 2014, at 15:53, Michael S. Tsirkin wrote: > On Wed, Jun 25, 2014 at 01:45:09PM +, Damjan Marion (damarion) wrote: >> >> Michael, >> >> there is another issue with commited vhost-user code. > > I'm answering just this once, but I have a po

[Qemu-devel] qemu crashes on Mac OS X

2011-07-01 Thread Damjan Marion (damarion)
Hi, I have an issue when I try to run qemu-system-arm on Mac OS X. Sometime between 1 and 15 secs after qemu is started it crashes as shown bellow. Same thing on linux host works fine. Is anybody else experiencing this? Any Hints? Thanks, Damjan (gdb) run Starting program: /opt/arm-qemu/b