--- On Thu, 1/9/11, Avi Kivity wrote:
> On 08/31/2011 04:05 AM, bifferos
> wrote:
> > + pci_register_bar(&s->dev, 0,
> 0x100, PCI_BASE_ADDRESS_SPACE_IO, r6040_map);
> pci_register_bar() has been converted to the memory
> API. Please rebase to the latest qem
--- On Wed, 31/8/11, Blue Swirl wrote:
> I agree about importance of consistency, though I'd even go
> further and reformat globally. New code gets introduced
> based on copying old code so the pain goes on.
I think this is the most important point.
I've worked on many projects where coding s
Here it is again with copyright, typo fix and hopefully now complying with
coding standards.
Signed-off-by: Mark Kelly
diff --git a/Makefile.objs b/Makefile.objs
index 6991a9f..7d87503 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -240,6 +240,7 @@ hw-obj-$(CONFIG_PCNET_PCI) += pcnet-pci.o
--- On Wed, 31/8/11, malc wrote:
> From: malc
> Subject: Re: [Qemu-devel] [PATCH] Add support for r6040 NIC
> To: "Anthony Liguori"
> Cc: qemu-devel@nongnu.org, "bifferos"
> Date: Wednesday, 31 August, 2011, 14:17
> On Tue, 30 Aug 2011, Anthony Liguori
Signed-off-by: Mark Kelly
diff --git a/Makefile.objs b/Makefile.objs
index 6991a9f..7d87503 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -240,6 +240,7 @@ hw-obj-$(CONFIG_PCNET_PCI) += pcnet-pci.o
hw-obj-$(CONFIG_PCNET_COMMON) += pcnet.o
hw-obj-$(CONFIG_E1000_PCI) += e1000.o
hw-obj-$(CONFI
