Re: [PATCH v4] qemu-img: Fix Column Width and Improve Formatting in snapshot list

2024-02-23 Thread atp exp
On Tue, 23 Jan 2024 at 10:34, Abhiram Tilak wrote: > > When running the command `qemu-img snapshot -l SNAPSHOT` the output of > VM_CLOCK (measures the offset between host and VM clock) cannot to > accommodate values in the order of thousands (4-digit). > > This line [1] hints on the problem. Addit

Re: [PATCH 1/3] misc: m48t59: replace qemu_system_reset_request() call with watchdog_perform_action()

2024-02-16 Thread atp exp
I agree, comment here is redundant, i will fix it in the next patch. Abhiram On Fri, 16 Feb 2024 at 20:19, Peter Maydell wrote: > On Fri, 16 Feb 2024 at 13:56, Abhiram Tilak wrote: > > > > A few watchdog devices use qemu_system_reset_request(). This is not > ideal since > > behaviour of watchd

Re: [PATCH 3/3] misc: ppc/spapr: replace qemu_system_reset_request() calls with watchdog_perform_action()

2024-02-16 Thread atp exp
I will exclude this patch from the series for now. According to the discussions, the current code honours the guest's preference. Will wait for the enhancements needed in watchdog QAPI. Abhiram On Fri, 16 Feb 2024 at 20:24, Peter Maydell wrote: > On Fri, 16 Feb 2024 at 13:56, Abhiram Tilak wro

Re: [PATCH v3] qemu-img: Fix Column Width and Improve Formatting in snapshot list

2024-01-22 Thread atp exp
Alright, right now there are 10 digits for ID, don't think a billion snapshots are feasible anyway. > Maybe what we should also do is decreasing the width of each field by > one and instead writing a space character into the format string. I'm assuming you are talking about adding spaces between

Re: [PATCH v2] qemu-img: Fix Column Width and Improve Formatting in snapshot list

2024-01-11 Thread atp exp
Changes from v2: - Change email provider to 'gmail', to prevent auto-wrapping patches. - Change more unit tests in 'tests/qemu-iotests/tests/qcow2-internal-snapshots.out' On Thu, 11 Jan 2024 at 10:39, Abhiram Tilak wrote: > When running the command `qemu-img snapshot -l SNAPSHOT` the output of >