Re: [RFC PATCH v13 4/4] s390: implementing CHSC SEI for AP config change

2025-06-27 Thread Anthony Krowiak
Sure On 6/27/25 11:12 AM, Matthew Rosato wrote: AFAICT this portion of the handler including mutex should be moved out of ap.c into chsc_sei_nt0_get_event().  When vfio_ap is not in use, we can't call into it.  Can't you also build without VFIO_AP?  I didn't try it but that sure seems like it

Re: [RFC PATCH v13 4/4] s390: implementing CHSC SEI for AP config change

2025-06-27 Thread Anthony Krowiak
such circumstance. Also added the following to hw/s390x/meson.build if CONFIG_VFIO_AP is false, it will use the stub file. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Reviewed-by: Cédric Le Goater FYI, this patch (or some part of this series) breaks hotplug for PCI devices on s390

Re: [RFC PATCH v12 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-06-09 Thread Anthony Krowiak
On 6/6/25 2:37 PM, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak

Re: [RFC PATCH v12 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-06-09 Thread Anthony Krowiak
-off-by: Rorie Reyes See comment below. With that change made: Reviewed-by: Anthony Krowiak --- hw/vfio/ap.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 93c74ebedb..fc435f5c5b 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -41,6 +41,13

Re: [RFC PATCH v11 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-06-06 Thread Anthony Krowiak
On 6/5/25 1:57 PM, Rorie Reyes wrote: On 6/4/25 9:47 AM, Anthony Krowiak wrote: On 6/3/25 4:30 PM, Cédric Le Goater wrote: On 6/3/25 20:01, Rorie Reyes wrote: On 6/3/25 10:21 AM, Cédric Le Goater wrote: On 6/3/25 14:58, Rorie Reyes wrote: Hey Cedric, You mentioned the following in

Re: [RFC PATCH v11 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-06-04 Thread Anthony Krowiak
a assert(bql_locked()) statement where we think the bql should be protecting access to shared resources. " Does this still apply down bellow? Anthony replied : https://lore.kernel.org/qemu-devel/ed2a2aa3-68a7-480c-a6a4-a8219af12...@linux.ibm.com/ Thanks, C. So we'll still use

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-27 Thread Anthony Krowiak
On 5/26/25 4:43 AM, Cédric Le Goater wrote: On 5/22/25 20:55, Anthony Krowiak wrote: On 5/22/25 9:30 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests

Re: [PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-26 Thread Anthony PERARD
_chk (__pri, __USE_FORTIFY_LEVEL - 1, __fmt, __va_arg_pack > ()); > | > ^~ > > Add a check that 'value' is not null before passing it to > trace_xs_node_read(). > > Fixes: e6cdeee95990 ("hw/xen: Add x

Re: [RFC PATCH v10 4/4] s390: implementing CHSC SEI for AP config change

2025-05-23 Thread Anthony Krowiak
to hw/s390x/meson.build if CONFIG_VFIO_AP is false, it will use the stub file. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Reviewed-by: Cédric Le Goater --- MAINTAINERS | 1 + hw/s390x/ap-stub.c| 25 + hw/s390x/meson.build | 1 + target/

Re: [RFC PATCH v10 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-23 Thread Anthony Krowiak
On 5/23/25 12:47 AM, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Anthony Krowiak
On 5/22/25 9:30 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Anthony Krowiak
On 5/22/25 1:17 PM, Rorie Reyes wrote: On 5/22/25 9:30 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct pr

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-22 Thread Anthony Krowiak
On 5/22/25 9:35 AM, Cédric Le Goater wrote: On 5/12/25 20:02, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie

Re: [RFC PATCH v9 3/4] hw/vfio/ap: Storing event information for an AP configuration change event

2025-05-13 Thread Anthony Krowiak
On 5/12/25 2:02 PM, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak

Re: [RFC PATCH v9 4/4] s390: implementing CHSC SEI for AP config change

2025-05-13 Thread Anthony Krowiak
s390x/meson.build if CONFIG_VFIO_AP is false, it will use the stub file. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak --- MAINTAINERS | 1 + hw/s390x/ap-stub.c| 25 + hw/s390x/meson.build | 1 + target/s390x/ioinst.c | 11 +-

Re: [RFC PATCH v9 2/4] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-13 Thread Anthony Krowiak
-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak --- hw/vfio/ap.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 3d0af7a54a..5ea5dd9cca 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -41,6 +41,13 @@ struct VFIOAPDevice

Re: [PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-05-01 Thread Anthony Krowiak
On 4/30/25 3:39 PM, John Levon wrote: Add a helper similar to vfio_device_get_region_info() and use it everywhere. Replace a couple of needless allocations with stack variables. As a side-effect, this fixes a minor error reporting issue in the call from vfio_msix_early_setup(). Reviewed-by

Re: [PATCH v6 13/18] system/xen: remove inline stubs

2025-03-19 Thread Anthony PERARD
On Mon, Mar 17, 2025 at 11:34:12AM -0700, Pierrick Bouvier wrote: > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Pierrick Bouvier Reviewed-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech

Re: [RFC PATCH v3 3/5] hw/vfio/ap: store object indicating AP config changed in a queue

2025-03-15 Thread Anthony Krowiak
On 3/10/25 11:35 AM, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-o

Re: [PATCH v5 00/17] make system memory API available for common code

2025-03-14 Thread Anthony PERARD
On Fri, Mar 14, 2025 at 10:33:08AM -0700, Pierrick Bouvier wrote: > Hi, > > one patch is missing review: > [PATCH v5 12/17] hw/xen: add stubs for various functions. My "Acked-by" wasn't enough? Feel free try change it to "Reviewed-by" instead. Cheers

Re: [PATCH v4 12/17] hw/xen: add stubs for various functions

2025-03-14 Thread Anthony PERARD
e_map_cache(void) > +{ Is this stub actually necessary? xen_invalidate_map_cache() doesn't seems to be used outside of xen's code. In anycase: Acked-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech

[PATCH 2/2] target/i386/kvm: Change error_report() to tracepoint in vmsr_read_thread_stat()

2025-03-13 Thread Anthony Harivel
Threads in QEMU are frequently created and destroyed, leading to non-critical errors. Replace `error_report()` with a tracepoint to prevent flooding the serial terminal with non-essential error messages. Signed-off-by: Anthony Harivel --- target/i386/kvm/trace-events | 3 +++ target/i386/kvm

[PATCH 0/2] Add AMD CPU for RAPL MSR support

2025-03-13 Thread Anthony Harivel
I added a second patch to silence an error that is not really an error. I change it to a tracepoint following Daniel advice. Thanks Daniel ! Thanks Anthony Anthony Harivel (2): target/i386/kvm: add AMD support for RAPL MSR target/i386/kvm: Change error_report() to tra

[PATCH 1/2] target/i386/kvm: add AMD support for RAPL MSR

2025-03-13 Thread Anthony Harivel
counterparts. Integrate the first two MSRs to align with the current RAPL MSR implementation. Automatically detect the host CPU at runtime and select the appropriate MSRs. Signed-off-by: Anthony Harivel --- docs/specs/rapl-msr.rst | 21 --- include/system/kvm_int.h | 4 ++ target/i386

Re: [RFC PATCH v4 3/5] hw/vfio/ap: store object indicating AP config changed in a queue

2025-03-12 Thread Anthony Krowiak
-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak --- hw/vfio/ap.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 3614657218..3fa986ca45 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -41,6 +41,13 @@ struct VFIOAPDevice

Re: [RFC PATCH v4 4/5] hw/vfio/ap: Storing event information for an AP configuration change event

2025-03-12 Thread Anthony Krowiak
On 3/11/25 11:16 AM, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak

Re: [RFC PATCH v3 2/5] hw/vfio/ap: notification handler for AP config changed event

2025-03-11 Thread Anthony Krowiak
On 3/10/25 11:35 AM, Rorie Reyes wrote: Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes LGTM: Reviewed-by: Anthony Krowiak --- hw

[PULL 1/3] xen/passthrough: use gsi to map pirq when dom0 is PVH

2025-03-11 Thread Anthony PERARD
so pirq mapping fails. To solve above problem, use new interface of Xen, xc_pcidev_get_gsi to get gsi and use xc_physdev_map_pirq_gsi to map pirq when dom0 is PVH. Signed-off-by: Jiqian Chen Signed-off-by: Huang Rui Signed-off-by: Jiqian Chen Acked-by: Anthony PERARD Reviewed-by: Stewart Hildebr

[PULL 0/3] xen queue 2025-03-10

2025-03-11 Thread Anthony PERARD
anged, 66 insertions(+), 1 deletion(-) Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech

[PULL 2/3] hw/xen: Add "mode" parameter to xen-block devices

2025-03-11 Thread Anthony PERARD
From: David Woodhouse Block devices don't work in PV Grub (0.9x) if there is no mode specified. It complains: "Error ENOENT when reading the mode" Signed-off-by: David Woodhouse Message-Id: <20250207143724.30792-2-dw...@infradead.org> Signed-off-by: Anthony PERARD ---

[PULL 3/3] xen: No need to flush the mapcache for grants

2025-03-11 Thread Anthony PERARD
;t do that. So remove the function call. Fixes: 9ecdd4bf08 (xen: mapcache: Add support for grant mappings) Cc: qemu-sta...@nongnu.org Reported-by: Olaf Hering Reviewed-by: Edgar E. Iglesias Signed-off-by: Stefano Stabellini Signed-off-by: Edgar E. Iglesias Reviewed-by: Anthony PERARD Messa

Re: [RFC PATCH v3 4/5] hw/vfio/ap: Storing event information for an AP configuration change event

2025-03-11 Thread Anthony Krowiak
On 3/10/25 11:35 AM, Rorie Reyes wrote: These functions can be invoked by the function that handles interception of the CHSC SEI instruction for requests indicating the accessibility of one or more adjunct processors has changed. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c

Re: [PATCH v1 1/1] xen: No need to flush the mapcache for grants

2025-03-07 Thread Anthony PERARD
ed-by: Edgar E. Iglesias > Signed-off-by: Stefano Stabellini > Signed-off-by: Edgar E. Iglesias Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [RFC PATCH v2 2/5] hw/vfio/ap: notification handler for AP config changed event

2025-03-07 Thread Anthony Krowiak
On 2/4/25 12:07 PM, Rorie Reyes wrote: Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 29 +++

Re: [RFC PATCH v2 3/5] hw/vfio/ap: store object indicating AP config changed in a queue

2025-03-07 Thread Anthony Krowiak
On 2/4/25 12:07 PM, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-of

Re: [PATCH 2/2] hw/xen: Add "mode" parameter to xen-block devices

2025-03-07 Thread Anthony PERARD
On Fri, Feb 07, 2025 at 02:37:24PM +, David Woodhouse wrote: > From: David Woodhouse > > Block devices don't work in PV Grub (0.9x) if there is no mode specified. It > complains: "Error ENOENT when reading the mode" > > Signed-off-by: David Woodhouse Rev

Re: [PATCH 6/8] hw/xen/xen-bus: Reduce included headers

2025-02-28 Thread Anthony PERARD
On Tue, Feb 18, 2025 at 05:26:16PM +0100, Philippe Mathieu-Daudé wrote: > Have "hw/xen/xen-bus" include the bare minimal set of headers. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 8/8] meson: Remove support for Xen on 32-bit ARM hosts

2025-02-28 Thread Anthony PERARD
#x27;''''''''''''''''''''''''''''''''''''' > + > +Untested for more than 4 years. Well, not quite, we used to have some test of Xen on armhf hosts (one of arndale or cubietrunk, I don't remember which one we had to stop and never start testing again) until last year, and that included tests with qcow2 disk, so using QEMU. But that testing infra is gone so the patch is fine: Reviewed-by: Anthony PERARD Cheers, -- Anthony PERARD

Re: [PATCH 7/8] hw/xen/xen-legacy-backend: Remove unused 'net/net.h' header

2025-02-28 Thread Anthony PERARD
On Tue, Feb 18, 2025 at 05:26:17PM +0100, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 5/8] hw/xen/xen-hvm: Reduce included headers

2025-02-28 Thread Anthony PERARD
> hw/i386/xen/xen-hvm.c:492:15: error: ‘R_EAX’ undeclared (first use in this > function) > 492 | env->regs[R_EAX] = req->data; > | ^ > | REG_RAX > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH v4] vfio: Add property documentation

2025-02-25 Thread Anthony Krowiak
;); +#ifdef CONFIG_IOMMUFD +object_class_property_set_description(klass, /* 9.0 */ + "iommufd", + "Set host IOMMUFD backend device"); +#endif } static const TypeInfo vfio_ap_info = { For ap.c: Reviewed-by: Anthony Krowiak

Re: [PATCH v1 3/5] hw/vfio/ap: store object indicating AP config changed in a queue

2025-02-03 Thread Anthony Krowiak
-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Tested-by: Anthony Krowiak --- hw/vfio/ap.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 533cadb2dd..508c6eed7a 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -41,6 +41,13 @@ struct

Re: [PATCH v1 3/5] hw/vfio/ap: store object indicating AP config changed in a queue

2025-01-27 Thread Anthony Krowiak
-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Tested-by: Anthony Krowiak --- hw/vfio/ap.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index 533cadb2dd..508c6eed7a 100644 --- a/hw/vfio/ap.c +++ b/hw/vfio/ap.c @@ -41,6 +41,13 @@ struct

Re: [PATCH v1 2/5] hw/vfio/ap: notification handler for AP config changed event

2025-01-15 Thread Anthony Krowiak
On 1/7/25 1:43 PM, Rorie Reyes wrote: Register an event notifier handler to process AP configuration change events by queuing the event and generating a CRW to let the guest know its AP configuration has changed Signed-off-by: Rorie Reyes Reviewed-by: Anthony Krowiak Tested-by: Anthony

Re: [PATCH v3 7/7] hw/xen: Fix errp handling in xen_console

2025-01-15 Thread Anthony PERARD
check, with ERRP_GUARD() macro `errp` is never NULL. > +error_free(*errp); After this, I think you still need *errp = NULL; > +} > +if (number) { > +cd = serial_hd(number); > +if (!cd) { > +error_setg(errp,

Re: [PATCH v3 2/7] xen: do not use '%ms' scanf specifier

2025-01-15 Thread Anthony PERARD
ce-s...') > Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model') > Signed-off-by: Roger Pau Monné > Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH v3 1/7] hw/xen: Add xs_node_read() helper function

2025-01-15 Thread Anthony PERARD
aving to do so for themselves (and > from using xs_node_scanf() with the non-portable %ms format string. > > Signed-off-by: David Woodhouse > [remove double newline and constify trace parameters] > Signed-off-by: Roger Pau Monné Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 1/4] hw/xen: Use xs_node_read() from xs_node_vscanf()

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:23AM +, David Woodhouse wrote: > From: David Woodhouse > > Reduce some duplication. > > Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 4/4] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:26AM +, David Woodhouse wrote: > From: David Woodhouse > > Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 2/4] hw/xen: Use xs_node_read() from xen_console_get_name()

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:24AM +, David Woodhouse wrote: > From: David Woodhouse > > Now that xs_node_read() can construct a node path, no need to open-code it. > > Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH 3/4] hw/xen: Use xs_node_read() from xen_netdev_get_name()

2025-01-15 Thread Anthony PERARD
On Fri, Jan 10, 2025 at 10:03:25AM +, David Woodhouse wrote: > From: David Woodhouse > > Now that xs_node_read() can construct a node path, no need to open-code it. > > Signed-off-by: David Woodhouse Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD

Re: [PATCH v2 2/2] xen: do not use '%ms' scanf specifier

2025-01-15 Thread Anthony PERARD
or_prepend()` and use `error_setg` instead when `serial_hd()` fails. > +if (output) { > /* > * FIXME: sure we want to support implicit > * muxed monitors here? Thanks, -- Anthony PERARD

Re: [PATCH v2 1/2] hw/xen: Add xs_node_read() helper function

2025-01-15 Thread Anthony PERARD
very other function use "${node}/${key}" (As explain in the comment above xs_node_vscanf()), but this one uses a printf format in `node_fmt` (which could probably better be named `path_fmt` instead). Otherwise, patch looks fine to me. Cheers, -- Anthony PERARD

Re: [PATCH 2/2] xen: do not use '%ms' scanf specifier

2025-01-09 Thread Anthony PERARD
"type", errp, "%ms", &type) != 1) { > +node_path = g_strdup_printf("%s/type", fe); > +type = qemu_xen_xs_read(xsh, XBT_NULL, node_path, NULL); > +g_free(node_path); I feel like we want "xs_node_read()" which would be similair to xs_node_vscanf() but would simply return the result of qemu_xen_xs_read(). This would avoid the need format of the node path in several place in the code. But it's OK like that as well. Cheers, -- Anthony PERARD

Re: [PATCH 1/2] xen/console: fix error handling in xen_console_device_create()

2025-01-09 Thread Anthony PERARD
ber) { > cd = serial_hd(number); > if (!cd) { > -error_prepend(errp, "console: No serial device #%ld found: ", > +error_setg(errp, "console: No serial device #%ld found: ", >number); This change looks correct, ableit we could remove ": " from the end of the string since they shouldn't be anything after it. Cheers, -- Anthony PERARD

Re: [QEMU PATCH v10] xen/passthrough: use gsi to map pirq when dom0 is PVH

2024-12-12 Thread Anthony PERARD
On Tue, Dec 10, 2024 at 07:17:30AM +, Chen, Jiqian wrote: > On 2024/11/19 00:05, Anthony PERARD wrote: > > On Wed, Nov 06, 2024 at 02:14:18PM +0800, Jiqian Chen wrote: > >> In PVH dom0, when passthrough a device to domU, QEMU code > >> xen_pt_realize->xc_physdev_

Re: [QEMU PATCH v10] xen/passthrough: use gsi to map pirq when dom0 is PVH

2024-11-18 Thread Anthony PERARD
: Huang Rui > Signed-off-by: Jiqian Chen Acked-by: Anthony PERARD But, this following change probably needs an ack from PCI maintaners, CCed. > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index eb26cac81098..07805aa8a5f3 100644 > --- a/include/hw/pci/pci.h > +++

Re: [PATCH v6 0/3] Add support for the RAPL MSRs series

2024-11-02 Thread Anthony Harivel
Hi Igor, Igor Mammedov, Nov 01, 2024 at 16:09: > On Tue, 22 Oct 2024 16:16:36 +0200 > "Anthony Harivel" wrote: > >> Daniel P. Berrangé, Oct 22, 2024 at 15:15: >> > On Tue, Oct 22, 2024 at 02:46:15PM +0200, Igor Mammedov wrote: >> >> On Fri, 18 Oc

Re: [PATCH v6 0/3] Add support for the RAPL MSRs series

2024-10-22 Thread Anthony Harivel
Daniel P. Berrangé, Oct 22, 2024 at 16:29: > On Tue, Oct 22, 2024 at 04:16:36PM +0200, Anthony Harivel wrote: >> Daniel P. Berrangé, Oct 22, 2024 at 15:15: >> > On Tue, Oct 22, 2024 at 02:46:15PM +0200, Igor Mammedov wrote: >> >> On Fri, 18 Oct 2024 13:59:34 +0100 &

Re: [PATCH v6 0/3] Add support for the RAPL MSRs series

2024-10-22 Thread Anthony Harivel
t; > On Wed, 16 Oct 2024 14:56:39 +0200 >> > > "Anthony Harivel" wrote: >> [...] >> >> > > >> > > This also leads to a question, if we should account for >> > > not VCPU threads at all. Looking at real hardware, those >>

Re: [PATCH v6 0/3] Add support for the RAPL MSRs series

2024-10-22 Thread Anthony Harivel
Igor Mammedov, Oct 18, 2024 at 14:25: > On Wed, 16 Oct 2024 14:56:39 +0200 > "Anthony Harivel" wrote: > >> Hi Igor, >> >> Igor Mammedov, Oct 16, 2024 at 13:52: >> > On Wed, 22 May 2024 17:34:49 +0200 >> > Anthony Harivel wrote: >>

Re: [PATCH v6 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-10-16 Thread Anthony Harivel
Hi Igor, I will let Paolo or Daniel answering those architecture questions, they are more qualified than me. Thanks Anthony Igor Mammedov, Oct 16, 2024 at 14:17: > On Wed, 22 May 2024 17:34:52 +0200 > Anthony Harivel wrote: > >> Starting with the "Sandy Bridge&quo

Re: [PATCH v6 0/3] Add support for the RAPL MSRs series

2024-10-16 Thread Anthony Harivel
Hi Igor, Igor Mammedov, Oct 16, 2024 at 13:52: > On Wed, 22 May 2024 17:34:49 +0200 > Anthony Harivel wrote: > >> Dear maintainers, >> >> First of all, thank you very much for your review of my patch >> [1]. > > I've tried to play with this feature

Re: Convert an error_report to tracepoint

2024-09-30 Thread Anthony Harivel
Daniel P. Berrangé, Sep 30, 2024 at 13:43: > On Mon, Sep 30, 2024 at 01:36:21PM +0200, Anthony Harivel wrote: >> Hello, >> >> There is an error_report() in target/i386/kvm/vmsr_energy.c that would >> benefit for being a tracepoint because this is not actually an &quo

Convert an error_report to tracepoint

2024-09-30 Thread Anthony Harivel
ow I could manage that so I can send a patch to rectify this ? Thanks, Anthony

[PATCH 2/2] hw/block/xen-block: Update sector-size handling

2024-09-26 Thread Anthony PERARD
02c4c899 So change QEMU to follow the updated specification. Frontends that exposes "feature-large-sector-size" will most certainly misbehave if "sector-size" is different than 512, so don't even try. (Windows driver is likely to be the only one having impl

[PATCH 1/2] include: update Xen public headers io/blkif.h

2024-09-26 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- include/hw/xen/interface/io/blkif.h | 52 + 1 file changed, 39 insertions(+), 13 deletions(-) diff --git a/include/hw/xen/interface/io/blkif.h b/include/hw/xen/interface/io/blkif.h index 22f1eef0c0..9b00d633d3 100644 --- a/include

[PATCH 0/2] Xen: Update sector-size handling in block backend

2024-09-26 Thread Anthony PERARD
org/gitweb/?p=xen.git;a=commit;h=221f2748e8dabe8361b8cdfcffbeab9102c4c899 This update the header and the backend. Thanks, Anthony PERARD (2): include: update Xen public headers io/blkif.h hw/block/xen-block: Update sector-size handling hw/block/dataplane/xen-block.c | 31 +

Re: [PATCH] hw/xen: Remove deadcode

2024-09-17 Thread Anthony PERARD
nused since 2018's > 6d7c06c213 ("Remove broken Xen PV domain builder") > > Remove them. > > Signed-off-by: Dr. David Alan Gilbert Acked-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech

Re: [PATCH v3 3/3] Do not access /dev/mem in MSI-X PCI passthrough on Xen

2024-08-28 Thread Anthony PERARD
ons[bar_index].base_addr; > XEN_PT_LOG(d, "get MSI-X table BAR base 0x%"PRIx64"\n", > msix->table_base); > > +/* Accessing /dev/mem is needed only on older Xen. */ > +if (!(xc_version_info.submap & (1U << XENFEAT_dm_msix_all_writes))) { Would it be ok to use test_bit() instead? Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech

Re: [PATCH v3 2/3] Update Xen's features.h header

2024-08-28 Thread Anthony PERARD
On Mon, May 06, 2024 at 02:33:21AM +0200, Marek Marczykowski-Górecki wrote: > Update it to get XENFEAT_dm_msix_all_writes for the next patch. > > Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng &

Re: [PATCH v3 1/3] hw/xen/xen_pt: Save back data only for declared registers

2024-08-28 Thread Anthony PERARD
saving register values > - fix int overflow when calculating write mask Reviewed-by: Anthony PERARD Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech

[PATCH 0/1] Fix energy calcultation in RAPL MSR

2024-08-07 Thread Anthony Harivel
i.e -smp 4 / -smp 8,sockets=2,dies=1 / -smp 8,sockets=4,dies=2 ) Anthony Harivel (1): target/i386: Fix arguments for vmsr_read_thread_stat() target/i386/kvm/kvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.45.2

[PATCH 1/1] target/i386: Fix arguments for vmsr_read_thread_stat()

2024-08-07 Thread Anthony Harivel
Snapshot of the stat utime and stime for each thread, taken before and after the pause, must be stored in separate locations Signed-off-by: Anthony Harivel --- target/i386/kvm/kvm.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386

[PATCH 0/2] Fix RAPL MSR support in staging

2024-07-26 Thread Anthony Harivel
Hi Paolo, RAPL MSR has landed in staging with few scratches. Here a couple of patches to solves CID 1558553 and 1558557. Anthony Anthony Harivel (2): target/i386: Fix typo that assign same value twice target/i386: Clean output of vmsr_read_thread_stat() target/i386/kvm/kvm.c | 4

[PATCH 2/2] target/i386: Clean output of vmsr_read_thread_stat()

2024-07-26 Thread Anthony Harivel
Fix leaking memory of file handle in case of error Erase unused "pid = -1" Add clearer error_report Should fix: CID 1558557 Signed-off-by: Anthony Harivel --- target/i386/kvm/vmsr_energy.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm/vmsr_

[PATCH 1/2] target/i386: Fix typo that assign same value twice

2024-07-26 Thread Anthony Harivel
Should fix: CID 1558553 Signed-off-by: Anthony Harivel --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index b4aab9a410b5..31f149c9902c 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c

Re: [PATCH 1/2] vfio/ap: Don't initialize HOST_IOMMU_DEVICE with mdev

2024-07-22 Thread Anthony Krowiak
On 7/22/24 5:18 AM, Joao Martins wrote: On 22/07/2024 08:07, Zhenzhong Duan wrote: mdevs aren't "physical" devices and when asking for backing IOMMU info, it fails the entire provisioning of the guest. Fix that by setting vbasedev->mdev true so skipping HostIOMMUDevice initialization in the pr

Re: [PATCH] MAINTAINERS: add Edgar as Xen maintainer

2024-07-11 Thread Anthony PERARD
725913c8b..63e11095a2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -536,6 +536,7 @@ X86 Xen CPUs > M: Stefano Stabellini > M: Anthony PERARD > M: Paul Durrant > +M: Edgar E. Iglesias > L: xen-de...@lists.xenproject.org > S: Supported > F: */xen* Acked-by: Anthony PERARD Welcome! Cheers, -- Anthony PERARD

Re: [PATCH v1 2/2] xen: mapcache: Fix unmapping of first entries in buckets

2024-07-04 Thread Anthony PERARD
irst entries in buckets") > Reported-by: Anthony PERARD > Signed-off-by: Edgar E. Iglesias > --- > hw/xen/xen-mapcache.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/hw/xen/xen-mapcache.c b/hw/xen/xen-mapcache.c > index 5f23b

Re: [PATCH v8 2/8] xen: mapcache: Unmap first entries in buckets

2024-07-01 Thread Anthony PERARD
validate mapping. */ > +entry->paddr_index = 0; > +entry->vaddr_base = NULL; > +entry->size = 0; > +entry->valid_mapping = NULL; > +entry->flags = 0; > +/* Keep entry->next pointing to the rest of the list. */ > }

[PULL 2/3] xen: fix stubdom PCI addr

2024-07-01 Thread anthony
-stubdomain BDF by looking up relevant PV PCI xenstore entries. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Anthony PERARD Message-Id: <35049e99da634a74578a1ff2cb3ae4cc436ede33.1711506237.git-series.marma...@invisiblethingslab.com> Signed-off-by: Anthony PERARD --- hw/xen/xe

[PULL 1/3] hw/xen: detect when running inside stubdomain

2024-07-01 Thread anthony
-Górecki Reviewed-by: Anthony PERARD Message-Id: Signed-off-by: Anthony PERARD --- hw/i386/xen/xen-hvm.c | 22 ++ include/hw/xen/xen.h | 1 + system/globals.c | 1 + 3 files changed, 24 insertions(+) diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c index

[PULL 0/3] xen queue 2024-07-01

2024-07-01 Thread anthony
From: Anthony PERARD The following changes since commit b6d32a06fc0984e537091cba08f2e1ed9f775d74: Merge tag 'pull-trivial-patches' of https://gitlab.com/mjt0k/qemu into staging (2024-06-30 16:12:24 -0700) are available in the Git repository at: https://xenbits.xen.org/git-h

[PULL 3/3] xen-hvm: Avoid livelock while handling buffered ioreqs

2024-07-01 Thread anthony
them. This lets QEMU go back to the main loop and catch up. Signed-off-by: Ross Lagerwall Reviewed-by: Paul Durrant Message-Id: <20240404140833.1557953-1-ross.lagerw...@citrix.com> Signed-off-by: Anthony PERARD --- hw/xen/xen-hvm-common.c | 26 +- 1 file chang

Re: [PATCH v8 2/8] xen: mapcache: Unmap first entries in buckets

2024-07-01 Thread Anthony PERARD
logs: http://logs.test-lab.xenproject.org/osstest/logs/186611/test-amd64-amd64-xl-qemuu-ovmf-amd64/info.html Any idea? Something is trying to do something with the address "-1" when it shouldn't? Cheers, Anthony On Wed, May 29, 2024 at 04:07:33PM +0200, Edgar E. Iglesias wro

Re: [PATCH v6 0/3] Add support for the RAPL MSRs series

2024-06-26 Thread Anthony Harivel
Just a gentle ping for the above patch series. Anthony Harivel, May 22, 2024 at 17:34: > Dear maintainers, > > First of all, thank you very much for your review of my patch > [1]. > > In this version (v6), I have attempted to address all the problems > addressed by Da

Re: [PATCH 05/16] vfio/helpers: Make vfio_device_get_name() return bool

2024-05-24 Thread Anthony Krowiak
-634,7 +634,7 @@ int vfio_device_get_name(VFIODevice *vbasedev, Error **errp) } } -return 0; +return true; } For the two functions above: Reviewed-by: Anthony Krowiak snip ...

Re: [PATCH 04/16] vfio/helpers: Make vfio_set_irq_signaling() return bool

2024-05-24 Thread Anthony Krowiak
On 5/15/24 4:20 AM, Zhenzhong Duan wrote: This is to follow the coding standand in qapi/error.h to return bool for bool-valued functions. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan --- include/hw/vfio/vfio-common.h | 4 ++-- hw/vfio/ap.c | 8 +++

Re: [PATCH 3/7] hw/s390x/ccw: Remove local Error variable from s390_ccw_realize()

2024-05-24 Thread Anthony Krowiak
On 5/22/24 1:01 PM, Cédric Le Goater wrote: Use the 'Error **errp' argument of s390_ccw_realize() instead and remove the error_propagate() call. Signed-off-by: Cédric Le Goater Reviewed-by: Anthony Krowiak --- hw/s390x/s390-ccw.c | 13 + 1 file changed, 5

Re: [PATCH 4/7] s390x/css: Make S390CCWDeviceClass::realize return bool

2024-05-24 Thread Anthony Krowiak
Le Goater Reviewed-by: Anthony Krowiak --- include/hw/s390x/s390-ccw.h | 2 +- hw/s390x/s390-ccw.c | 7 --- hw/vfio/ccw.c | 3 +-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/hw/s390x/s390-ccw.h b/include/hw/s390x/s390-c

Re: [PATCH 7/7] vfio/{ap, ccw}: Use warn_report_err() for IRQ notifier registration errors

2024-05-24 Thread Anthony Krowiak
Goater Reviewed-by: Anthony Krowiak --- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c index c12531a7886a2fe87598be0861fba5923bd2c206..0c4354e3e70169ec072e16da0919936647d1d351 100644 --- a/hw/vfio

Re: [PATCH 2/7] s390x/css: Make CCWDeviceClass::realize return bool

2024-05-24 Thread Anthony Krowiak
Reviewed-by: Anthony Krowiak --- hw/s390x/ccw-device.h | 2 +- hw/s390x/ccw-device.c | 3 ++- hw/s390x/s390-ccw.c | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/s390x/ccw-device.h b/hw/s390x/ccw-device.h index 6dff95225df11c63f9b66975019026

Re: [PATCH 5/7] vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()

2024-05-24 Thread Anthony Krowiak
Signed-off-by: Cédric Le Goater Reviewed-by: Anthony Krowiak --- hw/vfio/ccw.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index 9a8e052711fe2f7c067c52808b2af30d0ebfee0c..a468fa2342b97e0ee36bd5fb8443025cc90a0453 100644 --- a

Re: [PATCH 1/7] hw/s390x/ccw: Make s390_ccw_get_dev_info() return a bool

2024-05-24 Thread Anthony Krowiak
On 5/22/24 1:01 PM, Cédric Le Goater wrote: Since s390_ccw_get_dev_info() takes an 'Error **' argument, best practices suggest to return a bool. See the qapi/error.h Rules section. While at it, modify the call in s390_ccw_realize(). Signed-off-by: Cédric Le Goater Reviewed-b

[PATCH v6 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-05-22 Thread Anthony Harivel
h=/path/sock.sock Actual limitation: - Works only on Intel host CPU because AMD CPUs are using different MSR adresses. - Only the Package Power-Plane (MSR_PKG_ENERGY_STATUS) is reported at the moment. Signed-off-by: Anthony Harivel --- accel/kvm/kvm-all.c | 27 +++ docs/specs/index.r

[PATCH v6 1/3] qio: add support for SO_PEERCRED for socket channel

2024-05-22 Thread Anthony Harivel
sending process */ gid_t gid;/* Group ID of the sending process */ }; The use of this function is possible only for connected AF_UNIX stream sockets and for AF_UNIX stream and datagram socket pairs. On platform other than Linux, the function return 0. Signed-off-by: Anthony Harivel

[PATCH v6 2/3] tools: build qemu-vmsr-helper

2024-05-22 Thread Anthony Harivel
but can be extended to support AMD CPUs in the future. Signed-off-by: Anthony Harivel --- contrib/systemd/qemu-vmsr-helper.service | 15 + contrib/systemd/qemu-vmsr-helper.socket | 9 + docs/tools/index.rst | 1 + docs/tools/qemu-vmsr-helper.rst | 89 m

[PATCH v6 0/3] Add support for the RAPL MSRs series

2024-05-22 Thread Anthony Harivel
possible - Add a Documentation of implementation, limitation and usage Best regards, Anthony [1]: https://mail.gnu.org/archive/html/qemu-devel/2024-04/msg01570.html [2]: https://mail.gnu.org/archive/html/qemu-devel/2024-04/msg03947.html [3]: https://mail.gnu.org/archive/html/qemu-devel/2024-04/msg02350.

Re: [PATCH v5 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-05-06 Thread Anthony Harivel
Anthony Harivel, Apr 26, 2024 at 10:36: > > Hi Paolo, > > Daniel P. Berrangé, Apr 25, 2024 at 17:42: > > On Thu, Apr 25, 2024 at 05:34:52PM +0200, Anthony Harivel wrote: > > > Hi Daniel, > > > > > > Daniel P. Berrangé, Apr 18, 2024 at 18:42: > &g

  1   2   3   4   5   6   7   8   9   10   >