[Qemu-devel] [PATCH] vl.c: optimized code format

2015-01-12 Thread Zhang Min
From: Rudy Zhang There are several tab characters in the 'vl.c' file. It leads to to misalignment of the code. So, let the space instead of the tab. Signed-off-by: Rudy Zhang --- vl.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git

[Qemu-devel] [Patch] block:qemu will crash when vhost-scsi disk vm reboot

2014-09-01 Thread Zhang Min
From: subo When the vm reboot, it will call virtio_scsi_handle_event(), for vhost-scsi device,vdev is VIRTIO_SCSI_COMMON, not VIRTIO_SCSI, if vdev convert to the VIRTIO_SCSI, it will cause qemu crash. Signed-off-by: Zhang Min Signed-off-by: subo --- hw/scsi/virtio-scsi.c | 6 +- 1 file

[Qemu-devel] [PATCH v2] drive mirror:fix memory leak

2014-01-23 Thread Zhang Min
) to free op->qiov. Signed-off-by: Zhang Min --- block/mirror.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 2932bab..05758e5 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -96,6 +96,7 @@ static void mirror_iteration_done(

[Qemu-devel] [PATCH] drive-mirror:fix memory leak

2014-01-21 Thread Zhang Min
In the function mirror_iteration() -> qemu_iovec_init(), it allocates memory for op->qiov.iov, when the write request calls back, but in the function mirror_iteration_done(), it only frees the op, not free the op->qiov.iov, so this causes memory leak. Signed-off-by: Zhang Min --- block

Re: [Qemu-devel] [PATCH] drive-mirror: fix memory leak

2014-01-21 Thread Zhang Min
it alloc memory for >> op->qiov.iov, when the write request call back, > > s/alloc/allocates/ > s/call back/calls back/ > >> >> >> >> but in the function mirror_iteration_done(), it only free the op, not free >> the op->qiov.iov, so