Since there are no changes in two months.
Simply ping for merging, sorry for bothering you again.
Daniel P. Berrangé 於 2019年12月2日 週一 下午11:53寫道：
> On Sat, Nov 23, 2019 at 11:43:06AM +0800, Yu-Chen Lin wrote:
> > noVNC doesn't use 'binary' protocol by
I have two mail address, add entries for
showing author and email correctly.
Signed-off-by: Yu-Chen Lin
---
v1 -> v2:
* Change subject
.mailmap | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index 3816e4effe..3fbf3902a3 100644
--- a/.mailmap
++
Hi,
Thank you for your suggestion, I will send v2 with new subject. Also, I
will ack in v2 mail by my Synology account.
Thanks.
Philippe Mathieu-Daudé 於 2020年2月6日 週四 下午7:08寫道：
> Hello,
>
> I suggest changing the subject to:
> "mailmap: Add entry for Yu-Chen Lin"
I have two mail address, add entries for
showing author and email correctly.
Signed-off-by: Yu-Chen Lin
---
.mailmap | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/.mailmap b/.mailmap
index 3816e4effe..3fbf3902a3 100644
--- a/.mailmap
+++ b/.mailmap
@@ -151,7 +151,8
Ping?
Yu-Chen Lin 於 2019年11月23日 週六 11:43 寫道：
> noVNC doesn't use 'binary' protocol by default after
> commit c912230309806aacbae4295faf7ad6406da97617.
>
> It will cause qemu return 400 when handshaking.
>
> To overcome this problem and remain compatibility of
&
me
so that we can support different version of noVNC
client.
Tested on noVNC before c912230 and after c912230.
Buglink: https://bugs.launchpad.net/qemu/+bug/1849644
Signed-off-by: Yu-Chen Lin
---
io/channel-websock.c | 35 +++
1 file changed, 23 insertions(+), 12
gt; > sector_num), it means we cannot find the table contains sector_num.
> > We can return s->n_chunks (error) directly.
> >
> > What do you think?
>
> Sounds good. We have to assume that the file contents are invalid and
> handle all cases.
>
> I'll review the next revision of your patch. Thanks!
>
Thanks!
Yu-Chen Lin
> Stefan
>
