Fix 2 ciritical bugs of vhost-user hardware notifier.
Xueming Li (2):
vhost-user: remove VirtQ notifier restore
vhost-user: fix VirtQ notifier cleanup
hw/virtio/vhost-user.c | 61 +++---
include/hw/virtio/vhost-user.h | 3 +-
2 files changed, 29
er to avoid invalid address access.
After backend restart, the backend should ask qemu to install a hardware
notifier if needed.
Fixes: 44866521bd6e ("vhost-user: support registering external host notifiers")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user
underlying notifier mmap address is being freed and
becomes invalid.
This patch calls RCU and munmap notifiers in the callback after the
memory flatview update finish.
Fixes: 44866521bd6e ("vhost-user: support registering external host notifiers")
Cc: qemu-sta...@nongnu.org
Signed-off-b
vhost-user: support registering external host notifiers")
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 50 +-
include/hw/virtio/vhost-user.h | 2 ++
2 files changed, 33 insertions(+), 19 deletion
.html
v6: use call_rcu to avoid dead lock in rcu reader
Xueming Li (2):
vhost-user: remove VirtQ notifier restore
vhost-user: fix VirtQ notifier cleanup
hw/virtio/vhost-user.c | 63 --
include/hw/virtio/vhost-user.h | 3 +-
2 files changed, 31 insertions
invalid address.
Fixes: 44866521bd6e ("vhost-user: support registering external host notifiers")
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 19 +--
include/hw/virtio/vhost-user.h | 1 -
2 files changed, 1 insert
pport registering external host notifiers")
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index bf6e50223c..
fiers")
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 19 +--
include/hw/virtio/vhost-user.h | 1 -
2 files changed, 1 insertion(+), 19 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-us
style and comments
https://lists.nongnu.org/archive/html/qemu-devel/2021-10/msg01764.html
v4: fix first patch compilation
https://lists.nongnu.org/archive/html/qemu-devel/2021-10/msg04060.html
v5: update 2/2 commit message
Xueming Li (2):
vhost-user: fix VirtQ notifier cleanup
vhost-user
Cc: tiwei@intel.com
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 19 +--
include/hw/virtio/vhost-user.h | 1 -
2 files changed, 1 insertion(+), 19 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-us
style and comments
https://lists.nongnu.org/archive/html/qemu-devel/2021-10/msg01764.html
v4: fix first patch compilation
Xueming Li (2):
vhost-user: fix VirtQ notifier cleanup
vhost-user: remove VirtQ notifier restore
hw/virtio/vhost-user.c | 41
pport registering external host notifiers")
Cc: tiwei@intel.com
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-us
Cc: tiwei@intel.com
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 20 ++--
include/hw/virtio/vhost-user.h | 1 -
2 files changed, 2 insertions(+), 19 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-us
uwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 2c8556237f..bf6e50223c 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -1526,8 +1526,9
pport registering external host notifiers")
Cc: tiwei@intel.com
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-us
style and comments
Xueming Li (2):
vhost-user: fix VirtQ notifier cleanup
vhost-user: remove VirtQ notifier restore
hw/virtio/vhost-user.c | 41 +-
include/hw/virtio/vhost-user.h | 1 -
2 files changed, 16 insertions(+), 26 deletions(-)
--
2.33.0
When vDPA applicaiton in client mode shutdown, unmapped VQ notifier
might being accessed by vCPU thread under high tx traffic, it will
crash VM in rare conditon. This patch try to fix it with better RCU
sychronization of new flatview.
v2: no RCU draining on vCPU thread
Xueming Li (2):
vhost
Cc: tiwei@intel.com
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 20 ++--
include/hw/virtio/vhost-user.h | 1 -
2 files changed, 2 insertions(+), 19 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-us
-user: support registering external host notifiers")
Cc: tiwei@intel.com
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/vhost-user.c b
When vDPA applicaiton in client mode shutdown, unmapped VQ notifier
might being accessed by VM thread under hight tx traffic, it will
crash VM in rare conditon. This patch try to fix it with better RCU
sychronization of new flatview.
Xueming Li (2):
vhost-user: fix VirtQ notifier cleanup
pport registering external host notifiers")
Cc: tiwei@intel.com
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-us
Cc: tiwei@intel.com
Cc: qemu-sta...@nongnu.org
Cc: Yuwei Zhang
Signed-off-by: Xueming Li
---
hw/virtio/vhost-user.c | 19 +--
include/hw/virtio/vhost-user.h | 1 -
2 files changed, 1 insertion(+), 19 deletions(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-us
22 matches
Mail list logo
