Re: [PATCH v6 1/2] vhost-user: remove VirtQ notifier restore

2022-02-07 Thread Xueming(Steven) Li
v7 sent with more description, please check. Thanks, Xueming On Fri, 2022-02-04 at 07:25 -0500, Michael S. Tsirkin wrote: I dropped this for now as I'm a bit lost with this patchset. Cc Raphael maybe he'll understand it better. On Wed, Jan 12, 2022 at 03:05:15PM +0000, Xueming(

Re: [PATCH v6 1/2] vhost-user: remove VirtQ notifier restore

2022-02-07 Thread Xueming(Steven) Li
+0000, Xueming(Steven) Li wrote: > > On Wed, 2021-11-03 at 16:30 -0400, Michael S. Tsirkin wrote: > > > On Wed, Nov 03, 2021 at 02:48:41PM +, Xueming(Steven) Li wrote: > > > > On Tue, 2021-11-02 at 02:49 -0400, Michael S. Tsirkin wrote: > > > > > On

Re: [PATCH v6 2/2] vhost-user: fix VirtQ notifier cleanup

2022-01-12 Thread Xueming(Steven) Li
On Tue, 2021-11-02 at 02:47 -0400, Michael S. Tsirkin wrote: > On Tue, Nov 02, 2021 at 06:00:58AM +0000, Xueming(Steven) Li wrote: > > On Mon, 2021-11-01 at 17:00 -0400, Michael S. Tsirkin wrote: > > > On Mon, Nov 01, 2021 at 04:38:13PM +0800, Xueming Li wrote: > > &g

Re: [PATCH v6 1/2] vhost-user: remove VirtQ notifier restore

2022-01-12 Thread Xueming(Steven) Li
On Wed, 2021-11-03 at 16:30 -0400, Michael S. Tsirkin wrote: > On Wed, Nov 03, 2021 at 02:48:41PM +0000, Xueming(Steven) Li wrote: > > On Tue, 2021-11-02 at 02:49 -0400, Michael S. Tsirkin wrote: > > > On Tue, Nov 02, 2021 at 06:08:39AM +0000, Xueming(Steven) Li wrote: > >

Re: [PATCH v6 1/2] vhost-user: remove VirtQ notifier restore

2021-11-03 Thread Xueming(Steven) Li
On Tue, 2021-11-02 at 02:49 -0400, Michael S. Tsirkin wrote: > On Tue, Nov 02, 2021 at 06:08:39AM +0000, Xueming(Steven) Li wrote: > > On Mon, 2021-11-01 at 17:06 -0400, Michael S. Tsirkin wrote: > > > On Mon, Nov 01, 2021 at 04:38:12PM +0800, Xueming Li wrote: > > > &g

Re: [PATCH v6 1/2] vhost-user: remove VirtQ notifier restore

2021-11-01 Thread Xueming(Steven) Li
On Mon, 2021-11-01 at 17:06 -0400, Michael S. Tsirkin wrote: > On Mon, Nov 01, 2021 at 04:38:12PM +0800, Xueming Li wrote: > > When vhost-user vdpa client suspend, backend may close all resources, > > VQ notifier mmap address become invalid, restore MR which contains > > the invalid address is wron

Re: [PATCH v6 2/2] vhost-user: fix VirtQ notifier cleanup

2021-11-01 Thread Xueming(Steven) Li
On Mon, 2021-11-01 at 17:00 -0400, Michael S. Tsirkin wrote: > On Mon, Nov 01, 2021 at 04:38:13PM +0800, Xueming Li wrote: > > When vhost-user device cleanup is executed and un-mmaps notifier > > address, VM cpu thread writing the notifier fails by accessing invalid > > address error. > > > > To a

Re: [PATCH v5 1/2] vhost-user: fix VirtQ notifier cleanup

2021-10-28 Thread Xueming(Steven) Li
On Tue, 2021-10-19 at 06:52 -0400, Michael S. Tsirkin wrote: > On Tue, Oct 19, 2021 at 03:57:42PM +0800, Xueming Li wrote: > > When vhost-user device cleanup and unmmap notifier address, VM cpu > > you mean cleanup is executed and un-mmaps ... > > > thread that writing the notifier failed > > th

Re: [PATCH v3 2/2] vhost-user: remove VirtQ notifier restore

2021-10-19 Thread Xueming(Steven) Li
On Tue, 2021-10-19 at 03:24 -0400, Michael S. Tsirkin wrote: > On Tue, Oct 19, 2021 at 07:21:24AM +0000, Xueming(Steven) Li wrote: > > On Tue, 2021-10-19 at 02:37 -0400, Michael S. Tsirkin wrote: > > > On Fri, Oct 08, 2021 at 03:58:05PM +0800, Xueming Li wrote: > > > &g

Re: [PATCH v3 2/2] vhost-user: remove VirtQ notifier restore

2021-10-19 Thread Xueming(Steven) Li
On Tue, 2021-10-19 at 02:37 -0400, Michael S. Tsirkin wrote: > On Fri, Oct 08, 2021 at 03:58:05PM +0800, Xueming Li wrote: > > When vhost-user vdpa client restart, VQ notifier resources become > > invalid, no need to keep mmap, vdpa client will set VQ notifier after > > reconnect. > > > > Removes

Re: [PATCH v3 1/2] vhost-user: fix VirtQ notifier cleanup

2021-10-18 Thread Xueming(Steven) Li
On Tue, 2021-10-19 at 02:15 -0400, Michael S. Tsirkin wrote: > On Fri, Oct 08, 2021 at 03:58:04PM +0800, Xueming Li wrote: > > When vhost-user device cleanup and unmmap notifier address, VM cpu > > thread that writing the notifier failed with accessing invalid address. > > > > To avoid this concur

Re: [PATCH v2 1/2] vhost-user: fix VirtQ notifier cleanup

2021-10-08 Thread Xueming(Steven) Li
On Tue, 2021-10-05 at 10:40 -0400, Michael S. Tsirkin wrote: > On Fri, Sep 17, 2021 at 08:26:15PM +0800, Xueming Li wrote: > > When vhost-user device stop and unmmap notifier address, vCPU thread > > that writing the notifier via old flatview failed with accessing invalid > > address. > > > > To a

Re: [PATCH 1/2] vhost-user: fix VirtQ notifier cleanup

2021-09-14 Thread Xueming(Steven) Li
On Mon, 2021-09-13 at 00:20 +0800, Xueming Li wrote: > When vhost-user device cleanup and unmmap notifier address, VM cpu > thread that writing the notifier failed with accessing invalid address. > > To avoid this concurrent issue, wait memory flatview update by draining > rcu callbacks, then u