Thanks all the contributors, looking forward to having a product virtio-fs
deployment shortly.
> On Aug 20, 2019, at 12:04 AM, Stefan Hajnoczi wrote:
>
> I am delighted to announce the release of virtio-fs v0.3, a shared file
> system that lets virtual machines access a directory tree on the ho
saved in
the ovl.img is a/a/blob.img. Bug occurred.
After patched:
The step 3 above an error message will be thrown because backing
file checking started after got the full path of backing file
intead of relative path.
Signed-off-by: Xu Wang
---
block.c | 17 +++--
Check the backing file for a loop during image boot, to avoid a lack or
response or segfault.
Signed-off-by: Xu Wang
---
blockdev.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 330aa4a..e39fc27 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -511,6
Backing file loop should be checked before calling change_backing_
file(). If loop appeared, this calling should be stopped and an
error printed.
Signed-off-by: Xu Wang
---
block.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/block.c b/block.c
index b8cea1c..87f7018 100644
--- a
Backing file loop should be checked before qemu-img create command
execution. If loop is found, qemu-img create should be stopped and
an error printed.
Signed-off-by: Xu Wang
---
block.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/block.c b/block.c
bdrv_backing_chain_okay() and bdrv_image_create_okay().
Signed-off-by: Xu Wang
---
block.c | 73 +++
include/block/block.h | 3 +++
qemu-img.c| 52 ++--
3 files changed, 102 insertions(+), 26 deletions(-)
diff
hile()
6. Changed get_win_inode() to get_inode() and move all inode get method
into it to make logic more simpler.
7. Added value of @fmt as suggested.
8. Added backing file loop check in qcow2.c/qed.c
Xu Wang (4):
block/qemu-img: Refine and export infinite loop c
Check the backing file for a loop during image boot, to avoid a lack or
response or segfault.
Signed-off-by: Xu Wang
---
blockdev.c | 8
1 file changed, 8 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index b260477..60a3c93 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -510,6
bdrv_backing_chain_okay() and bdrv_image_create_okay().
Signed-off-by: Xu Wang
---
block.c | 74 +++
include/block/block.h | 3 +++
qemu-img.c| 52 ++--
3 files changed, 103 insertions(+), 26 deletions(-)
diff
d value of @fmt as suggested.
8. Added backing file loop check in qcow2.c/qed.c
Xu Wang (4):
block/qemu-img: Refine and export infinite loop checking in
collect_image_info_list()
block: Add check infinite loop in bdrv_img_create()
block: Add backing file loop check in change_ba
Backing file loop should be checked before calling change_backing_
file(). If loop appeared, this calling should be stopped and an
error printed.
Signed-off-by: Xu Wang
---
block.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/block.c b/block.c
index 6fbc702..2d58f12 100644
--- a
Backing file loop should be checked before qemu-img create command
execution. If loop is found, qemu-img create should be stopped and
an error printed.
Signed-off-by: Xu Wang
---
block.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index
Backing file loop should be checked before qemu-img create command
execution. If loop is found, qemu-img create should be stopped and
an error printed.
Signed-off-by: Xu Wang
---
block.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 3c43179
logic more simpler.
7. Added value of @fmt as suggested.
8. Added backing file loop check in qcow2.c/qed.c
Xu Wang (4):
block/qemu-img: Refine and export infinite loop checking in
collect_image_info_list()
block: Add check infinite loop in bdrv_img_create()
block: Add backing file
Backing file loop should be checked before calling change_backing_
file(). If loop appeared, this calling should be stopped and an
error printed.
Signed-off-by: Xu Wang
---
block.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/block.c b/block.c
index c2ed6ef..861b133 100644
--- a
bdrv_backing_chain_okay() and bdrv_image_create_okay().
Signed-off-by: Xu Wang
---
block.c | 76 +++
include/block/block.h | 3 ++
qemu-img.c| 52 +--
3 files changed, 105 insertions(+), 26 deletions(-)
diff
Check the backing file for a loop during image boot, to avoid a lack or
response or segfault.
Signed-off-by: Xu Wang
---
blockdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index b260477..7c0927f 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -510,6 +510,12
Backing file loop should be checked before qemu-img create command
execution. If loop is found, qemu-img create should be stopped and
an error printed.
Signed-off-by: Xu Wang
---
block.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block.c b/block.c
index 3443117
)
6. Changed get_win_inode() to get_inode() and move all inode get method
into it to make logic more simpler.
7. Added value of @fmt as suggested.
8. Added backing file loop check in qcow2.c/qed.c
Xu Wang (5):
block/qemu-img: Refine and export infinite loop checki
Backing file loop should be checked before calling change_backing_
file(). If loop appeared, this calling should be stopped and an
error printed.
Signed-off-by: Xu Wang
---
block.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/block.c b/block.c
index 8423e80..cb50bfd 100644
--- a
Every image should be checked if there is infinite loop in backing
file chain before open it. So infinite loop check was added into
bdrv_new_open(). If @filename is opened without the flag
BDRV_O_NO_BACKING, the infinite loop check should be called.
Signed-off-by: Xu Wang
---
qemu-img.c | 8
bdrv_backing_chain_okay() and bdrv_image_create_okay().
Signed-off-by: Xu Wang
---
block.c | 117 ++
include/block/block.h | 4 ++
qemu-img.c| 44 ---
3 files changed, 139 insertions(+), 26 deletions(-)
diff --git a/block.c
δΊ 2013/8/3 6:09, Eric Blake ει:
On 08/02/2013 03:02 AM, Xu Wang wrote:
From: Xu Wang
If there is a loop exists in the backing file chain, many problems
could be caused by it, such as no response and segment fault during
system boot. Hence stopping backing file loop appear is very necessary
On 2013/8/28 20:53, Eric Blake wrote:
On 08/12/2013 10:31 PM, Dong Xu Wang wrote:
qemu_opts_print has no user now, so can re-write the function safely.
qemu_opts_print is used while using "qemu-img create", it
produces the same output as previous code.
The behavior of this fu
On 2013/8/28 20:57, Eric Blake wrote:
On 08/12/2013 10:31 PM, Dong Xu Wang wrote:
This patch moves the default value entirely to QemuOptDesc.
When getting the value of an option that hasn't been set, and
QemuOptDesc has a default value, return that. Else, behave as
before.
...
On 2013/8/28 7:13, Eric Blake wrote:
On 08/27/2013 08:12 AM, Kevin Wolf wrote:
Am 13.08.2013 um 06:32 hat Dong Xu Wang geschrieben:
QMP command query-command-line-options shows details information of
parameters, since added def_value_str, also output it in the QMP
command.
v16->v17:
1)
On 2013/8/27 21:49, Kevin Wolf wrote:
Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben:
qemu_opts_print has no user now, so can re-write the function safely.
qemu_opts_print is used while using "qemu-img create", it
produces the same output as previous code.
The behavior of thi
ble_size.
Signed-off-by: Dong Xu Wang
---
block/block-cache.c | 85 +++
block/block-cache.h | 59 +++
block/qcow2.c | 7 +++--
block/qcow2.h | 25 ++-
include/block/block.h | 3 ++
Will use block cache as common interface, so move qcow2-cache.c
to block-cache.c,
Signed-off-by: Dong Xu Wang
---
block/Makefile.objs | 3 +-
block/block-cache.c | 323
block/qcow2-cache.c | 323
.
4) introduce s->cluster_sectors.
5) use BLKDBG_L2_LOAD/UPDATE.
v16->v17:
1) Use stringify.
v15->v16:
1) Judge if opts is null in add_cow_create function.
Signed-off-by: Dong Xu Wang
---
block/Makefile.objs | 1 +
block/add-cow.c
This patch only rename qcow2_cache* functions to block_cache*,
did not touch other code.
Signed-off-by: Dong Xu Wang
---
block/qcow2-cache.c| 70 +-
block/qcow2-cluster.c | 48 +-
block/qcow2-refcount.c | 42
We will use path_has_protocol outside block.c, so just make it public.
Reviewed-by: Michael Roth
Signed-off-by: Dong Xu Wang
---
block.c | 2 +-
include/block/block.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index fcc8870..b2711e9
This patch will use qemu-iotests to test add-cow file format.
v17-v18:
1) add 037 and 038 tests.
Signed-off-by: Dong Xu Wang
---
tests/qemu-iotests/017 | 2 +-
tests/qemu-iotests/020 | 2 +-
tests/qemu-iotests/037 | 2 +-
tests/qemu-iotests/038 | 2 +-
tests/qemu
orrect qemu-iotests script.
5) Other bug fix.
v11->v12:
1) Removed un-used feature bit.
2) Share cache code with qcow2.c.
3) Remove snapshot_blkdev support, will add it in another patch.
5) COW Bitmap field in add-cow file will be multiple of 65536.
6) fix grammer and typo.
Dong Xu Wang (8
Make qed_read_string function to a common interface, so move it to
block.c.
Signed-off-by: Dong Xu Wang
---
block.c | 27 +++
block/qed.c | 34 --
include/block/block.h | 2 ++
3 files changed, 33 insertions(+), 30
luster size value.
3) fix type.
Signed-off-by: Dong Xu Wang
---
docs/specs/add-cow.txt | 172 +
1 file changed, 172 insertions(+)
create mode 100644 docs/specs/add-cow.txt
diff --git a/docs/specs/add-cow.txt b/docs/specs/add-cow.txt
new file mode 1
To produce same output while using "qemu-img create", opt->str
should store pure digit, without suffixes.
Signed-off-by: Dong Xu Wang
---
util/qemu-option.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index b939e8a..861929d 1006
Signed-off-by: Dong Xu Wang
---
block/vpc.c | 125
1 file changed, 125 insertions(+)
diff --git a/block/vpc.c b/block/vpc.c
index fe4f311..aa1263a 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -786,6 +786,109 @@ static int vpc_create
v7->v8:
1) print "elements => accept any params" while opts_accepts_any() ==
true.
2) since def_print_str is the default value if an option isn't set,
so rename it to def_value_str.
Reviewed-by: Eric Blake
Signed-off-by: Dong Xu Wang
---
include/q
QMP command query-command-line-options shows details information of
parameters, since added def_value_str, also output it in the QMP
command.
v16->v17:
1) add "Since 1.6" tag.
2) rename def_str_value to "default".
Signed-off-by: Dong Xu Wang
---
qapi-schema.json | 8 ++
Signed-off-by: Dong Xu Wang
---
block.c | 86 ++---
1 file changed, 39 insertions(+), 47 deletions(-)
diff --git a/block.c b/block.c
index 25090dc..9f52341 100644
--- a/block.c
+++ b/block.c
@@ -375,7 +375,7 @@ static void
Signed-off-by: Dong Xu Wang
---
block/vmdk.c | 236 +++
1 file changed, 236 insertions(+)
diff --git a/block/vmdk.c b/block/vmdk.c
index 346bb5c..5452aa2 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -1720,6 +1720,197 @@ exit
Conflicts:
block/sheepdog.c
Signed-off-by: Dong Xu Wang
---
block/sheepdog.c | 111 +++
1 file changed, 111 insertions(+)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index afe0533..b09b4fa 100644
--- a/block/sheepdog.c
+++ b
Signed-off-by: Dong Xu Wang
---
block/raw.c | 20
1 file changed, 20 insertions(+)
diff --git a/block/raw.c b/block/raw.c
index 4751825..7636f6b 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -139,6 +139,24 @@ static QEMUOptionParameter raw_create_options[] = {
{ NULL
Signed-off-by: Dong Xu Wang
---
block/raw-win32.c | 36
1 file changed, 36 insertions(+)
diff --git a/block/raw-win32.c b/block/raw-win32.c
index 9b5b2af..78efc63 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -452,6 +452,40 @@ static
Signed-off-by: Dong Xu Wang
Conflicts:
include/qemu/option.h
---
block.c | 1 -
include/qemu/option.h | 39 ---
util/qemu-option.c| 285 --
3 files changed, 325 deletions(-)
diff --git a/block.c b/block.c
index
Signed-off-by: Dong Xu Wang
---
block/raw-posix.c | 73 +++
1 file changed, 73 insertions(+)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index ba721d3..528b3d1 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -1069,6 +1069,29
Signed-off-by: Dong Xu Wang
---
block/vdi.c | 128
1 file changed, 128 insertions(+)
diff --git a/block/vdi.c b/block/vdi.c
index 8a91525..50bf24f 100644
--- a/block/vdi.c
+++ b/block/vdi.c
@@ -736,6 +736,102 @@ static int vdi_create
Signed-off-by: Dong Xu Wang
---
block/ssh.c | 69 +
1 file changed, 69 insertions(+)
diff --git a/block/ssh.c b/block/ssh.c
index d7e7bf8..7f1d5d7 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -709,6 +709,73 @@ static int ssh_create
Signed-off-by: Dong Xu Wang
---
block/gluster.c | 58 +
1 file changed, 58 insertions(+)
diff --git a/block/gluster.c b/block/gluster.c
index 645b7f1..eb9d644 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -407,6 +407,43 @@ out
Signed-off-by: Dong Xu Wang
---
block/rbd.c | 95 +
1 file changed, 95 insertions(+)
diff --git a/block/rbd.c b/block/rbd.c
index cb71751..4d5897c 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -368,6 +368,80 @@ static int
Signed-off-by: Dong Xu Wang
---
block/qcow2.c | 265 ++
1 file changed, 265 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 3376901..1c3249d 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1460,6 +1460,218 @@ static int
Signed-off-by: Dong Xu Wang
---
block/cow.c | 79 +
1 file changed, 79 insertions(+)
diff --git a/block/cow.c b/block/cow.c
index 1cc2e89..3a0d450 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -332,6 +332,83 @@ static
Signed-off-by: Dong Xu Wang
---
block/qed.c | 153
block/qed.h | 3 +-
2 files changed, 155 insertions(+), 1 deletion(-)
diff --git a/block/qed.c b/block/qed.c
index f767b05..348695f 100644
--- a/block/qed.c
+++ b/block/qed.c
Signed-off-by: Dong Xu Wang
---
block/qcow.c | 126 +++
1 file changed, 126 insertions(+)
diff --git a/block/qcow.c b/block/qcow.c
index 5239bd6..5b572d3 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -755,6 +755,107 @@ exit:
return
Signed-off-by: Dong Xu Wang
---
block/iscsi.c | 61 +++
1 file changed, 61 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index e7c1c2b..de2fd8c 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1305,6 +1305,65 @@ static
To make patches easy for reviewing, each block format is
a single patch. Add a new interface to block layer to make
sure origin code can compile and do not change any code
logic.
Signed-off-by: Dong Xu Wang
---
block.c | 51
r")
If "bar" has been set in opts, return its value.
Else, if opt's QemuOptDesc has a default value for "bar", return
that.
Else, return NULL.
Signed-off-by: Dong Xu Wang
Reviewed-by: Eric Blake
v13->v14:
1) change code style.
2) assert errors.
x typo.
v5->v6:
1) allocate enough space in append_opts_list function.
Signed-off-by: Dong Xu Wang
---
include/qemu/option.h | 3 +++
util/qemu-option.c| 73 +++
2 files changed, 76 insertions(+)
diff --git a/include/qemu/option.h b/inc
These functions will be used in next commit.
qemu_opt_get_(*)_del functions are used to make sure we
have the same behaviors as before: in block layer, after
parsing a parameter value, parameter list will delete it
to avoid parsing it twice.
Signed-off-by: Dong Xu Wang
v16->v17:
1) ret
v17->v18:
1) split into small patches, by each image format.
2) opt->str store digit, without suffixes in QemuOpt
Dong Xu Wang (25):
qemu-option: add def_value_str in QemuOptDesc struct and rewrite
qemu_opts_print
qemu-option: avoid duplication of default value in QemuOpts
qemu-
From: Xu Wang
Backing file loop should be checked before calling change_backing_
file(). If loop appeared, this calling should be stopped and an
error was printed.
Signed-off-by: Xu Wang
---
block.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block.c b/block.c
index 8bb63c2
From: Xu Wang
Backing file loop should be checked before qemu-img create command
execution. If loop was found, qemu-img create should be stopped and
an error was printed.
Signed-off-by: Xu Wang
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c
From: Xu Wang
If there is a loop exists in the backing file chain, many problems
could be caused by it, such as no response and segment fault during
system boot. Hence stopping backing file loop appear is very necessary.
This patch refine and export loop checking function from collect_image_
From: Xu Wang
Every image should be checked if there is infinite loop in backing
file chain before open it. So infinite loop check was added into
bdrv_new_open(). If @filename is opened with no flags
BDRV_O_NO_BACKING, the infinite loop check should be called.
Signed-off-by: Xu Wang
---
qemu
From: Xu Wang
Backing file should be checked if there is a loop in it during image
boot. Becase if there is loop qemu would no response for a long time
and segment fault occured. So this patch would check backing file
chain if there is loop in it before open image.
Signed-off-by: Xu Wang
From: Xu Wang
Method of get_inode is different between Linux and WIN32 plateform.
This patch added inode caculate method on Windows plateform so that
backing file check could work on Windows plateform.
Signed-off-by: Xu Wang
---
block.c | 156
From: Xu Wang
If there is loop exists in the backing file chain, many problems
could be caused by it, such as no response and segment fault during
system boot. Hence stopping backing file loop appear is very necessary.
These patches refine and export loop checking function from collect_image_
Backing file should be checked if there is a loop in it during image
boot. Becase if there is loop qemu would no response for a long time
and segment fault occured. So this patch would check backing file
chain if there is loop in it before open image.
Signed-off-by: Xu Wang
---
blockdev.c | 7
Backing file loop should be checked before calling change_backing_
file(). If loop appeared, this calling should be stopped and an
error was printed.
Signed-off-by: Xu Wang
---
block.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block.c b/block.c
index 9daf63c..d996524 100644
Backing file loop should be checked before qemu-img create command
execution. If loop was found, qemu-img create should be stopped and
an error was printed.
Signed-off-by: Xu Wang
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index
Method of get_inode is different between Linux and WIN32 plateform.
This patch added inode caculate method on Windows plateform so that
backing file check could work on Windows plateform.
Signed-off-by: Xu Wang
---
block.c | 160
block.c and build a independent function named bdrv_
backing_file_loop_check().
Signed-off-by: Xu Wang
---
block.c | 96 +++
include/block/block.h | 4 +++
qemu-img.c| 29 +---
3 files changed, 109 insertions
.
7. Added value of @fmt as suggested.
8. Added backing file loop check in qcow2.c/qed.c
Xu Wang (5):
block/qemu-img: Refine and export infinite loop checking in
collect_image_info_list()
block: Add WIN32 platform support for backing_file_loop_check()
block: Check infinite loop in
On Wed, Jul 17, 2013 at 8:54 PM, Eric Blake wrote:
> On 07/17/2013 03:29 AM, Dong Xu Wang wrote:
>> These patches will replace QEMUOptionParameter with QemuOpts. Change logs
>> please go to each patch's commit message.
>>
>> Dong Xu Wang (9):
>> qemu-op
Please ignore patch 8 and patch9, it won't work and I will re-send
them seperately.
Sorry for the inconvenience.
On Wed, Jul 17, 2013 at 5:29 PM, Dong Xu Wang
wrote:
> Signed-off-by: Dong Xu Wang
> ---
> util/qemu-option.c | 4
> 1 file changed, 4 insertions(+)
>
>
Signed-off-by: Dong Xu Wang
---
util/qemu-option.c | 4
1 file changed, 4 insertions(+)
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 7545486..f4a0282 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -656,6 +656,10 @@ void qemu_opts_del(QemuOpts *opts
QMP command query-command-line-options shows details information of
parameters, since added def_value_str, also output it in the QMP
command.
Signed-off-by: Dong Xu Wang
---
v16->v17:
1) add "Since 1.6" tag.
2) rename def_str_value to "default".
qapi-schema.json | 8 ++
r")
If "bar" has been set in opts, return its value.
Else, if opt's QemuOptDesc has a default value for "bar", return
that.
Else, return NULL.
Signed-off-by: Dong Xu Wang
Reviewed-by: Eric Blake
Signed-off-by: Dong Xu Wang
---
Reviewed-by: Eric Blake
Signed-off-by: Dong Xu Wang
---
include/qemu/option.h | 39 ---
util/qemu-option.c| 285 --
2 files changed, 324 deletions(-)
diff --git a/include/qemu/option.h b/include/qemu/option.h
index 12fa8b4..2aaa057
These functions will be used in next commit.
qemu_opt_get_(*)_del functions are used to make sure we
have the same behaviors as before: in block layer, after
parsing a parameter value, parameter list will delete it
to avoid parsing it twice.
Signed-off-by: Dong Xu Wang
---
v16->v17:
1) ret
Signed-off-by: Dong Xu Wang
---
block.c| 8 ++--
hw/core/qdev.c | 4 +---
qemu-char.c| 4 +---
qemu-img.c | 4 +---
4 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/block.c b/block.c
index e1d1c3d..e700593 100644
--- a/block.c
+++ b/block.c
@@ -408,9 +408,7
2. Option descriptors may provide a default value.
3. Print to stdout instead of stderr.
Previously the behavior was to print every option that has been set.
Options that have not been set would be skipped.
Reviewed-by: Eric Blake
Signed-off-by: Dong Xu Wang
---
v13->v14:
1) fix memory
These patches will replace QEMUOptionParameter with QemuOpts. Change logs
please go to each patch's commit message.
Dong Xu Wang (9):
qemu-option: add def_value_str in QemuOptDesc struct and rewrite
qemu_opts_print
qemu-option: avoid duplication of default value in QemuOpts
qemu-o
This patch creates 4 functions, count_opts_list, qemu_opts_append,
qemu_opts_free and qemu_opts_print_help, they are used in following
commits.
Signed-off-by: Dong Xu Wang
---
v16->v17:
1) fix indentation.
2) fix typo.
v15->v16:
1) discard double-initialization.
2) use pointer directl
Add backing file loop check before execute change backing file for
qed format.
Signed-off-by: Xu Wang
---
block/qed.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block/qed.c b/block/qed.c
index f767b05..79c2875 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -1468,6 +1468,13
Backing file loop should be checked before calling change_backing_
file(). If loop appeared, this calling should be stopped and an
error was printed.
Signed-off-by: Xu Wang
---
block.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/block.c b/block.c
index e9b9112..bd8240c 100644
Backing file should be checked if there is a loop in it during image
boot. Becase if there is loop qemu would no response for a long time
and segment fault occured. So this patch would check backing file
chain if there is loop in it before open image.
Signed-off-by: Xu Wang
---
blockdev.c | 6
Backing file loop should be checked before qemu-img create command
execution. If loop was found, qemu-img create should be stopped and
an error was printed.
Signed-off-by: Xu Wang
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index
Method of get_inode is different between Linux and WIN32 plateform.
This patch added inode caculate method on Windows plateform so that
backing file check could work on Windows plateform.
Signed-off-by: Xu Wang
---
block.c | 109
Add backing file loop check before execute change backing file for
qcow2 format.
Signed-off-by: Xu Wang
---
block/qcow2.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 0eceefe..01bd7d5 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1195,6
block.c and build a independent function named bdrv_
backing_file_loop_check().
Signed-off-by: Xu Wang
---
block.c | 97 +++
include/block/block.h | 4 +++
qemu-img.c| 29 +--
3 files changed, 110 insertions(+), 20
suggested.
8. Added backing file loop check in qcow2.c/qed.c
Xu Wang (7):
block/qemu-img: Refine and export infinite loop checking in
collect_image_info_list()
block: Add WIN32 platform support for backing_file_loop_check()
block: Check infinite loop in bdrv_img_create()
block: Add
On Thu, Jul 11, 2013 at 3:49 AM, Eric Blake wrote:
> On 07/09/2013 02:41 PM, Eric Blake wrote:
>> On 07/04/2013 06:52 AM, Stefan Hajnoczi wrote:
>>> On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote:
>>>> These patches will replace QEMUOptionParame
2013/7/10 Fam Zheng
> On Mon, 07/08 03:26, Xu Wang wrote:
> > Signed-off-by: Xu Wang
> > ---
> > block.c | 94
> +
> > 1 file changed, 94 insertions(+)
> >
> > diff --git a/block.c b
2013/7/10 Fam Zheng
> On Mon, 07/08 03:26, Xu Wang wrote:
> > Signed-off-by: Xu Wang
> > ---
> > block.c | 101
> ++
> > include/block/block.h | 4 ++
> > qemu-img.c| 30 +
2013/6/29 Eric Blake
> On 06/27/2013 01:38 AM, Xu Wang wrote:
> > From: Xu Wang
> >
> > Signed-off-by: Xu Wang
> > ---
> > qemu-img.c | 110
> +
> > 1 file changed, 89 insertions(+), 21
Signed-off-by: Xu Wang
---
blockdev.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/blockdev.c b/blockdev.c
index 5975dde..0178764 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -695,6 +695,11 @@ DriveInfo *drive_init(QemuOpts *all_opts,
BlockInterfaceType block_default_type
Signed-off-by: Xu Wang
---
block.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index 8dc6ded..6df25d9 100644
--- a/block.c
+++ b/block.c
@@ -4688,15 +4688,15 @@ void bdrv_img_create(const char *filename, const char
*fmt
Signed-off-by: Xu Wang
---
block.c | 94 +
1 file changed, 94 insertions(+)
diff --git a/block.c b/block.c
index 53b1a01..8dc6ded 100644
--- a/block.c
+++ b/block.c
@@ -4431,6 +4431,83 @@ bdrv_acct_done(BlockDriverState *bs
1 - 100 of 423 matches
Mail list logo
